Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292727 > unrolled thread

linux-next: build failure after merge of the gpio tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2015-12-16 04:40 +0100
Last post2015-12-21 09:50 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  linux-next: build failure after merge of the gpio tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-12-16 04:40 +0100
    RE: linux-next: build failure after merge of the gpio tree Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com> - 2015-12-16 05:00 +0100
    Re: linux-next: build failure after merge of the gpio tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-12-21 06:10 +0100
      Re: linux-next: build failure after merge of the gpio tree Linus Walleij <linus.walleij@linaro.org> - 2015-12-21 09:50 +0100

#1292727 — linux-next: build failure after merge of the gpio tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2015-12-16 04:40 +0100
Subjectlinux-next: build failure after merge of the gpio tree
Message-ID<qGb6y-4Rr-3@gated-at.bofh.it>
Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
    set_irq_flags(irq, IRQF_VALID);
    ^
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
    set_irq_flags(irq, IRQF_VALID);
                       ^

Caused by commit

  8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")

set_irq_flags was removed before v4.3-rc2 ...

I have used the gpio tree from next-20151215 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1292742

FromYendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>
Date2015-12-16 05:00 +0100
Message-ID<qGbpU-4Ya-7@gated-at.bofh.it>
In reply to#1292727
Hi Stephen,

  Sorry. It's my mistake. In the first patch set, I tested it with "irq_clear_status_flags(irq, IRQ_NOREQUEST);" and in the v2 patch set the old one got in.

Regards
Dhananjay
 
-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: Wednesday, December 16, 2015 9:08 AM
To: Linus Walleij
Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Yendapally Reddy Dhananjaya Reddy
Subject: linux-next: build failure after merge of the gpio tree

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
    set_irq_flags(irq, IRQF_VALID);
    ^
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
    set_irq_flags(irq, IRQF_VALID);
                       ^

Caused by commit

  8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")

set_irq_flags was removed before v4.3-rc2 ...

I have used the gpio tree from next-20151215 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1295771

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2015-12-21 06:10 +0100
Message-ID<qI0To-2aO-7@gated-at.bofh.it>
In reply to#1292727
Hi Linus,

On Wed, 16 Dec 2015 14:37:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
>     set_irq_flags(irq, IRQF_VALID);
>     ^
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
>     set_irq_flags(irq, IRQF_VALID);
>                        ^
> 
> Caused by commit
> 
>   8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
> 
> set_irq_flags was removed before v4.3-rc2 ...
> 
> I have used the gpio tree from next-20151215 for today.

I am still getting this error.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1295831

FromLinus Walleij <linus.walleij@linaro.org>
Date2015-12-21 09:50 +0100
Message-ID<qI4kh-4cb-1@gated-at.bofh.it>
In reply to#1295771
On Mon, Dec 21, 2015 at 6:02 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> On Wed, 16 Dec 2015 14:37:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the gpio tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
>>     set_irq_flags(irq, IRQF_VALID);
>>     ^
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
>>     set_irq_flags(irq, IRQF_VALID);
>>                        ^
>>
>> Caused by commit
>>
>>   8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
>>
>> set_irq_flags was removed before v4.3-rc2 ...
>>
>> I have used the gpio tree from next-20151215 for today.
>
> I am still getting this error.

Yeah I was applying the fix to the pin control tree, never fix stuff late on
fridays... will apply the patch to the GPIO tree as well, I see no better
solution.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web