Re: linux-next: build failure after merge of the gpio tree

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: linux-next: build failure after merge of the gpio tree
Date	2015-12-21 09:50 +0100
Message-ID	<qI4kh-4cb-1@gated-at.bofh.it> (permalink)
References	<qGb6y-4Rr-3@gated-at.bofh.it> <qI0To-2aO-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 21, 2015 at 6:02 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> On Wed, 16 Dec 2015 14:37:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the gpio tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
>>     set_irq_flags(irq, IRQF_VALID);
>>     ^
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
>>     set_irq_flags(irq, IRQF_VALID);
>>                        ^
>>
>> Caused by commit
>>
>>   8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
>>
>> set_irq_flags was removed before v4.3-rc2 ...
>>
>> I have used the gpio tree from next-20151215 for today.
>
> I am still getting this error.

Yeah I was applying the fix to the pin control tree, never fix stuff late on
fridays... will apply the patch to the GPIO tree as well, I see no better
solution.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the gpio tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-12-16 04:40 +0100
  RE: linux-next: build failure after merge of the gpio tree Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com> - 2015-12-16 05:00 +0100
  Re: linux-next: build failure after merge of the gpio tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-12-21 06:10 +0100
    Re: linux-next: build failure after merge of the gpio tree Linus Walleij <linus.walleij@linaro.org> - 2015-12-21 09:50 +0100

csiph-web