Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1294935 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2015-12-18 16:00 +0100 |
| Last post | 2015-12-18 17:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] hwmon: sht15 needs CONFIG_BITREVERSE Arnd Bergmann <arnd@arndb.de> - 2015-12-18 16:00 +0100
Re: [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE Guenter Roeck <linux@roeck-us.net> - 2015-12-18 17:30 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-12-18 16:00 +0100 |
| Subject | [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE |
| Message-ID | <qH4FI-6Xw-11@gated-at.bofh.it> |
If CONFIG_BITREVERSE is not built-in, the sht15 driver fails to link:
drivers/built-in.o: In function `sht15_crc8':
drivers/hwmon/sht15.c:195: undefined reference to `byte_rev_table'
This adds a Kconfig 'select' statement, like all other users of
bitrev.h have it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 33836ee98533 ("hwmon:change sht15_reverse()")
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 4a6e7c217329..60fb80bd353d 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1207,6 +1207,7 @@ config SENSORS_PWM_FAN
config SENSORS_SHT15
tristate "Sensiron humidity and temperature sensors. SHT15 and compat."
depends on GPIOLIB || COMPILE_TEST
+ select BITREVERSE
help
If you say yes here you get support for the Sensiron SHT10, SHT11,
SHT15, SHT71, SHT75 humidity and temperature sensors.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2015-12-18 17:30 +0100 |
| Message-ID | <qH64N-7Y5-1@gated-at.bofh.it> |
| In reply to | #1294935 |
On 12/18/2015 06:52 AM, Arnd Bergmann wrote:
> If CONFIG_BITREVERSE is not built-in, the sht15 driver fails to link:
>
> drivers/built-in.o: In function `sht15_crc8':
> drivers/hwmon/sht15.c:195: undefined reference to `byte_rev_table'
>
> This adds a Kconfig 'select' statement, like all other users of
> bitrev.h have it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 33836ee98533 ("hwmon:change sht15_reverse()")
Good catch. Applied.
Thanks,
Guenter
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 4a6e7c217329..60fb80bd353d 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1207,6 +1207,7 @@ config SENSORS_PWM_FAN
> config SENSORS_SHT15
> tristate "Sensiron humidity and temperature sensors. SHT15 and compat."
> depends on GPIOLIB || COMPILE_TEST
> + select BITREVERSE
> help
> If you say yes here you get support for the Sensiron SHT10, SHT11,
> SHT15, SHT71, SHT75 humidity and temperature sensors.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web