[PATCH] hwmon: sht15 needs CONFIG_BITREVERSE

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] hwmon: sht15 needs CONFIG_BITREVERSE
Date	2015-12-18 16:00 +0100
Message-ID	<qH4FI-6Xw-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If CONFIG_BITREVERSE is not built-in, the sht15 driver fails to link:

drivers/built-in.o: In function `sht15_crc8':
drivers/hwmon/sht15.c:195: undefined reference to `byte_rev_table'

This adds a Kconfig 'select' statement, like all other users of
bitrev.h have it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 33836ee98533 ("hwmon:change sht15_reverse()")

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 4a6e7c217329..60fb80bd353d 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1207,6 +1207,7 @@ config SENSORS_PWM_FAN
 config SENSORS_SHT15
 	tristate "Sensiron humidity and temperature sensors. SHT15 and compat."
 	depends on GPIOLIB || COMPILE_TEST
+	select BITREVERSE
 	help
 	  If you say yes here you get support for the Sensiron SHT10, SHT11,
 	  SHT15, SHT71, SHT75 humidity and temperature sensors.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] hwmon: sht15 needs CONFIG_BITREVERSE Arnd Bergmann <arnd@arndb.de> - 2015-12-18 16:00 +0100
  Re: [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE Guenter Roeck <linux@roeck-us.net> - 2015-12-18 17:30 +0100

csiph-web