Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1292903 > unrolled thread
| Started by | "Kweh, Hock Leong" <hock.leong.kweh@intel.com> |
|---|---|
| First post | 2015-12-16 12:20 +0100 |
| Last post | 2015-12-17 03:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
RE: [PATCH v9 1/1] efi: a misc char interface for user to update efi firmware "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-12-16 12:20 +0100
Re: [PATCH v9 1/1] efi: a misc char interface for user to update efi firmware Borislav Petkov <bp@alien8.de> - 2015-12-16 12:30 +0100
RE: [PATCH v9 1/1] efi: a misc char interface for user to update efi firmware "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-12-17 03:00 +0100
| From | "Kweh, Hock Leong" <hock.leong.kweh@intel.com> |
|---|---|
| Date | 2015-12-16 12:20 +0100 |
| Subject | RE: [PATCH v9 1/1] efi: a misc char interface for user to update efi firmware |
| Message-ID | <qGihI-12A-13@gated-at.bofh.it> |
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBCb3Jpc2xhdiBQZXRrb3YgW21h aWx0bzpicEBhbGllbjguZGVdDQo+IFNlbnQ6IFdlZG5lc2RheSwgTm92ZW1iZXIgMDQsIDIwMTUg NDowMCBBTQ0KPiANCj4gT24gTW9uLCBOb3YgMDIsIDIwMTUgYXQgMDY6NDc6MjlBTSArMDAwMCwg S3dlaCwgSG9jayBMZW9uZyB3cm90ZToNCj4gPiBCeSBsb29raW5nIGF0IHlvdXIgZG1lc2cgbG9n LCB0aGUgYWJvdmUgcHJpbnQgb3V0IG1lc3NhZ2Ugc2VlbSB0aGF0DQo+ID4gc29tZW9uZSBoYXMg Y2FsbGVkIHRoZSBmbHVzaCgpIGFmdGVyIHRoZSB3cml0ZSgyKS4gSW4gbXkgZW52aXJvbm1lbnQs DQo+IGZsdXNoKCkNCj4gPiBvbmx5IGJlaW5nIGNhbGxlZCBpbiAyIHBsYWNlcyB3aGljaCBhcmUg YmVmb3JlIHdyaXRlKDIpIGFuZCBkdXJpbmcgY2xvc2UoMikuDQo+ID4gVGhlIGRtZXNnIGxvZyBz ZWVtcyB0aGF0IHlvdXIgZW52aXJvbm1lbnQgaXMgcnVubmluZyB3cml0ZSgyKSBhbmQgZmx1c2go KQ0KPiBpbg0KPiA+IGRpZmZlcmVudCB0aHJlYWRzIGFuZCBhcmUgcGFyYWxsZWwuIENvdWxkIHlv dSBoZWxwIG1lIHRvIGRvdWJsZSBjb25maXJtIHRoaXMNCj4gYW5kIGl0DQo+ID4gd291bGQgYmUg Z29vZCBpZiB5b3UgY291bGQgdG9sZCBtZSB3aGVuIHRoZSBmbHVzaCgpIGlzIGV4YWN0bHkgYmVp bmcgY2FsbGVkDQo+IGluDQo+ID4geW91ciBlbnZpcm9ubWVudC4gVGhlIGluZm8gcmVhbGx5IGhl bHAgbWUgb24gZGVidWdnaW5nLg0KPiANCj4gSSBkb24ndCBrbm93IHdoYXQgeW91IG1lYW46IEkg c2ltcGx5IGRvDQo+IA0KPiBjYXQgL2Jpbi9scyA+IC9kZXYvZWZpX2NhcHN1bGVfbG9hZGVyDQo+ IA0KPiBhcyByb290IGluIGFuIFNNUCBrdm0gZ3Vlc3QuIEFuZCBpdCBleHBsb2Rlcy4gTm90aGlu ZyBzcGVjaWFsLCBqdXN0IHRoaXMNCj4gb25lIGNvbW1hbmQuDQo+IA0KPiBJIGd1ZXNzIHlvdSBj b3VsZCB0cnkgdG8gcmVwcm9kdWNlIGl0LCBoZXJlJ3MgaG93IEkgc3RhcnQgaXQ6DQo+IA0KPiBx ZW11LXN5c3RlbS14ODZfNjQNCj4gLWVuYWJsZS1rdm0NCj4gLWdkYiB0Y3A6OjEyMzQNCj4gLWNw dSBPcHRlcm9uX0c1DQo+IC1tIDIwNDgNCj4gLWhkYSAvaG9tZS9ib3Jpcy9rdm0vZGViaWFuL3Np ZC14ODZfNjQuaW1nDQo+IC1oZGIgL2hvbWUvYm9yaXMva3ZtL3N3YXAuaW1nDQo+IC1ib290IG1l bnU9b2ZmLG9yZGVyPWMNCj4gLWxvY2FsdGltZQ0KPiAtbmV0IG5pYyxtb2RlbD1ydGw4MTM5DQo+ IC1uZXQgdXNlcixob3N0ZndkPXRjcDo6MTIzNS06MjINCj4gLXVzYmRldmljZSB0YWJsZXQNCj4g LWtlcm5lbCAvaG9tZS9ib3Jpcy9rZXJuZWwvbGludXgtMi42L2FyY2gveDg2L2Jvb3QvYnpJbWFn ZQ0KPiAtYXBwZW5kICJyb290PS9kZXYvc2RhMSByZXN1bWU9L2Rldi9zZGIxIGRlYnVnIGlnbm9y ZV9sb2dsZXZlbA0KPiBsb2dfYnVmX2xlbj0xNk0gZWFybHlwcmludGs9dHR5UzAsMTE1MjAwIGNv bnNvbGU9dHR5UzAsMTE1MjAwDQo+IGNvbnNvbGU9dHR5MCINCj4gLW1vbml0b3IgcHR5DQo+IC12 aXJ0ZnMgbG9jYWwscGF0aD0vdG1wLG1vdW50X3RhZz10bXAsc2VjdXJpdHlfbW9kZWw9bm9uZQ0K PiAtc2VyaWFsIGZpbGU6L2hvbWUvYm9yaXMva3ZtL3Rlc3QteDg2XzY0LTEyMzUubG9nDQo+IC1z bmFwc2hvdA0KPiAtc21wIDgNCj4gDQo+IEhUSC4NCj4gDQo+IC0tDQo+IFJlZ2FyZHMvR3J1c3Ms DQo+ICAgICBCb3Jpcy4NCg0KSGkgQm9yaXNsYXYsDQoNCkZpbmFsbHkgYWJsZSB0byBmcmVlIHVw IDI1R0Igc3BhY2UgdG8gc2V0dXAgYSBRRU1VIFZNIHdpdGggRGViaWFuIHY4LjIuMA0Kc3lzdGVt IGFuZCBsb29rIGludG8gdGhpcyBpc3N1ZS4gTG9jYXRlZCB0aGUgTlVMTCBwb2ludGVyIGhhcHBl bmVkIGF0IGNvZGUgbGluZToNCg0Kc3RhdHVzID0gZWZpLnF1ZXJ5X2NhcHN1bGVfY2FwcygmY2Fw c3VsZSwgMSwgJm1heF9zaXplLCByZXNldCk7DQoNCndoaWNoIGlzIGluc2lkZSBmdW5jdGlvbiBl ZmlfY2Fwc3VsZV9zdXBwb3J0ZWQoKS4gVGhpcyBmdW5jdGlvbiBjYWxsIGlzIGluaXRpYWxpemVk IGJ5DQpFRkkgRmlybXdhcmUgcnVuLXRpbWUgc2VydmljZSB0YWJsZS4gU28sIEkgYmVsaWV2ZSB0 aGUgUUVNVSBkbyBub3QgZW11bGF0ZSB0aGUNCkVGSSBGaXJtd2FyZSBydW4tdGltZSBzZXJ2aWNl IEFQSSBjYWxscy4gVGhpcyBpcyB3aHkgd2hlbiBjb21lIHRvIHRoaXMgbGluZSBpdCBoaXQNCnRo ZSBOVUxMIHBvaW50ZXIgaXNzdWUuDQoNClNvLCBteSBjb25jbHVzaW9uIGlzIHRoYXQgdGhpcyBt b2R1bGUgaXMgbm90IGFibGUgdG8gYmUgdGVzdGVkIG9uIFFFTVUgZW52aXJvbm1lbnQuDQoNClRo YW5rcyAmIFJlZ2FyZHMsDQpXaWxzb24NCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2015-12-16 12:30 +0100 |
| Subject | Re: [PATCH v9 1/1] efi: a misc char interface for user to update efi firmware |
| Message-ID | <qGirp-175-51@gated-at.bofh.it> |
| In reply to | #1292903 |
On Wed, Dec 16, 2015 at 11:09:50AM +0000, Kweh, Hock Leong wrote:
> So, my conclusion is that this module is not able to be tested on QEMU
> environment.
That's not the point.
The module should better handle writing to the device file gracefully
and not explode. Regardless of whether it is running on an EFI system or
not.
efi_capsule_loader_init() simply loads the driver on *any* system,
even a !UEFI one. And when I write some garbage to the device file, it
explodes.
What it should do instead is check whether it is being loaded on en EFI
system and whether all it needs to function properly is initialized
already, like runtime services. If not, it should refuse to load.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Kweh, Hock Leong" <hock.leong.kweh@intel.com> |
|---|---|
| Date | 2015-12-17 03:00 +0100 |
| Message-ID | <qGw1k-1cK-3@gated-at.bofh.it> |
| In reply to | #1292913 |
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBCb3Jpc2xhdiBQZXRrb3YgW21h aWx0bzpicEBhbGllbjguZGVdDQo+IFNlbnQ6IFdlZG5lc2RheSwgRGVjZW1iZXIgMTYsIDIwMTUg NzoyNiBQTQ0KPiBUbzogS3dlaCwgSG9jayBMZW9uZw0KPiBDYzogTWF0dCBGbGVtaW5nOyBHcmVn IEtyb2FoLUhhcnRtYW47IE9uZywgQm9vbiBMZW9uZzsgTEtNTDsgbGludXgtDQo+IGVmaUB2Z2Vy Lmtlcm5lbC5vcmc7IFNhbSBQcm90c2Vua287IFBldGVyIEpvbmVzOyBBbmR5IEx1dG9taXJza2k7 IFJveQ0KPiBGcmFuejsgSmFtZXMgQm90dG9tbGV5OyBMaW51eCBGUyBEZXZlbDsgQW52aW4sIEgg UGV0ZXI7ICdNYXR0IEZsZW1pbmcnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjkgMS8xXSBlZmk6 IGEgbWlzYyBjaGFyIGludGVyZmFjZSBmb3IgdXNlciB0byB1cGRhdGUgZWZpDQo+IGZpcm13YXJl DQo+IA0KPiBPbiBXZWQsIERlYyAxNiwgMjAxNSBhdCAxMTowOTo1MEFNICswMDAwLCBLd2VoLCBI b2NrIExlb25nIHdyb3RlOg0KPiA+IFNvLCBteSBjb25jbHVzaW9uIGlzIHRoYXQgdGhpcyBtb2R1 bGUgaXMgbm90IGFibGUgdG8gYmUgdGVzdGVkIG9uIFFFTVUNCj4gPiBlbnZpcm9ubWVudC4NCj4g DQo+IFRoYXQncyBub3QgdGhlIHBvaW50Lg0KPiANCj4gVGhlIG1vZHVsZSBzaG91bGQgYmV0dGVy IGhhbmRsZSB3cml0aW5nIHRvIHRoZSBkZXZpY2UgZmlsZSBncmFjZWZ1bGx5DQo+IGFuZCBub3Qg ZXhwbG9kZS4gUmVnYXJkbGVzcyBvZiB3aGV0aGVyIGl0IGlzIHJ1bm5pbmcgb24gYW4gRUZJIHN5 c3RlbSBvcg0KPiBub3QuDQo+IA0KPiBlZmlfY2Fwc3VsZV9sb2FkZXJfaW5pdCgpIHNpbXBseSBs b2FkcyB0aGUgZHJpdmVyIG9uICphbnkqIHN5c3RlbSwNCj4gZXZlbiBhICFVRUZJIG9uZS4gQW5k IHdoZW4gSSB3cml0ZSBzb21lIGdhcmJhZ2UgdG8gdGhlIGRldmljZSBmaWxlLCBpdA0KPiBleHBs b2Rlcy4NCj4gDQo+IFdoYXQgaXQgc2hvdWxkIGRvIGluc3RlYWQgaXMgY2hlY2sgd2hldGhlciBp dCBpcyBiZWluZyBsb2FkZWQgb24gZW4gRUZJDQo+IHN5c3RlbSBhbmQgd2hldGhlciBhbGwgaXQg bmVlZHMgdG8gZnVuY3Rpb24gcHJvcGVybHkgaXMgaW5pdGlhbGl6ZWQNCj4gYWxyZWFkeSwgbGlr ZSBydW50aW1lIHNlcnZpY2VzLiBJZiBub3QsIGl0IHNob3VsZCByZWZ1c2UgdG8gbG9hZC4NCj4g DQo+IC0tDQo+IFJlZ2FyZHMvR3J1c3MsDQo+ICAgICBCb3Jpcy4NCg0KSGkgQm9yaXNsYXYsDQoN CkkgY2F0Y2ggeW91ciBwb2ludCBub3cuIEkgd2lsbCBmaXggdGhhdCBpbiB2MTAgcGF0Y2guDQoN ClRoYW5rcyAmIFJlZ2FyZHMsDQpXaWxzb24NCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web