Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292913

Re: [PATCH v9 1/1] efi: a misc char interface for user to update efi firmware

Show all headers | View raw

On Wed, Dec 16, 2015 at 11:09:50AM +0000, Kweh, Hock Leong wrote:
> So, my conclusion is that this module is not able to be tested on QEMU
> environment.

That's not the point.

The module should better handle writing to the device file gracefully
and not explode. Regardless of whether it is running on an EFI system or
not.

efi_capsule_loader_init() simply loads the driver on *any* system,
even a !UEFI one. And when I write some garbage to the device file, it
explodes.

What it should do instead is check whether it is being loaded on en EFI
system and whether all it needs to function properly is initialized
already, like runtime services. If not, it should refuse to load.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

RE: [PATCH v9 1/1] efi: a misc char interface for user to update  efi firmware "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-12-16 12:20 +0100
  Re: [PATCH v9 1/1] efi: a misc char interface for user to update efi  firmware Borislav Petkov <bp@alien8.de> - 2015-12-16 12:30 +0100
    RE: [PATCH v9 1/1] efi: a misc char interface for user to update  efi firmware "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-12-17 03:00 +0100

csiph-web