Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1293058 > unrolled thread
| Started by | Anton Wuerfel <anton.wuerfel@fau.de> |
|---|---|
| First post | 2015-12-16 16:50 +0100 |
| Last post | 2015-12-18 13:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 08/11] tty: serial: 8250: Add parentheses to macro Anton Wuerfel <anton.wuerfel@fau.de> - 2015-12-16 16:50 +0100
Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-17 16:20 +0100
Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro anton.wuerfel@fau.de - 2015-12-18 12:50 +0100
Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-18 13:40 +0100
| From | Anton Wuerfel <anton.wuerfel@fau.de> |
|---|---|
| Date | 2015-12-16 16:50 +0100 |
| Subject | [PATCH 08/11] tty: serial: 8250: Add parentheses to macro |
| Message-ID | <qGmv0-3Cs-39@gated-at.bofh.it> |
This patch fixes a checkpatch warning caused by missing parentheses in the definition of a macro. Signed-off-by: Anton Würfel <anton.wuerfel@fau.de> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de> CC: linux-kernel@i4.cs.fau.de --- drivers/tty/serial/8250/8250_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index 67147b2..3c29530 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -686,7 +686,7 @@ static int __init univ8250_console_init(void) } console_initcall(univ8250_console_init); -#define SERIAL8250_CONSOLE &univ8250_console +#define SERIAL8250_CONSOLE (&univ8250_console) #else #define SERIAL8250_CONSOLE NULL #endif -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2015-12-17 16:20 +0100 |
| Message-ID | <qGIvv-18F-5@gated-at.bofh.it> |
| In reply to | #1293058 |
On Wed, 2015-12-16 at 16:36 +0100, Anton Wuerfel wrote: > This patch fixes a checkpatch warning caused by missing parentheses > in the definition of a macro. > > Signed-off-by: Anton Würfel <anton.wuerfel@fau.de> > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de> > CC: linux-kernel@i4.cs.fau.de > --- > drivers/tty/serial/8250/8250_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c > b/drivers/tty/serial/8250/8250_core.c > index 67147b2..3c29530 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -686,7 +686,7 @@ static int __init univ8250_console_init(void) > } > console_initcall(univ8250_console_init); > > -#define SERIAL8250_CONSOLE &univ8250_console > +#define SERIAL8250_CONSOLE (&univ8250_console) What about the rest of the drivers under drivers/tty/serial? What do you propose to do with, for example, the following drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define CPM_UART_CONSOLE &cpm_scc_uart_console drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define CPM_UART_CONSOLE NULL > #else > #define SERIAL8250_CONSOLE NULL > #endif -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | anton.wuerfel@fau.de |
|---|---|
| Date | 2015-12-18 12:50 +0100 |
| Message-ID | <qH1HQ-55K-21@gated-at.bofh.it> |
| In reply to | #1293973 |
Hello Andy, > What about the rest of the drivers under drivers/tty/serial? > > What do you propose to do with, for example, the following > > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define > CPM_UART_CONSOLE &cpm_scc_uart_console > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define > CPM_UART_CONSOLE NULL > >> #else >> #define SERIAL8250_CONSOLE NULL >> #endif > thanks for your reply. Phillip and me are newcomers to kernel development, so we tried to touch as few files as possible and gain some experience in creating patches and communication on LKML. We will consider sending further patches in the future. Regards, Phillip Raffeck Anton Wuerfel > -- > Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Intel Finland Oy > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2015-12-18 13:40 +0100 |
| Message-ID | <qH2ud-5E7-13@gated-at.bofh.it> |
| In reply to | #1294719 |
On Fri, 2015-12-18 at 12:36 +0100, anton.wuerfel@fau.de wrote: > Hello Andy, > > > What about the rest of the drivers under drivers/tty/serial? > > > > What do you propose to do with, for example, the following > > > > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define > > CPM_UART_CONSOLE &cpm_scc_uart_console > > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define > > CPM_UART_CONSOLE NULL > > > > > #else > > > #define SERIAL8250_CONSOLE NULL > > > #endif > > > > thanks for your reply. Phillip and me are newcomers to kernel > development, Welcome! > so we tried to touch as few files as possible and gain some > experience in > creating patches and communication on LKML. We will consider sending > further patches in the future. I see. I don't know which way is preferable for such patches, I think Greg usually likes when one patch touches one driver. So, this one is okay, and other drivers can be fixed later. > Regards, > Phillip Raffeck > Anton Wuerfel > > > -- > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Intel Finland Oy > > > > > > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web