Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro
Date	2015-12-18 13:40 +0100
Message-ID	<qH2ud-5E7-13@gated-at.bofh.it> (permalink)
References	<qGmuZ-3Cs-7@gated-at.bofh.it> <qGmv0-3Cs-39@gated-at.bofh.it> <qGIvv-18F-5@gated-at.bofh.it> <qH1HQ-55K-21@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Fri, 2015-12-18 at 12:36 +0100, anton.wuerfel@fau.de wrote:
> Hello Andy,
> 
> > What about the rest of the drivers under drivers/tty/serial?
> > 
> > What do you propose to do with, for example, the following
> > 
> > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define
> > CPM_UART_CONSOLE       &cpm_scc_uart_console
> > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define
> > CPM_UART_CONSOLE       NULL
> > 
> > >  #else
> > >  #define SERIAL8250_CONSOLE	NULL
> > >  #endif
> > 
> 
> thanks for your reply. Phillip and me are newcomers to kernel
> development,

Welcome!

> so we tried to touch as few files as possible and gain some
> experience in
> creating patches and communication on LKML. We will consider sending
> further patches in the future.

I see.

I don't know which way is preferable for such patches, I think Greg
usually likes when one patch touches one driver. So, this one is okay,
and other drivers can be fixed later.



> Regards,
> Phillip Raffeck
> Anton Wuerfel
> 
> > --
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Intel Finland Oy
> > 
> > 
> 
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 08/11] tty: serial: 8250: Add parentheses to macro Anton Wuerfel <anton.wuerfel@fau.de> - 2015-12-16 16:50 +0100
  Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-17 16:20 +0100
    Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro anton.wuerfel@fau.de - 2015-12-18 12:50 +0100
      Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-18 13:40 +0100

csiph-web