Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289549 > unrolled thread

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-11 14:10 +0100
    Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-11 15:20 +0100
    Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-11 15:20 +0100
    Re: [PATCH] staging: dgnc: Update the TODO file Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-12 07:20 +0100
    Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-12 07:30 +0100
      Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-12 10:00 +0100
        Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-12 11:10 +0100
          Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-12 11:20 +0100
            Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-12 11:30 +0100
        Re: [PATCH 3/3] staging: dgnc: Patch includes the checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-12 13:10 +0100
        Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-12 13:20 +0100
        Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch  fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-14 22:40 +0100
          Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the  checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-15 05:10 +0100
            Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch  fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 05:40 +0100
              Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the  checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-15 05:50 +0100
                Re: [PATCH FIXED 3/3] staging: dgnc: Patch updates the TODO file Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-15 06:30 +0100
                Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch  fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 06:30 +0100
                  Re: [PATCH FIXED 1/3] staging: dgnc: Patch includes the checkpatch  fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 06:50 +0100
                    Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 07:40 +0100
                    Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2015-12-15 07:40 +0100

#1289549 — Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote:
> >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001
> From: Sanidhya Solanki <jpage.lkml@gmail.com>
> Date: Fri, 11 Dec 2015 03:08:53 -0500
> Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes


Don't include this stuff.

> 
> Patch contains the checkpatch fixes as asked by the TODO.
> TODO file is updated as well.

Fix one type of warning at a time.  This will be a series of patches.

> 
> Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
> @@ -110,7 +98,16 @@ static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr,
>  	int count = 0;
>  	int i = 0;
>  
> -	DGNC_VERIFY_BOARD(p, bd);
> +	do {
> +		if (!p)
> +			return 0;
> +
> +		bd = dev_get_drvdata(p);
> +		if (!bd || bd->magic != DGNC_BOARD_MAGIC)
> +			return 0;
> +		if (bd->state != BOARD_READY)
> +			return 0;
> +	} while (0);

Google about why do while(0) loops are used in macros and then redo
this.  Mostly the patch isn't bad, but I suspect I'm going to complain
about how you split up some of the long lines.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1289613

On Fri, Dec 11, 2015 at 05:10:43AM -0500, Sanidhya Solanki wrote:
> On Fri, 11 Dec 2015 16:02:33 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 
> > > Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
> > > @@ -110,7 +98,16 @@ static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr,
> > >  	int count = 0;
> > >  	int i = 0;
> > >  
> > > -	DGNC_VERIFY_BOARD(p, bd);
> > > +	do {
> > > +		if (!p)
> > > +			return 0;
> > > +
> > > +		bd = dev_get_drvdata(p);
> > > +		if (!bd || bd->magic != DGNC_BOARD_MAGIC)
> > > +			return 0;
> > > +		if (bd->state != BOARD_READY)
> > > +			return 0;
> > > +	} while (0);
> > 
> > Google about why do while(0) loops are used in macros and then redo
> > this.  Mostly the patch isn't bad, but I suspect I'm going to complain
> > about how you split up some of the long lines.
> 
> Let me just be completely sure that you and I are on the same page
> here. The macro was used to replace the do-while loop, I replaced all
> instances of the macro with the the actual loop. Both pieces were
> originally part of the code, just using macros in place of do-while
> statements. Do you still want me to change it? Maybe the original
> author did it for a specific reason.
> 

https://www.quora.com/What-is-the-purpose-of-using-do-while-0-in-macros

Do while(0) is used to make a macro look like a function.  Since we have
deleted the macro we don't need the do while.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1289614

On Fri, 11 Dec 2015 16:02:33 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> > Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
> > @@ -110,7 +98,16 @@ static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr,
> >  	int count = 0;
> >  	int i = 0;
> >  
> > -	DGNC_VERIFY_BOARD(p, bd);
> > +	do {
> > +		if (!p)
> > +			return 0;
> > +
> > +		bd = dev_get_drvdata(p);
> > +		if (!bd || bd->magic != DGNC_BOARD_MAGIC)
> > +			return 0;
> > +		if (bd->state != BOARD_READY)
> > +			return 0;
> > +	} while (0);
> 
> Google about why do while(0) loops are used in macros and then redo
> this.  Mostly the patch isn't bad, but I suspect I'm going to complain
> about how you split up some of the long lines.

Let me just be completely sure that you and I are on the same page here. The macro was used to replace the do-while loop, I replaced all instances of the macro with the the actual loop. Both pieces were originally part of the code, just using macros in place of do-while statements. Do you still want me to change it? Maybe the original author did it for a specific reason.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290123 — Re: [PATCH] staging: dgnc: Update the TODO file

From ae99848ed2c054e3ec031b3014f4727f6ff94ea3 Mon Sep 17 00:00:00 2001
From: Sanidhya Solanki <jpage.lkml@gmail.com>
Date: Fri, 11 Dec 2015 21:12:35 -0500
Subject: [PATCH 2/2] staging: dgnc: Update the TODO file

Patch updates the TODO file. Line regarding checkpatch
changes removed.

Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
---
 drivers/staging/dgnc/TODO | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
index 0e0825b..0bdfd26 100644
--- a/drivers/staging/dgnc/TODO
+++ b/drivers/staging/dgnc/TODO
@@ -1,4 +1,3 @@
-* checkpatch fixes
 * remove unnecessary comments
 * remove unnecessary error messages. Example kzalloc() has its
   own error message. Adding an extra one is useless.
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290125

On Fri, 11 Dec 2015 16:02:33 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote:
> > >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001
> > From: Sanidhya Solanki <jpage.lkml@gmail.com>
> > Date: Fri, 11 Dec 2015 03:08:53 -0500
> > Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes
> 
> 
> Don't include this stuff.
Whenever I remove that part, the "git am" command gives me an error that
it cannot detect patch format and the patch application fails.

Thanks for the macro information. I misunderstood initially and thought you 
wanted me to get rid of the entire code block included in the do-while, 
rather than just replacing the do-while loop with the code. I sent you 
an update patch that does just that and a separate patch that includes 
the TODO file update.

Any more errors in the code regarding parenthesis alignment are a 
checkpatch bug, which you can visually reconfirm.

Also, any more requests by checkpatch to further breakup the remaining
long lines may further degrade readablility due to presence of arrow
pointers.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290145

On Fri, Dec 11, 2015 at 09:24:16PM -0500, Sanidhya Solanki wrote:
> On Fri, 11 Dec 2015 16:02:33 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 
> > On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote:
> > > >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001
> > > From: Sanidhya Solanki <jpage.lkml@gmail.com>
> > > Date: Fri, 11 Dec 2015 03:08:53 -0500
> > > Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes
> > 
> > 
> > Don't include this stuff.
> Whenever I remove that part, the "git am" command gives me an error that
> it cannot detect patch format and the patch application fails.
> 

You first have to email the patch to yourself for git am to work.

Also you need to break the patch up into a patch series that fixes one
type of issue at a time.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290155

On Sat, Dec 12, 2015 at 11:57:45AM +0300, Dan Carpenter wrote:
> On Fri, Dec 11, 2015 at 09:24:16PM -0500, Sanidhya Solanki wrote:
> > On Fri, 11 Dec 2015 16:02:33 +0300
> > Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > 
> > > On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote:
> > > > >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001
> > > > From: Sanidhya Solanki <jpage.lkml@gmail.com>
> > > > Date: Fri, 11 Dec 2015 03:08:53 -0500
> > > > Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes
> > > 
> > > 
> > > Don't include this stuff.
> > Whenever I remove that part, the "git am" command gives me an error that
> > it cannot detect patch format and the patch application fails.
> > 
> 
> You first have to email the patch to yourself for git am to work.

You are not sending using git send-email. That header will be used by
git send-email. Try using that.
If you still want to use claws then remove these header, mail to
yourself and try git am.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290159

Thank you everyone for your concern regarding my email client.

Unfortunately, there is a bug in "git send-email" that leads to the gmail 
SMTP server rejecting certain patches sent by the git command. If I can
replicate and fix the issue for " git am" (which I do apply after emailing
to myself) I will not send the git header anymore. 

This bug is well documented. It presents itself as an error in line 1351/1320
in a gitconfig file. Rest assured you will not see the git header again.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290160

On Sat, Dec 12, 2015 at 01:12:21AM -0500, Sanidhya Solanki wrote:
> Thank you everyone for your concern regarding my email client.
> 
> Unfortunately, there is a bug in "git send-email" that leads to the gmail 
> SMTP server rejecting certain patches sent by the git command.

Is it? I am using git send-email from my beginning, never faced any
problem in sending patch through gmail smtp server. Can you please send
me the patch (offlist), so that i can test with my setup.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290174 — Re: [PATCH 3/3] staging: dgnc: Patch includes the checkpatch fixes

Patch updates the TODO file.

Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
---
 drivers/staging/dgnc/TODO | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
index 0e0825b..0bdfd26 100644
--- a/drivers/staging/dgnc/TODO
+++ b/drivers/staging/dgnc/TODO
@@ -1,4 +1,3 @@
-* checkpatch fixes
 * remove unnecessary comments
 * remove unnecessary error messages. Example kzalloc() has its
   own error message. Adding an extra one is useless.
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290177

Sorry about Patch 1/3 having the header information. The rest should be fine.

I broke up the patches as you requested.

I can also confirm that git am gives me an error if the patch to be applied
does not contain the header information. Specifically, "Patch format detection failed.".
Yes, this is only after I email myself the patch, reset to the cloned git directory,
and then apply the patch. "git apply --check" returns no error in this scenario.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1291597 — Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

On Sat, Dec 12, 2015 at 02:58:50AM -0500, Sanidhya Solanki wrote:
> >From a1635ea5e75cb2f10728ae4ddf3a21567958e98f Mon Sep 17 00:00:00 2001
> From: Sanidhya Solanki <jpage.lkml@gmail.com>
> Date: Sat, 12 Dec 2015 02:20:03 -0500
> Subject: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch
>  fixes
> 
> Patch contains the spacing fixes that checkpatch prompted for,
> as asked by the TODO.
> 
> Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>

Please resend all of these patches properly, without the embedded email
headers so that I have a chance to apply them.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1291830 — Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

Patch updates the TODO file.

Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
---
 drivers/staging/dgnc/TODO | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
index 0e0825b..0bdfd26 100644
--- a/drivers/staging/dgnc/TODO
+++ b/drivers/staging/dgnc/TODO
@@ -1,4 +1,3 @@
-* checkpatch fixes
 * remove unnecessary comments
 * remove unnecessary error messages. Example kzalloc() has its
   own error message. Adding an extra one is useless.
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1291835 — Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

On Mon, Dec 14, 2015 at 07:03:31PM -0500, Sanidhya Solanki wrote:
> Patch updates the TODO file.
> 
> Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
> ---
>  drivers/staging/dgnc/TODO | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
> index 0e0825b..0bdfd26 100644
> --- a/drivers/staging/dgnc/TODO
> +++ b/drivers/staging/dgnc/TODO
> @@ -1,4 +1,3 @@
> -* checkpatch fixes
>  * remove unnecessary comments
>  * remove unnecessary error messages. Example kzalloc() has its
>    own error message. Adding an extra one is useless.
> -- 
> 2.5.0

You sent me 3 patches, all with the same Subject: line, and all of them
incorrect, so I've dropped them all :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1291842 — Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

Can you tell me what was incorrect about them?
I thought you requested the dgnc patches to be resent without the
headers.
There are 3 of them because Dan Carpenter asked my patch to be broken
up so each one does only one thing. I also resent you the skein
subsystem patches, as I did not hear anything from you for almost a
week.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1291847 — Re: [PATCH FIXED 3/3] staging: dgnc: Patch updates the TODO file

Patch updates the TODO file.

Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
---
 drivers/staging/dgnc/TODO | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
index 0e0825b..0bdfd26 100644
--- a/drivers/staging/dgnc/TODO
+++ b/drivers/staging/dgnc/TODO
@@ -1,4 +1,3 @@
-* checkpatch fixes
 * remove unnecessary comments
 * remove unnecessary error messages. Example kzalloc() has its
   own error message. Adding an extra one is useless.
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1291848 — Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

On Mon, Dec 14, 2015 at 07:45:25PM -0500, Sanidhya Solanki wrote:
> Can you tell me what was incorrect about them?

The subjects are all wrong, go look at them...  PATCH twice?  1/3 for
every message? Same string for every message?

> I thought you requested the dgnc patches to be resent without the
> headers.

I did, but that doesn't mean you send incorrect ones :)

> There are 3 of them because Dan Carpenter asked my patch to be broken
> up so each one does only one thing. I also resent you the skein
> subsystem patches, as I did not hear anything from you for almost a
> week.

My queue of pending staging patches is over 1000 right now, they are
burried somewhere in there, be patient.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1291865 — Re: [PATCH FIXED 1/3] staging: dgnc: Patch includes the checkpatch fixes

On Mon, Dec 14, 2015 at 08:22:47PM -0500, Sanidhya Solanki wrote:
> Patch contains the spacing fixes that checkpatch prompted for,
> as asked by the TODO.
> 
> Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>

What is the FIXED doing in the subject?

And the subject is horrid, please make it sane...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1291887 — Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

Why is the "Re:" in the Subject?

Why is "Patch" in the subject"?

The Subject doesn't even make sense.

On Mon, Dec 14, 2015 at 08:58:30PM -0500, Sanidhya Solanki wrote:
> Patch contains the spacing fixes that led to checkpatch.pl warnings.
> 
> Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c    |   4 +-
>  drivers/staging/dgnc/dgnc_driver.h |   8 --
>  drivers/staging/dgnc/dgnc_neo.c    | 235
> ++++++++++++++++++++++++-------------


Patch is line-wrapped and doesn't even apply :(

Please take a day, relax, and fix up all 3 of these and resend them
tomorrow.  There's no rush here.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1291888 — Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

On Tue, Dec 15, 2015 at 7:28 AM, Sanidhya Solanki <jpage.lkml@gmail.com> wrote:
>
> Patch contains the spacing fixes that led to checkpatch.pl warnings.
>
> Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c    |   4 +-
>  drivers/staging/dgnc/dgnc_driver.h |   8 --
>  drivers/staging/dgnc/dgnc_neo.c    | 235
> ++++++++++++++++++++++++-------------
> drivers/staging/dgnc/dgnc_neo.h    |  22 ++--
> drivers/staging/dgnc/dgnc_pci.h    |   1 -
> drivers/staging/dgnc/dgnc_sysfs.c  |  18 ++-
> drivers/staging/dgnc/dgnc_tty.c    |  46 +++++---
> drivers/staging/dgnc/digi.h        |  32 ++--- 8 files changed, 223
> insertions(+), 143 deletions(-)
>

Hi Sanidhya,

Just to help you out since you're struggling some.

Subject line should be something like "Fix checkpatch warnings".
Better yet would be a subject specifying what you fixed to silence
checkpatch warnings. For example, "Fixed comments formatting" or
"Removed unnecessary spaces"

And the commit message should not be vague like "Patch contains the
spacing fixes that led to checkpatch.pl warnings." You should write
what you did to fix the warnings.
For example: Fixed checkpatch warning *write warning here* by
correcting *whatever change you did*

Regards,
Amitoj
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web