Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

From	Amitoj Kaur Chawla <amitoj1606@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes
Date	2015-12-15 07:40 +0100
Message-ID	<qFRrb-lM-3@gated-at.bofh.it> (permalink)
References	(7 earlier) <qFPIK-7DU-27@gated-at.bofh.it> <qFQlr-894-3@gated-at.bofh.it> <qFQlr-894-1@gated-at.bofh.it> <qFQEO-8hk-11@gated-at.bofh.it> <qFQOu-8kE-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 15, 2015 at 7:28 AM, Sanidhya Solanki <jpage.lkml@gmail.com> wrote:
>
> Patch contains the spacing fixes that led to checkpatch.pl warnings.
>
> Signed-off-by: Sanidhya Solanki <jpage.lkml@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c    |   4 +-
>  drivers/staging/dgnc/dgnc_driver.h |   8 --
>  drivers/staging/dgnc/dgnc_neo.c    | 235
> ++++++++++++++++++++++++-------------
> drivers/staging/dgnc/dgnc_neo.h    |  22 ++--
> drivers/staging/dgnc/dgnc_pci.h    |   1 -
> drivers/staging/dgnc/dgnc_sysfs.c  |  18 ++-
> drivers/staging/dgnc/dgnc_tty.c    |  46 +++++---
> drivers/staging/dgnc/digi.h        |  32 ++--- 8 files changed, 223
> insertions(+), 143 deletions(-)
>

Hi Sanidhya,

Just to help you out since you're struggling some.

Subject line should be something like "Fix checkpatch warnings".
Better yet would be a subject specifying what you fixed to silence
checkpatch warnings. For example, "Fixed comments formatting" or
"Removed unnecessary spaces"

And the commit message should not be vague like "Patch contains the
spacing fixes that led to checkpatch.pl warnings." You should write
what you did to fix the warnings.
For example: Fixed checkpatch warning *write warning here* by
correcting *whatever change you did*

Regards,
Amitoj
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-12 07:30 +0100
  Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-12 10:00 +0100
    Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-12 11:10 +0100
      Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-12 11:20 +0100
        Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-12 11:30 +0100
    Re: [PATCH 3/3] staging: dgnc: Patch includes the checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-12 13:10 +0100
    Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-12 13:20 +0100
    Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch  fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-14 22:40 +0100
      Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the  checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-15 05:10 +0100
        Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch  fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 05:40 +0100
          Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the  checkpatch fixes Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-15 05:50 +0100
            Re: [PATCH FIXED 3/3] staging: dgnc: Patch updates the TODO file Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-15 06:30 +0100
            Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch  fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 06:30 +0100
              Re: [PATCH FIXED 1/3] staging: dgnc: Patch includes the checkpatch  fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 06:50 +0100
                Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 07:40 +0100
                Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2015-12-15 07:40 +0100

csiph-web