Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1284606 > unrolled thread
| Started by | Peter Hurley <peter@hurleysoftware.com> |
|---|---|
| First post | 2015-12-05 18:30 +0100 |
| Last post | 2015-12-05 22:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function Peter Hurley <peter@hurleysoftware.com> - 2015-12-05 18:30 +0100
Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-12-05 22:50 +0100
| From | Peter Hurley <peter@hurleysoftware.com> |
|---|---|
| Date | 2015-12-05 18:30 +0100 |
| Subject | Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function |
| Message-ID | <qCoOK-3XY-27@gated-at.bofh.it> |
On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > The startup function is supposed to initialize the UART for receiving. > Hence, don't enable the TX part. Also, protect HW accesses with the port > lock. Reviewed-by: Peter Hurley <peter@hurleysoftware.com> NB: the request_irq() should be _after_ h/w programming, otherwise an interrupt could be triggered and in-progress before the h/w has been setup. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Sören Brinkmann <soren.brinkmann@xilinx.com> |
|---|---|
| Date | 2015-12-05 22:50 +0100 |
| Message-ID | <qCsSl-6q9-3@gated-at.bofh.it> |
| In reply to | #1284606 |
On Sat, 2015-12-05 at 12:21PM -0500, Peter Hurley wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > > The startup function is supposed to initialize the UART for receiving. > > Hence, don't enable the TX part. Also, protect HW accesses with the port > > lock. > > Reviewed-by: Peter Hurley <peter@hurleysoftware.com> > > NB: the request_irq() should be _after_ h/w programming, otherwise an > interrupt could be triggered and in-progress before the h/w has been > setup. Thanks for pointing that out. I'll patch that. Sören -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web