Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function

From	Peter Hurley <peter@hurleysoftware.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function
Date	2015-12-05 18:30 +0100
Message-ID	<qCoOK-3XY-27@gated-at.bofh.it> (permalink)
References	<qxt2F-5Ri-3@gated-at.bofh.it> <qxtcm-6aY-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/21/2015 09:59 PM, Soren Brinkmann wrote:
> The startup function is supposed to initialize the UART for receiving.
> Hence, don't enable the TX part. Also, protect HW accesses with the port
> lock.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

NB: the request_irq() should be _after_ h/w programming, otherwise an
interrupt could be triggered and in-progress before the h/w has been
setup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function Peter Hurley <peter@hurleysoftware.com> - 2015-12-05 18:30 +0100
  Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-12-05 22:50 +0100

csiph-web