Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281097 > unrolled thread
| Started by | Joshua Clayton <stillcompiling@gmail.com> |
|---|---|
| First post | 2015-12-01 19:20 +0100 |
| Last post | 2015-12-01 19:20 +0100 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 3/9] rtc-pcf2123: clean up writes to the rtc chip Joshua Clayton <stillcompiling@gmail.com> - 2015-12-01 19:20 +0100
| From | Joshua Clayton <stillcompiling@gmail.com> |
|---|---|
| Date | 2015-12-01 19:20 +0100 |
| Subject | Re: [PATCH 3/9] rtc-pcf2123: clean up writes to the rtc chip |
| Message-ID | <qAXGW-4Gh-11@gated-at.bofh.it> |
On Tue, 24 Nov 2015 23:16:26 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> On 04/11/2015 at 07:36:34 -0800, Joshua Clayton wrote :
> > +static int pcf2123_write(struct device *dev, u8 *txbuf, size_t
> > size) +{
> > + struct spi_device *spi = to_spi_device(dev);
> > + int ret;
> > +
> > + if (txbuf[0] > PCF2123_REG_MAX)
> > + return -EFAULT;
> > +
>
> Is that test really necessary? From what I understand the driver
> always controls which register is written.
>
In the larger context of the driver, you are correct, there is
no way for an out of range request unless someone were to add new code.
I can remove it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web