Re: [PATCH 3/9] rtc-pcf2123: clean up writes to the rtc chip

From	Joshua Clayton <stillcompiling@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/9] rtc-pcf2123: clean up writes to the rtc chip
Date	2015-12-01 19:20 +0100
Message-ID	<qAXGW-4Gh-11@gated-at.bofh.it> (permalink)
References	<qr8kh-2go-9@gated-at.bofh.it> <qr8kj-2go-49@gated-at.bofh.it> <qyu6m-5EM-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 24 Nov 2015 23:16:26 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> On 04/11/2015 at 07:36:34 -0800, Joshua Clayton wrote :
> > +static int pcf2123_write(struct device *dev, u8 *txbuf, size_t
> > size) +{
> > +	struct spi_device *spi = to_spi_device(dev);
> > +	int ret;
> > +
> > +	if (txbuf[0] > PCF2123_REG_MAX)
> > +		return -EFAULT;
> > +
> 
> Is that test really necessary? From what I understand the driver
> always controls which register is written.
> 

In the larger context of the driver, you are correct, there is 
no way for an out of range request unless someone were to add new code.
I can remove it. 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 3/9] rtc-pcf2123: clean up writes to the rtc chip Joshua Clayton <stillcompiling@gmail.com> - 2015-12-01 19:20 +0100

csiph-web