Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280439 > unrolled thread

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD  controller Wolfram Sang <wsa@the-dreams.de> - 2015-12-01 01:50 +0100

#1280439 — Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

[Multipart message — attachments visible in raw view] — view raw

> > > > The driver disables TX interrupt when it is not needed anymore or
> > > > when TX gets aborted but the above will re-enable all interrupts
> > regardless.
> > > > Is that the intention?
> > > No, i2c controller can trigger next interrupt only after re-enable all interrupt.
> > 
> > If you get an error the function masks all interrupts and jumps to tx_aborted
> > label. With this patch you unmask all interrupts again before exiting the
> > function.
> > 
> 
> I see, how about change if statement to else if?

That sounds to me that a V2 is needed, or? Marking as "Changes
requested"...

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web