Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller
Date	2015-12-01 01:50 +0100
Message-ID	<qAHiN-2re-19@gated-at.bofh.it> (permalink)
References	<qrtf4-7pc-15@gated-at.bofh.it> <qrtf4-7pc-13@gated-at.bofh.it> <qrJWx-1yT-7@gated-at.bofh.it> <qrJWx-1yT-5@gated-at.bofh.it> <qAHiN-2re-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> > > > The driver disables TX interrupt when it is not needed anymore or
> > > > when TX gets aborted but the above will re-enable all interrupts
> > regardless.
> > > > Is that the intention?
> > > No, i2c controller can trigger next interrupt only after re-enable all interrupt.
> > 
> > If you get an error the function masks all interrupts and jumps to tx_aborted
> > label. With this patch you unmask all interrupts again before exiting the
> > function.
> > 
> 
> I see, how about change if statement to else if?

That sounds to me that a V2 is needed, or? Marking as "Changes
requested"...

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD  controller Wolfram Sang <wsa@the-dreams.de> - 2015-12-01 01:50 +0100

csiph-web