Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1225709 > unrolled thread
| Started by | Stephen Warren <swarren@wwwdotorg.org> |
|---|---|
| First post | 2015-09-16 06:20 +0200 |
| Last post | 2015-09-16 07:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux Stephen Warren <swarren@wwwdotorg.org> - 2015-09-16 06:20 +0200
Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux Martin Sperl <kernel@martin.sperl.org> - 2015-09-16 07:30 +0200
| From | Stephen Warren <swarren@wwwdotorg.org> |
|---|---|
| Date | 2015-09-16 06:20 +0200 |
| Subject | Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux |
| Message-ID | <q9cml-1OQ-1@gated-at.bofh.it> |
On 09/04/2015 01:26 AM, Martin Sperl wrote:
>
>> On 26.08.2015, at 03:44, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>
>> On 08/24/2015 02:40 AM, kernel@martin.sperl.org wrote:
>>
>>> +Example:
>>> +
>>> +aux_enable: aux_enable@0x7e215004 {
>>> + compatible = "bcrm,bcm2835-aux";
>>> + reg = <0x7e215004 0x04>;
>>
>> I'd expect that to be <0x7e215000 0x8>;
>
> The reason is that we just handle enable with this driver,
> which just requires access to the 0x7e215004 register.
>
> The 0x7e215000 register (interrupt mask) could be used by a
> cascaded interrupt-controller, but as the spi and uart drivers
> can run with shared interrupts this is not a necessity.
The DT is supposed to describe the HW, not any particular SW's use of
the HW. If the HW block has 2 registers, so must the DT reg property.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Martin Sperl <kernel@martin.sperl.org> |
|---|---|
| Date | 2015-09-16 07:30 +0200 |
| Subject | Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux |
| Message-ID | <q9ds6-3oy-5@gated-at.bofh.it> |
| In reply to | #1225709 |
> On 16.09.2015, at 06:12, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
> On 09/04/2015 01:26 AM, Martin Sperl wrote:
>>
>>> On 26.08.2015, at 03:44, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>
>>> On 08/24/2015 02:40 AM, kernel@martin.sperl.org wrote:
>>>
>>>> +Example:
>>>> +
>>>> +aux_enable: aux_enable@0x7e215004 {
>>>> + compatible = "bcrm,bcm2835-aux";
>>>> + reg = <0x7e215004 0x04>;
>>>
>>> I'd expect that to be <0x7e215000 0x8>;
>>
>> The reason is that we just handle enable with this driver,
>> which just requires access to the 0x7e215004 register.
>>
>> The 0x7e215000 register (interrupt mask) could be used by a
>> cascaded interrupt-controller, but as the spi and uart drivers
>> can run with shared interrupts this is not a necessity.
>
> The DT is supposed to describe the HW, not any particular SW's use of
> the HW. If the HW block has 2 registers, so must the DT reg property.
Please look at V6 of the patch-series, that uses Erics clock-patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web