Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux

From	Stephen Warren <swarren@wwwdotorg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux
Date	2015-09-16 06:20 +0200
Message-ID	<q9cml-1OQ-1@gated-at.bofh.it> (permalink)
References	<q0VC2-2AJ-9@gated-at.bofh.it> <q0VC3-2AJ-27@gated-at.bofh.it> <q1y0F-7VT-1@gated-at.bofh.it> <q4UxJ-51q-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/04/2015 01:26 AM, Martin Sperl wrote:
> 
>> On 26.08.2015, at 03:44, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>
>> On 08/24/2015 02:40 AM, kernel@martin.sperl.org wrote:
>>
>>> +Example:
>>> +
>>> +aux_enable: aux_enable@0x7e215004 {
>>> +	compatible = "bcrm,bcm2835-aux";
>>> +	reg = <0x7e215004 0x04>;
>>
>> I'd expect that to be <0x7e215000 0x8>;
> 
> The reason is that we just handle enable with this driver,
> which just requires access to the 0x7e215004 register.
> 
> The 0x7e215000 register (interrupt mask) could be used by a
> cascaded interrupt-controller, but as the spi and uart drivers
> can run with shared interrupts this is not a necessity.

The DT is supposed to describe the HW, not any particular SW's use of
the HW. If the HW block has 2 registers, so must the DT reg property.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation  for bcm2835-aux Stephen Warren <swarren@wwwdotorg.org> - 2015-09-16 06:20 +0200
  Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux Martin Sperl <kernel@martin.sperl.org> - 2015-09-16 07:30 +0200

csiph-web