Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1224399 > unrolled thread
| Started by | Mark Brown <broonie@kernel.org> |
|---|---|
| First post | 2015-09-14 20:40 +0200 |
| Last post | 2015-09-15 14:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] spi: mediatek: fix wrong error return value on probe Mark Brown <broonie@kernel.org> - 2015-09-14 20:40 +0200
Re: [PATCH] spi: mediatek: fix wrong error return value on probe Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-15 13:50 +0200
Re: [PATCH] spi: mediatek: fix wrong error return value on probe Mark Brown <broonie@kernel.org> - 2015-09-15 14:40 +0200
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-09-14 20:40 +0200 |
| Subject | Re: [PATCH] spi: mediatek: fix wrong error return value on probe |
| Message-ID | <q8GPv-5VR-15@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Fri, Sep 04, 2015 at 12:50:56AM +0200, Javier Martinez Canillas wrote:
> Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error")
> added a new sel_clk but introduced bugs in the error paths since
> the wrong struct clk pointers are passed to PTR_ERR().
This doesn't apply against current code, please check and resend.
[toc] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2015-09-15 13:50 +0200 |
| Message-ID | <q8WUi-3IW-21@gated-at.bofh.it> |
| In reply to | #1224399 |
Hello Mark,
On 09/14/2015 08:39 PM, Mark Brown wrote:
> On Fri, Sep 04, 2015 at 12:50:56AM +0200, Javier Martinez Canillas wrote:
>> Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error")
>> added a new sel_clk but introduced bugs in the error paths since
>> the wrong struct clk pointers are passed to PTR_ERR().
>
> This doesn't apply against current code, please check and resend.
>
Which branch should I use as a baseline then? The patch applies cleanly
on both today's linux-next (next-20150915) and your for-linus branch:
https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/log/?h=for-linus
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-09-15 14:40 +0200 |
| Message-ID | <q8XGH-4Ub-51@gated-at.bofh.it> |
| In reply to | #1225018 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Sep 15, 2015 at 01:49:11PM +0200, Javier Martinez Canillas wrote:
> On 09/14/2015 08:39 PM, Mark Brown wrote:
> > On Fri, Sep 04, 2015 at 12:50:56AM +0200, Javier Martinez Canillas wrote:
> >> Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error")
> >> added a new sel_clk but introduced bugs in the error paths since
> >> the wrong struct clk pointers are passed to PTR_ERR().
> > This doesn't apply against current code, please check and resend.
> Which branch should I use as a baseline then? The patch applies cleanly
> on both today's linux-next (next-20150915) and your for-linus branch:
> https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/log/?h=for-linus
On the relevant fix brach (so mediatek in this case) or my -linus
branch - I don't think there's any development fixes queued for this
driver yet.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web