Re: [PATCH] spi: mediatek: fix wrong error return value on probe

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] spi: mediatek: fix wrong error return value on probe
Date	2015-09-15 14:40 +0200
Message-ID	<q8XGH-4Ub-51@gated-at.bofh.it> (permalink)
References	<q4LE6-ym-3@gated-at.bofh.it> <q8GPv-5VR-15@gated-at.bofh.it> <q8WUi-3IW-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Sep 15, 2015 at 01:49:11PM +0200, Javier Martinez Canillas wrote:
> On 09/14/2015 08:39 PM, Mark Brown wrote:
> > On Fri, Sep 04, 2015 at 12:50:56AM +0200, Javier Martinez Canillas wrote:
> >> Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error")
> >> added a new sel_clk but introduced bugs in the error paths since
> >> the wrong struct clk pointers are passed to PTR_ERR().

> > This doesn't apply against current code, please check and resend.

> Which branch should I use as a baseline then? The patch applies cleanly
> on both today's linux-next (next-20150915) and your for-linus branch:

> https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/log/?h=for-linus

On the relevant fix brach (so mediatek in this case) or my -linus
branch - I don't think there's any development fixes queued for this
driver yet.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] spi: mediatek: fix wrong error return value on probe Mark Brown <broonie@kernel.org> - 2015-09-14 20:40 +0200
  Re: [PATCH] spi: mediatek: fix wrong error return value on probe Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-15 13:50 +0200
    Re: [PATCH] spi: mediatek: fix wrong error return value on probe Mark Brown <broonie@kernel.org> - 2015-09-15 14:40 +0200

csiph-web