Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1220539 > unrolled thread
| Started by | Jiang Liu <jiang.liu@linux.intel.com> |
|---|---|
| First post | 2015-09-08 09:30 +0200 |
| Last post | 2015-09-09 21:10 +0200 |
| Articles | 8 on this page of 28 — 6 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-08 09:30 +0200
Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Arthur Marsh <arthur.marsh@internode.on.net> - 2015-09-08 11:10 +0200
Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-08 11:50 +0200
Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Bjorn Helgaas <bhelgaas@google.com> - 2015-09-08 18:30 +0200
Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-08 19:00 +0200
Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Bjorn Helgaas <bhelgaas@google.com> - 2015-09-09 21:20 +0200
Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-10 11:00 +0200
[Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-14 05:10 +0200
Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal Hannes Reinecke <hare@suse.de> - 2015-09-14 10:30 +0200
Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-14 10:40 +0200
RE: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal "Ballabio, Dario" <dario.ballabio@emc.com> - 2015-09-14 10:40 +0200
Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal Christoph Hellwig <hch@infradead.org> - 2015-09-16 15:50 +0200
Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-17 08:50 +0200
Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal Arthur Marsh <arthur.marsh@internode.on.net> - 2015-09-18 17:10 +0200
[RFT v3] eata: Convert eata driver as normal PCI and platform device drivers Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-22 09:30 +0200
[Bugfix 0/3] Convert eata driver to a normal PCI device driver Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-14 05:10 +0200
[Bugfix 2/3] eata: Implement PCI driver to manage eata PCI devices Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-14 05:10 +0200
Re: [Bugfix 2/3] eata: Implement PCI driver to manage eata PCI devices Hannes Reinecke <hare@suse.de> - 2015-09-14 10:20 +0200
Re: [Bugfix 2/3] eata: Implement PCI driver to manage eata PCI devices Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-14 10:40 +0200
[Bugfix 1/3] eata: Use IDA to manage eata board IDs Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-14 05:10 +0200
Re: [Bugfix 1/3] eata: Use IDA to manage eata board IDs Hannes Reinecke <hare@suse.de> - 2015-09-14 10:10 +0200
Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver Arthur Marsh <arthur.marsh@internode.on.net> - 2015-09-14 18:10 +0200
Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-15 04:40 +0200
Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-16 07:10 +0200
Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver Arthur Marsh <arthur.marsh@internode.on.net> - 2015-09-16 09:40 +0200
Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver Jiang Liu <jiang.liu@linux.intel.com> - 2015-09-16 10:30 +0200
Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver Arthur Marsh <arthur.marsh@internode.on.net> - 2015-09-16 13:40 +0200
Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Arthur Marsh <arthur.marsh@internode.on.net> - 2015-09-09 21:10 +0200
Page 2 of 2 — ← Prev page 1 [2]
| From | Hannes Reinecke <hare@suse.de> |
|---|---|
| Date | 2015-09-14 10:10 +0200 |
| Subject | Re: [Bugfix 1/3] eata: Use IDA to manage eata board IDs |
| Message-ID | <q8wZQ-lk-13@gated-at.bofh.it> |
| In reply to | #1223819 |
On 09/14/2015 05:08 AM, Jiang Liu wrote: > Use IDA to manage eata board IDs, so we could dynamically allocate > and free board IDs later. > > Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> > --- Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Arthur Marsh <arthur.marsh@internode.on.net> |
|---|---|
| Date | 2015-09-14 18:10 +0200 |
| Subject | Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver |
| Message-ID | <q8Eun-2He-37@gated-at.bofh.it> |
| In reply to | #1223815 |
Jiang Liu wrote on 14/09/15 12:38: > Hi Authur, > As suggested by Bjorn, patch 1-2 set implement a PCI device > driver to manage eata PCI devices. And patch 3 tries to support PCI > device hot-removal for eata, but I have no change to test due to > limited knowledge about scsi subsystem and lacking of hardware for > tests. > So you could please help to test patch 1-2? Patch 3 is just > for comments. > Thanks! > Gerry > > Jiang Liu (3): > eata: Use IDA to manage eata board IDs > eata: Implement PCI driver to manage eata PCI devices > eata: Enhance eata driver to support PCI device hot-removal > > drivers/scsi/eata.c | 232 +++++++++++++++++++++++++++------------------------ > 1 file changed, 125 insertions(+), 107 deletions(-) > With patches 1 and 2 applied, I get a successful boot with IRQ mapping: [ 1.147056] EATA0: IRQ 10 mapped to IO-APIC IRQ 17. [ 1.160404] EATA/DMA 2.0x: Copyright (C) 1994-2003 Dario Ballabio. [ 1.160469] EATA config options -> tm:1, lc:y, mq:16, rs:y, et:n, ip:n, ep:n, pp:y. [ 1.160541] EATA0: 2.0C, PCI 0xd890, IRQ 17, BMST, SG 122, MB 64. [ 1.160600] EATA0: wide SCSI support enabled, max_id 16, max_lun 8. [ 1.160658] EATA0: SCSI channel 0 enabled, host target ID 7. [ 1.161207] scsi host0: EATA/DMA 2.0x rev. 8.10.00 but I still get errors when trying to do a kexec reboot, see http://www.users.on.net/~arthur.marsh/20150915547.jpg roughly it reads (after the synchronising SCSI cache reboot messages) and a long period of a dark screen: sd 0:0:6:0: abort, mbox 63. EATA0: abort, mbox 63 is in use. sd 0:0:6:0: reset, enter. EATA0: reset, mbox 63 in reset. EATA0: reset, board reset done, enabling interrupts. EATA0: reset, interrupts disabled, loops 100469. EATA0: reset, mbox 63 locked, DID_RESET, done. EATA0: reset, exit, done. sd 0:0:6:0: qcomm, mbox 0, adapter busy, will start sd 0:0:6:0: abort, mbox 0. EATA0: abort, timeout error. sd 0:0:6:0: reset, enter. EATA0: reset, exit, timeout error. sd 0:0:6:0 Device offlinled - not ready after error recovery sd 0:0:6:0 rejecting I/O to offline device sd 0:0:6:0 rejecting I/O to offline device sd 0:0:6:0 [sda] Synchronize Cache(10) failed: Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK starting new kernel It would be great if this problem could be fixed. Arthur. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jiang Liu <jiang.liu@linux.intel.com> |
|---|---|
| Date | 2015-09-15 04:40 +0200 |
| Subject | Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver |
| Message-ID | <q8Ok2-8ll-9@gated-at.bofh.it> |
| In reply to | #1224284 |
On 2015/9/15 0:01, Arthur Marsh wrote: > > > Jiang Liu wrote on 14/09/15 12:38: >> Hi Authur, >> As suggested by Bjorn, patch 1-2 set implement a PCI device >> driver to manage eata PCI devices. And patch 3 tries to support PCI >> device hot-removal for eata, but I have no change to test due to >> limited knowledge about scsi subsystem and lacking of hardware for >> tests. >> So you could please help to test patch 1-2? Patch 3 is just >> for comments. >> Thanks! >> Gerry >> >> Jiang Liu (3): >> eata: Use IDA to manage eata board IDs >> eata: Implement PCI driver to manage eata PCI devices >> eata: Enhance eata driver to support PCI device hot-removal >> >> drivers/scsi/eata.c | 232 >> +++++++++++++++++++++++++++------------------------ >> 1 file changed, 125 insertions(+), 107 deletions(-) >> > > With patches 1 and 2 applied, I get a successful boot with IRQ mapping: > > [ 1.147056] EATA0: IRQ 10 mapped to IO-APIC IRQ 17. > [ 1.160404] EATA/DMA 2.0x: Copyright (C) 1994-2003 Dario Ballabio. > [ 1.160469] EATA config options -> tm:1, lc:y, mq:16, rs:y, et:n, > ip:n, ep:n, pp:y. > [ 1.160541] EATA0: 2.0C, PCI 0xd890, IRQ 17, BMST, SG 122, MB 64. > [ 1.160600] EATA0: wide SCSI support enabled, max_id 16, max_lun 8. > [ 1.160658] EATA0: SCSI channel 0 enabled, host target ID 7. > [ 1.161207] scsi host0: EATA/DMA 2.0x rev. 8.10.00 > > > but I still get errors when trying to do a kexec reboot, see > http://www.users.on.net/~arthur.marsh/20150915547.jpg > > roughly it reads (after the synchronising SCSI cache reboot messages) > and a long period of a dark screen: > > sd 0:0:6:0: abort, mbox 63. > EATA0: abort, mbox 63 is in use. > sd 0:0:6:0: reset, enter. > EATA0: reset, mbox 63 in reset. > EATA0: reset, board reset done, enabling interrupts. > EATA0: reset, interrupts disabled, loops 100469. > EATA0: reset, mbox 63 locked, DID_RESET, done. > EATA0: reset, exit, done. > sd 0:0:6:0: qcomm, mbox 0, adapter busy, will start > sd 0:0:6:0: abort, mbox 0. > EATA0: abort, timeout error. > sd 0:0:6:0: reset, enter. > EATA0: reset, exit, timeout error. > sd 0:0:6:0 Device offlinled - not ready after error recovery > sd 0:0:6:0 rejecting I/O to offline device > sd 0:0:6:0 rejecting I/O to offline device > sd 0:0:6:0 [sda] Synchronize Cache(10) failed: Result: > hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK > starting new kernel > > It would be great if this problem could be fixed. HI Arthur, Really appreciate your help to test the patches. That's a good sign we have moved forward a bit:) For kexec, it's always challenging to me. So could you please help to provide full dmesg logs with working kernels so I could try to figure out the order among scsi and PCI devices. It may be shutdown order related. Thanks! Gerry > > Arthur. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jiang Liu <jiang.liu@linux.intel.com> |
|---|---|
| Date | 2015-09-16 07:10 +0200 |
| Subject | Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver |
| Message-ID | <q9d8J-31U-3@gated-at.bofh.it> |
| In reply to | #1224605 |
On 2015/9/15 15:19, Arthur Marsh wrote: > > > Jiang Liu wrote on 15/09/15 12:01: > >> HI Arthur, >> Really appreciate your help to test the patches. That's >> a good sign we have moved forward a bit:) >> For kexec, it's always challenging to me. So could you >> please help to provide full dmesg logs with working kernels >> so I could try to figure out the order among scsi and PCI devices. >> It may be shutdown order related. >> Thanks! >> Gerry > > OK, attached is the dmesg output from the 4.2.0 kernel where kexec worked. Hi Arthur, Could you please also help to capture the log messages of kexec, I need to those log messages to figure out the order to shutdown PCI devices and scsi devices during kexec. Thanks! Gerry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Arthur Marsh <arthur.marsh@internode.on.net> |
|---|---|
| Date | 2015-09-16 09:40 +0200 |
| Subject | Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver |
| Message-ID | <q9ftU-6eY-21@gated-at.bofh.it> |
| In reply to | #1225718 |
Jiang Liu wrote on 16/09/15 14:37: > On 2015/9/15 15:19, Arthur Marsh wrote: >> >> >> Jiang Liu wrote on 15/09/15 12:01: >> >>> HI Arthur, >>> Really appreciate your help to test the patches. That's >>> a good sign we have moved forward a bit:) >>> For kexec, it's always challenging to me. So could you >>> please help to provide full dmesg logs with working kernels >>> so I could try to figure out the order among scsi and PCI devices. >>> It may be shutdown order related. >>> Thanks! >>> Gerry >> >> OK, attached is the dmesg output from the 4.2.0 kernel where kexec worked. > Hi Arthur, > Could you please also help to capture the log messages > of kexec, I need to those log messages to figure out the order > to shutdown PCI devices and scsi devices during kexec. > Thanks! > Gerry > How would I capture the log messages of kexec (assuming that there are any, I couldn't see from the manual page entries and haven't seen anything beyond the screen images that I have already sent you)? Regards, Arthur. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jiang Liu <jiang.liu@linux.intel.com> |
|---|---|
| Date | 2015-09-16 10:30 +0200 |
| Subject | Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver |
| Message-ID | <q9ggi-7oR-17@gated-at.bofh.it> |
| In reply to | #1225789 |
On 2015/9/16 15:37, Arthur Marsh wrote: > > > Jiang Liu wrote on 16/09/15 14:37: >> On 2015/9/15 15:19, Arthur Marsh wrote: >>> >>> >>> Jiang Liu wrote on 15/09/15 12:01: >>> >>>> HI Arthur, >>>> Really appreciate your help to test the patches. That's >>>> a good sign we have moved forward a bit:) >>>> For kexec, it's always challenging to me. So could you >>>> please help to provide full dmesg logs with working kernels >>>> so I could try to figure out the order among scsi and PCI devices. >>>> It may be shutdown order related. >>>> Thanks! >>>> Gerry >>> >>> OK, attached is the dmesg output from the 4.2.0 kernel where kexec >>> worked. >> Hi Arthur, >> Could you please also help to capture the log messages >> of kexec, I need to those log messages to figure out the order >> to shutdown PCI devices and scsi devices during kexec. >> Thanks! >> Gerry >> > > How would I capture the log messages of kexec (assuming that there are > any, I couldn't see from the manual page entries and haven't seen > anything beyond the screen images that I have already sent you)? Hi Arthur, It would be great if we could capture the text as in the picture posted by you at: http://www.users.on.net/~arthur.marsh/20150915547.jpg I guess a serial console could help us to capture those log messages. To use serial console, we need to setup serial cable, configure grub and kernel to use serial port as console. Thanks! Gerry > > Regards, > > Arthur. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Arthur Marsh <arthur.marsh@internode.on.net> |
|---|---|
| Date | 2015-09-16 13:40 +0200 |
| Subject | Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver |
| Message-ID | <q9je9-3cq-13@gated-at.bofh.it> |
| In reply to | #1225824 |
Jiang Liu wrote on 16/09/15 17:51: > Hi Arthur, > It would be great if we could capture the text as in the > picture posted by you at: > http://www.users.on.net/~arthur.marsh/20150915547.jpg > I guess a serial console could help us to capture those > log messages. To use serial console, we need to setup serial cable, > configure grub and kernel to use serial port as console. > Thanks! > Gerry > >> >> Regards, >> >> Arthur. > I've already included the text of what appeaered in the image above: sd 0:0:6:0: abort, mbox 63. EATA0: abort, mbox 63 is in use. sd 0:0:6:0: reset, enter. EATA0: reset, mbox 63 in reset. EATA0: reset, board reset done, enabling interrupts. EATA0: reset, interrupts disabled, loops 100469. EATA0: reset, mbox 63 locked, DID_RESET, done. EATA0: reset, exit, done. sd 0:0:6:0: qcomm, mbox 0, adapter busy, will start sd 0:0:6:0: abort, mbox 0. EATA0: abort, timeout error. sd 0:0:6:0: reset, enter. EATA0: reset, exit, timeout error. sd 0:0:6:0 Device offlinled - not ready after error recovery sd 0:0:6:0 rejecting I/O to offline device sd 0:0:6:0 rejecting I/O to offline device sd 0:0:6:0 [sda] Synchronize Cache(10) failed: Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK starting new kernel As mentioned previously this occurred after the normal Synchronizing SCSI cache messages. I don't think that there is anything else that gets sent to the console. Arthur. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Arthur Marsh <arthur.marsh@internode.on.net> |
|---|---|
| Date | 2015-09-09 21:10 +0200 |
| Subject | Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers |
| Message-ID | <q6SUO-3A4-19@gated-at.bofh.it> |
| In reply to | #1220539 |
Jiang Liu wrote on 08/09/15 16:56:
> Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and
> pcibios_free_irq()") changes the way to allocate PCI legacy IRQ
> for PCI devices on x86 platforms. Instead of allocating PCI legacy
> IRQs when pcibios_enable_device() gets called, now pcibios_alloc_irq()
> will be called by pci_device_probe() to allocate PCI legacy IRQs
> when binding PCI drivers to PCI devices.
>
> But some device drivers, such as eata, directly access PCI devices
> without implementing corresponding PCI drivers, so pcibios_alloc_irq()
> won't be called for those PCI devices and wrong IRQ number may be
> used to manage the PCI device.
>
> So detect such a case in pcibios_enable_device() by checking
> pci_dev->driver is NULL and call pcibios_alloc_irq() to allocate PCI
> legacy IRQs.
>
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
> arch/x86/pci/common.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
> index 09d3afc0a181..60b237783582 100644
> --- a/arch/x86/pci/common.c
> +++ b/arch/x86/pci/common.c
> @@ -685,6 +685,16 @@ void pcibios_free_irq(struct pci_dev *dev)
>
> int pcibios_enable_device(struct pci_dev *dev, int mask)
> {
> + /*
> + * By design, pcibios_alloc_irq() will be called by pci_device_probe()
> + * when binding a PCI device to a PCI driver. But some device drivers,
> + * such as eata, directly make use of PCI devices without implementing
> + * PCI device drivers, so pcibios_alloc_irq() won't be called for those
> + * PCI devices.
> + */
> + if (!dev->driver)
> + pcibios_alloc_irq(dev);
> +
> return pci_enable_resources(dev, mask);
> }
>
>
Sorry for the late report but this patch messes up things for kexec -
rebooting is delayed with the error messages as shown in the fuzzy
screen image here:
http://www.users.on.net/~arthur.marsh/20150910541.jpg
(the error messages are similar to what I was seeing on boot-up before
Jiang Liu's patch)
and the SCSI card is not recognised by the kernel after a kexec restart,
and eata fails to load.
Arthur.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web