Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220701 > unrolled thread

[PATCH 0/2] selftests/pstore: add pstore test script

Started byHiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
First post2015-09-08 13:10 +0200
Last post2015-09-09 01:50 +0200
Articles 15 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] selftests/pstore: add pstore test script Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-08 13:10 +0200
    [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-08 13:40 +0200
      Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Mark Salyzyn <salyzyn@android.com> - 2015-09-09 01:30 +0200
        Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-15 04:40 +0200
          Re: [PATCH 1/2] selftests/pstore: add pstore test script for  pre-reboot Mark Salyzyn <salyzyn@android.com> - 2015-09-21 23:10 +0200
      Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Kees Cook <keescook@chromium.org> - 2015-09-09 01:40 +0200
        Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-15 04:40 +0200
          RE: [PATCH 1/2] selftests/pstore: add pstore test script for  pre-reboot 阿口誠司 / AGUCHI，SEIJI   <seiji.aguchi.tr@hitachi.com> - 2015-09-16 14:10 +0200
            Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-17 08:00 +0200
    [PATCH 2/2] selftests/pstore: add pstore test scripts going with  reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-08 13:40 +0200
      Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot Kees Cook <keescook@chromium.org> - 2015-09-09 01:50 +0200
        Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with  reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-15 04:50 +0200
          RE: [PATCH 2/2] selftests/pstore: add pstore test scripts going  with reboot 阿口誠司 / AGUCHI，SEIJI   <seiji.aguchi.tr@hitachi.com> - 2015-09-16 14:20 +0200
            Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with  reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-17 08:00 +0200
    Re: [PATCH 0/2] selftests/pstore: add pstore test script Kees Cook <keescook@chromium.org> - 2015-09-09 01:50 +0200

#1220701 — [PATCH 0/2] selftests/pstore: add pstore test script

FromHiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Date2015-09-08 13:10 +0200
Subject[PATCH 0/2] selftests/pstore: add pstore test script
Message-ID<q6oWK-2qG-21@gated-at.bofh.it>
These scripts include test cases which check pstore behavior. This
is useful to avoid regressions of pstore.

Pstore is used across kernel crash, so these test cases are split
into three parts.

 - pstore_tests: check pstore behavior before crash
 - pstore_post_reboot_tests: check pstore behavior after crash and reboot
 - pstore_crash_test: cause kernel crash and reboot

The pstore_test and the pstore_post_reboot_tests are the actual scripts
for testing pstore and are executed in usual selftest's "run_test" target.
On the other hand, the pstore_crash_test is to cause kernel panic and reboot,
so it is executed in new "run_pstore_crash" target which is specified ad-hoc
by users. In addition, there is a "common_tests" script which includes
utilities and test cases used commonly in these scripts.

When the pstore_crash_test is executed, it creates a file as a reboot flag.
The pstore_post_reboot_tests detects whether the file exists or not. If the
file doesn't exists, the test cases are skipped.

These scripts expect that one pstore backend is registered before the
scripts are executed.
Assumed use case is following.

# cd linux/tools/testing/selftests
# make run_tests -C pstore
make: Entering directory '/home/root/selftests/pstore'
=== Pstore unit tests (pstore_tests)===
Checking pstore backend is registered ... ok
Checking pstore console is registered ... ok
Checking /dev/pmsg0 exists ... ok
Writing TEST_STRING to /dev/pmsg0 ... ok
selftests: pstore_tests [PASS]
=== Pstore unit tests (pstore_post_reboot_tests)===
Checking pstore backend is registered ... ok
pstore_crash_test has not been executed yet. we skip further tests.
selftests: pstore_post_reboot_tests [PASS]
make: Leaving directory '/home/root/selftests/pstore'
# make run_pstore_crash
...
(kernel crash and reboot)
...
# make run_tests -C pstore
make: Entering directory '/home/root/selftests/pstore'
=== Pstore unit tests (pstore_tests)===
Checking pstore backend is registered ... ok
Checking pstore console is registered ... ok
Checking /dev/pmsg0 exists ... ok
Writing TEST_STRING to /dev/pmsg0 ... ok
selftests: pstore_tests [PASS]
=== Pstore unit tests (pstore_post_reboot_tests)===
Checking pstore backend is registered ... ok
Mounting pstore filesystem ... ok
Checking dmesg files exist in pstore filesystem ... ok
        dmesg-ramoops-0
        dmesg-ramoops-1
Checking console files exist in pstore filesystem ... ok
        console-ramoops-0
Checking pmsg files exist in pstore filesystem ... ok
        pmsg-ramoops-0
Checking dmesg files contains oops end marker
        dmesg-ramoops-0 ... ok
        dmesg-ramoops-1 ... ok
Checking console file contains oops end marker ... ok
Checking pmsg file contains TEST_STRING ... ok
Removing all files in pstore filesystem 
        console-ramoops-0 ... ok
        dmesg-ramoops-0 ... ok
        dmesg-ramoops-1 ... ok
        pmsg-ramoops-0 ... ok
selftests: pstore_post_reboot_tests [PASS]
make: Leaving directory '/home/root/selftests/pstore'


We can also see test logs later.

# cat pstore/logs/20150903-111158/pstore_tests.log
...

---

Hiraku Toyooka (2):
      selftests/pstore: add pstore test script for pre-reboot
      selftests/pstore: add pstore test scripts going with reboot


 tools/testing/selftests/Makefile                   |    1 
 tools/testing/selftests/pstore/Makefile            |   15 ++
 tools/testing/selftests/pstore/common_tests        |   46 +++++++
 tools/testing/selftests/pstore/pstore_crash_test   |   27 ++++
 .../selftests/pstore/pstore_post_reboot_tests      |  126 ++++++++++++++++++++
 tools/testing/selftests/pstore/pstore_tests        |   42 +++++++
 6 files changed, 257 insertions(+)
 create mode 100644 tools/testing/selftests/pstore/Makefile
 create mode 100755 tools/testing/selftests/pstore/common_tests
 create mode 100755 tools/testing/selftests/pstore/pstore_crash_test
 create mode 100755 tools/testing/selftests/pstore/pstore_post_reboot_tests
 create mode 100755 tools/testing/selftests/pstore/pstore_tests

--
Hiraku Toyooka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1220714 — [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

FromHiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Date2015-09-08 13:40 +0200
Subject[PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Message-ID<q6ppL-2YE-5@gated-at.bofh.it>
In reply to#1220701
The pstore_tests script includes test cases which check pstore's
behavior before crash (and reboot).

The test cases are currently following.

- Check pstore backend is registered
- Check pstore console is registered
- Check /dev/pmsg0 exists
- Write string to /dev/pmsg0

Example usage is following.

make: Entering directory '/home/root/selftests/pstore'
=== Pstore unit tests (pstore_tests)===
Checking pstore backend is registered ... ok
Checking pstore console is registered ... ok
Checking /dev/pmsg0 exists ... ok
Writing TEST_STRING to /dev/pmsg0 ... ok
selftests: pstore_tests [PASS]
=== Pstore unit tests (pstore_post_reboot_tests)===
Checking pstore backend is registered ... ok
pstore_crash_test has not been executed yet. we skip further tests.
selftests: pstore_post_reboot_tests [PASS]
make: Leaving directory '/home/root/selftests/pstore'

We can also see test logs later.

Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Cc: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Anton Vorontsov <anton@enomsg.org>
Cc: Colin Cross <ccross@android.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Mark Salyzyn <salyzyn@android.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-api@vger.kernel.org
---
 tools/testing/selftests/Makefile            |    1 +
 tools/testing/selftests/pstore/Makefile     |   12 +++++++
 tools/testing/selftests/pstore/common_tests |   45 +++++++++++++++++++++++++++
 tools/testing/selftests/pstore/pstore_tests |   42 +++++++++++++++++++++++++
 4 files changed, 100 insertions(+)
 create mode 100644 tools/testing/selftests/pstore/Makefile
 create mode 100755 tools/testing/selftests/pstore/common_tests
 create mode 100755 tools/testing/selftests/pstore/pstore_tests

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 24ae9e8..b58c72e 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -12,6 +12,7 @@ TARGETS += mount
 TARGETS += mqueue
 TARGETS += net
 TARGETS += powerpc
+TARGETS += pstore
 TARGETS += ptrace
 TARGETS += seccomp
 TARGETS += size
diff --git a/tools/testing/selftests/pstore/Makefile b/tools/testing/selftests/pstore/Makefile
new file mode 100644
index 0000000..40b887d
--- /dev/null
+++ b/tools/testing/selftests/pstore/Makefile
@@ -0,0 +1,12 @@
+# Makefile for pstore selftests.
+# Expects pstore backend is registered.
+
+all:
+
+TEST_PROGS := pstore_tests
+TEST_FILES := common_tests
+
+include ../lib.mk
+
+clean:
+	rm -rf logs/*
diff --git a/tools/testing/selftests/pstore/common_tests b/tools/testing/selftests/pstore/common_tests
new file mode 100755
index 0000000..98611c5
--- /dev/null
+++ b/tools/testing/selftests/pstore/common_tests
@@ -0,0 +1,45 @@
+#!/bin/sh
+
+# common_tests - Shell script commonly used by pstore test scripts
+#
+# Copyright (C) Hitachi Ltd., 2015
+#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
+#
+# Released under the terms of the GPL v2.
+
+# Utilities
+errexit() { # message
+  echo "Error: $1" 1>&2
+  exit 1
+}
+
+absdir() { # file_path
+  (cd `dirname $1`; pwd)
+}
+
+# Parameters
+TOP_DIR=`absdir $0`
+LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`/
+TEST_STRING="Testing pstore"
+
+# Preparing logs
+LOG_FILE=$LOG_DIR/`basename $0`.log
+mkdir -p $LOG_DIR || errexit "Failed to make a log directory: $LOG_DIR"
+date > $LOG_FILE
+prlog() { # messages
+  /bin/echo "$@" | tee -a $LOG_FILE
+}
+prlog "=== Pstore unit tests (`basename $0`)==="
+
+# Starting tests
+rc=0
+
+prlog -n "Checking pstore backend is registered ... "
+be_msg=`dmesg | grep "pstore: Registered [a-zA-Z0-9]\+ as persistent store backend$"`
+if [ $? -eq 0 ]; then
+    backend=`echo ${be_msg} | sed -e 's/^.*Registered\ \([a-zA-z0-9-]\+\)\ as.*$/\1/g'`
+    prlog "ok"
+else
+    prlog "FAIL"
+    exit 1
+fi
diff --git a/tools/testing/selftests/pstore/pstore_tests b/tools/testing/selftests/pstore/pstore_tests
new file mode 100755
index 0000000..cbf613c
--- /dev/null
+++ b/tools/testing/selftests/pstore/pstore_tests
@@ -0,0 +1,42 @@
+#!/bin/sh
+
+# pstore_tests - Check pstore's behavior before crash/reboot
+#
+# Copyright (C) Hitachi Ltd., 2015
+#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
+#
+# Released under the terms of the GPL v2.
+
+. ./common_tests
+
+prlog -n "Checking pstore console is registered ... "
+dmesg | grep -q "console \[pstore"
+if [ $? -eq 0 ]; then
+    prlog "ok"
+else
+    prlog "FAIL"
+fi
+
+prlog -n "Checking /dev/pmsg0 exists ... "
+if [ -e "/dev/pmsg0" ]; then
+    prlog "ok"
+else
+    prlog "FAIL"
+    rc=1
+fi
+
+prlog -n "Writing TEST_STRING to /dev/pmsg0 ... "
+if [ -e "/dev/pmsg0" ]; then
+    echo "${TEST_STRING}" > /dev/pmsg0
+    if [ $? -eq 0 ]; then
+	prlog "ok"
+    else
+	prlog "FAIL"
+	rc=1
+    fi
+else
+    prlog "FAIL"
+    rc=1
+fi
+
+exit $rc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1221141 — Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

FromMark Salyzyn <salyzyn@android.com>
Date2015-09-09 01:30 +0200
SubjectRe: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Message-ID<q6AuR-2ah-1@gated-at.bofh.it>
In reply to#1220714
On 09/08/2015 04:06 AM, Hiraku Toyooka wrote:
> The pstore_tests script includes test cases which check pstore's
> behavior before crash (and reboot).
>
> The test cases are currently following.
>
> - Check pstore backend is registered
> - Check pstore console is registered
> - Check /dev/pmsg0 exists
> - Write string to /dev/pmsg0
>
> . . .
> +TEST_STRING="Testing pstore"
. . .
> +prlog -n "Checking pmsg file contains TEST_STRING ... "
> +grep -q "${TEST_STRING}" pmsg-${backend}-0
Mark this as 'wish to have'

Can TEST_STRING be given an unique value each run, so that on the the 
reboot-comparison run it can be found to be an unique match? Also 
confirm that any previous content (which may be binary) is not present 
after reboot, and that totally new content is present.

Sincerely -- Mark Salyzyn


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1224604 — Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

FromHiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Date2015-09-15 04:40 +0200
SubjectRe: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Message-ID<q8Ok2-8ll-5@gated-at.bofh.it>
In reply to#1221141
Hello Mark,

Thank you for your advise.

 >> +prlog -n "Checking pmsg file contains TEST_STRING ... "
 > Mark this as 'wish to have'

OK. I'll change it to "Checking pmsg file wishes to have TEST_STRING
... ". Should I change other messages in the same way?

 > Can TEST_STRING be given an unique value each run, so that on the the
 > reboot-comparison run it can be found to be an unique match?

Yes. I'll append /proc/sys/kernel/random/uuid content to TEST_STRING.
I'll also change log directory name from date to the uuid.

 > Also confirm that any previous content (which may be binary) is not
 > present after reboot, and that totally new content is present.

OK.
As for pmsg, they are possible by checking if the /sys/fs/pstore/pmsg
content perfectly matches the TEST_STRING which was written to /dev/pmsg
before reboot. (The TEST_STRING can be left to a regular file before
reboot as well as reboot_flag.) Is it OK?

Best regards,
Hiraku Toyooka


-- 
Hiraku Toyooka
Systems Productivity Research Dept. / Linux Technology Center
Center for Technology Innovation - Systems Engineering, Hitachi Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1229735 — Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

FromMark Salyzyn <salyzyn@android.com>
Date2015-09-21 23:10 +0200
SubjectRe: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Message-ID<qbgvw-1pI-3@gated-at.bofh.it>
In reply to#1224604
On 09/14/2015 07:30 PM, Hiraku Toyooka wrote:
> Hello Mark,
>
> Thank you for your advise.
>
> >> +prlog -n "Checking pmsg file contains TEST_STRING ... "
> > Mark this as 'wish to have'
>
> OK. I'll change it to "Checking pmsg file wishes to have TEST_STRING
> ... ". Should I change other messages in the same way?

I was referring to the list of enhancements to the testing (below), not 
the message in the logs ;-}

Sorry for taking so long to respond, got preoccupied ...
>
> > Can TEST_STRING be given an unique value each run, so that on the the
> > reboot-comparison run it can be found to be an unique match?
>
> Yes. I'll append /proc/sys/kernel/random/uuid content to TEST_STRING.
> I'll also change log directory name from date to the uuid.

Cool

>
> > Also confirm that any previous content (which may be binary) is not
> > present after reboot, and that totally new content is present.
>
> OK.
> As for pmsg, they are possible by checking if the /sys/fs/pstore/pmsg
> content perfectly matches the TEST_STRING which was written to /dev/pmsg
> before reboot. (The TEST_STRING can be left to a regular file before
> reboot as well as reboot_flag.) Is it OK?

Perfectly match is an issue, since something else might be using pmsg. 
For instance, one of the applications that uses this interface 
packetizes the messages so they can be picked out from other sources 
that do not comply with the header (count, magic number etc). In this 
case, should that daemon be active, your content would be ignores, but 
your content would also be buried, but can be needled out with grep.

What you should do is grep for your string pattern within some 
acceptable regex, and one should be found and no other, and it should 
match perfectly. This would prevent another daemon's content from 
disrupting your test and causing a false negative.
>
> Best regards,
> Hiraku Toyooka
>
Sincerely -- Mark Salyzyn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1221146 — Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

FromKees Cook <keescook@chromium.org>
Date2015-09-09 01:40 +0200
SubjectRe: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Message-ID<q6AEy-2lr-23@gated-at.bofh.it>
In reply to#1220714
On Tue, Sep 8, 2015 at 4:06 AM, Hiraku Toyooka
<hiraku.toyooka.gu@hitachi.com> wrote:
> The pstore_tests script includes test cases which check pstore's
> behavior before crash (and reboot).
>
> The test cases are currently following.
>
> - Check pstore backend is registered
> - Check pstore console is registered
> - Check /dev/pmsg0 exists
> - Write string to /dev/pmsg0
>
> Example usage is following.
>
> make: Entering directory '/home/root/selftests/pstore'
> === Pstore unit tests (pstore_tests)===
> Checking pstore backend is registered ... ok
> Checking pstore console is registered ... ok
> Checking /dev/pmsg0 exists ... ok
> Writing TEST_STRING to /dev/pmsg0 ... ok
> selftests: pstore_tests [PASS]
> === Pstore unit tests (pstore_post_reboot_tests)===
> Checking pstore backend is registered ... ok
> pstore_crash_test has not been executed yet. we skip further tests.
> selftests: pstore_post_reboot_tests [PASS]
> make: Leaving directory '/home/root/selftests/pstore'
>
> We can also see test logs later.
>
> Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
> Cc: Shuah Khan <shuahkh@osg.samsung.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Anton Vorontsov <anton@enomsg.org>
> Cc: Colin Cross <ccross@android.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Mark Salyzyn <salyzyn@android.com>
> Cc: Seiji Aguchi <seiji.aguchi@hds.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-api@vger.kernel.org
> ---
>  tools/testing/selftests/Makefile            |    1 +
>  tools/testing/selftests/pstore/Makefile     |   12 +++++++
>  tools/testing/selftests/pstore/common_tests |   45 +++++++++++++++++++++++++++
>  tools/testing/selftests/pstore/pstore_tests |   42 +++++++++++++++++++++++++
>  4 files changed, 100 insertions(+)
>  create mode 100644 tools/testing/selftests/pstore/Makefile
>  create mode 100755 tools/testing/selftests/pstore/common_tests
>  create mode 100755 tools/testing/selftests/pstore/pstore_tests
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 24ae9e8..b58c72e 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -12,6 +12,7 @@ TARGETS += mount
>  TARGETS += mqueue
>  TARGETS += net
>  TARGETS += powerpc
> +TARGETS += pstore
>  TARGETS += ptrace
>  TARGETS += seccomp
>  TARGETS += size
> diff --git a/tools/testing/selftests/pstore/Makefile b/tools/testing/selftests/pstore/Makefile
> new file mode 100644
> index 0000000..40b887d
> --- /dev/null
> +++ b/tools/testing/selftests/pstore/Makefile
> @@ -0,0 +1,12 @@
> +# Makefile for pstore selftests.
> +# Expects pstore backend is registered.
> +
> +all:
> +
> +TEST_PROGS := pstore_tests
> +TEST_FILES := common_tests
> +
> +include ../lib.mk
> +
> +clean:
> +       rm -rf logs/*
> diff --git a/tools/testing/selftests/pstore/common_tests b/tools/testing/selftests/pstore/common_tests
> new file mode 100755
> index 0000000..98611c5
> --- /dev/null
> +++ b/tools/testing/selftests/pstore/common_tests
> @@ -0,0 +1,45 @@
> +#!/bin/sh
> +
> +# common_tests - Shell script commonly used by pstore test scripts
> +#
> +# Copyright (C) Hitachi Ltd., 2015
> +#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
> +#
> +# Released under the terms of the GPL v2.
> +
> +# Utilities
> +errexit() { # message
> +  echo "Error: $1" 1>&2
> +  exit 1
> +}
> +
> +absdir() { # file_path
> +  (cd `dirname $1`; pwd)
> +}
> +
> +# Parameters
> +TOP_DIR=`absdir $0`
> +LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`/
> +TEST_STRING="Testing pstore"
> +
> +# Preparing logs
> +LOG_FILE=$LOG_DIR/`basename $0`.log
> +mkdir -p $LOG_DIR || errexit "Failed to make a log directory: $LOG_DIR"
> +date > $LOG_FILE
> +prlog() { # messages
> +  /bin/echo "$@" | tee -a $LOG_FILE
> +}
> +prlog "=== Pstore unit tests (`basename $0`)==="
> +
> +# Starting tests
> +rc=0
> +
> +prlog -n "Checking pstore backend is registered ... "
> +be_msg=`dmesg | grep "pstore: Registered [a-zA-Z0-9]\+ as persistent store backend$"`
> +if [ $? -eq 0 ]; then
> +    backend=`echo ${be_msg} | sed -e 's/^.*Registered\ \([a-zA-z0-9-]\+\)\ as.*$/\1/g'`
> +    prlog "ok"
> +else
> +    prlog "FAIL"
> +    exit 1
> +fi

This seems unstable if the system hasn't booted recently or if stuff
is spamming dmesg. What about examining /sys/module/pstore instead?

> diff --git a/tools/testing/selftests/pstore/pstore_tests b/tools/testing/selftests/pstore/pstore_tests
> new file mode 100755
> index 0000000..cbf613c
> --- /dev/null
> +++ b/tools/testing/selftests/pstore/pstore_tests
> @@ -0,0 +1,42 @@
> +#!/bin/sh
> +
> +# pstore_tests - Check pstore's behavior before crash/reboot
> +#
> +# Copyright (C) Hitachi Ltd., 2015
> +#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
> +#
> +# Released under the terms of the GPL v2.
> +
> +. ./common_tests
> +
> +prlog -n "Checking pstore console is registered ... "
> +dmesg | grep -q "console \[pstore"
> +if [ $? -eq 0 ]; then
> +    prlog "ok"
> +else
> +    prlog "FAIL"
> +fi
> +
> +prlog -n "Checking /dev/pmsg0 exists ... "
> +if [ -e "/dev/pmsg0" ]; then
> +    prlog "ok"
> +else
> +    prlog "FAIL"
> +    rc=1
> +fi
> +
> +prlog -n "Writing TEST_STRING to /dev/pmsg0 ... "
> +if [ -e "/dev/pmsg0" ]; then
> +    echo "${TEST_STRING}" > /dev/pmsg0
> +    if [ $? -eq 0 ]; then
> +       prlog "ok"
> +    else
> +       prlog "FAIL"
> +       rc=1
> +    fi
> +else
> +    prlog "FAIL"
> +    rc=1
> +fi
> +
> +exit $rc
>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1224603 — Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

FromHiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Date2015-09-15 04:40 +0200
SubjectRe: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Message-ID<q8Ok2-8ll-3@gated-at.bofh.it>
In reply to#1221146
Hello, Kees,

Thank you for your advise.

 >> +be_msg=`dmesg | grep "pstore: Registered [a-zA-Z0-9]\+ as 
persistent store backend$"`
...
 > This seems unstable if the system hasn't booted recently or if stuff
 > is spamming dmesg. What about examining /sys/module/pstore instead?

OK, I'll update in that way.

Best regards,
Hiraku Toyooka

Kees Cook wrote:
> On Tue, Sep 8, 2015 at 4:06 AM, Hiraku Toyooka
> <hiraku.toyooka.gu@hitachi.com> wrote:
>> The pstore_tests script includes test cases which check pstore's
>> behavior before crash (and reboot).
>>
>> The test cases are currently following.
>>
>> - Check pstore backend is registered
>> - Check pstore console is registered
>> - Check /dev/pmsg0 exists
>> - Write string to /dev/pmsg0
>>
>> Example usage is following.
>>
>> make: Entering directory '/home/root/selftests/pstore'
>> === Pstore unit tests (pstore_tests)===
>> Checking pstore backend is registered ... ok
>> Checking pstore console is registered ... ok
>> Checking /dev/pmsg0 exists ... ok
>> Writing TEST_STRING to /dev/pmsg0 ... ok
>> selftests: pstore_tests [PASS]
>> === Pstore unit tests (pstore_post_reboot_tests)===
>> Checking pstore backend is registered ... ok
>> pstore_crash_test has not been executed yet. we skip further tests.
>> selftests: pstore_post_reboot_tests [PASS]
>> make: Leaving directory '/home/root/selftests/pstore'
>>
>> We can also see test logs later.
>>
>> Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
>> Cc: Shuah Khan <shuahkh@osg.samsung.com>
>> Cc: Tony Luck <tony.luck@intel.com>
>> Cc: Anton Vorontsov <anton@enomsg.org>
>> Cc: Colin Cross <ccross@android.com>
>> Cc: Kees Cook <keescook@chromium.org>
>> Cc: Mark Salyzyn <salyzyn@android.com>
>> Cc: Seiji Aguchi <seiji.aguchi@hds.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-api@vger.kernel.org
>> ---
>>   tools/testing/selftests/Makefile            |    1 +
>>   tools/testing/selftests/pstore/Makefile     |   12 +++++++
>>   tools/testing/selftests/pstore/common_tests |   45 +++++++++++++++++++++++++++
>>   tools/testing/selftests/pstore/pstore_tests |   42 +++++++++++++++++++++++++
>>   4 files changed, 100 insertions(+)
>>   create mode 100644 tools/testing/selftests/pstore/Makefile
>>   create mode 100755 tools/testing/selftests/pstore/common_tests
>>   create mode 100755 tools/testing/selftests/pstore/pstore_tests
>>
>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>> index 24ae9e8..b58c72e 100644
>> --- a/tools/testing/selftests/Makefile
>> +++ b/tools/testing/selftests/Makefile
>> @@ -12,6 +12,7 @@ TARGETS += mount
>>   TARGETS += mqueue
>>   TARGETS += net
>>   TARGETS += powerpc
>> +TARGETS += pstore
>>   TARGETS += ptrace
>>   TARGETS += seccomp
>>   TARGETS += size
>> diff --git a/tools/testing/selftests/pstore/Makefile b/tools/testing/selftests/pstore/Makefile
>> new file mode 100644
>> index 0000000..40b887d
>> --- /dev/null
>> +++ b/tools/testing/selftests/pstore/Makefile
>> @@ -0,0 +1,12 @@
>> +# Makefile for pstore selftests.
>> +# Expects pstore backend is registered.
>> +
>> +all:
>> +
>> +TEST_PROGS := pstore_tests
>> +TEST_FILES := common_tests
>> +
>> +include ../lib.mk
>> +
>> +clean:
>> +       rm -rf logs/*
>> diff --git a/tools/testing/selftests/pstore/common_tests b/tools/testing/selftests/pstore/common_tests
>> new file mode 100755
>> index 0000000..98611c5
>> --- /dev/null
>> +++ b/tools/testing/selftests/pstore/common_tests
>> @@ -0,0 +1,45 @@
>> +#!/bin/sh
>> +
>> +# common_tests - Shell script commonly used by pstore test scripts
>> +#
>> +# Copyright (C) Hitachi Ltd., 2015
>> +#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
>> +#
>> +# Released under the terms of the GPL v2.
>> +
>> +# Utilities
>> +errexit() { # message
>> +  echo "Error: $1" 1>&2
>> +  exit 1
>> +}
>> +
>> +absdir() { # file_path
>> +  (cd `dirname $1`; pwd)
>> +}
>> +
>> +# Parameters
>> +TOP_DIR=`absdir $0`
>> +LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`/
>> +TEST_STRING="Testing pstore"
>> +
>> +# Preparing logs
>> +LOG_FILE=$LOG_DIR/`basename $0`.log
>> +mkdir -p $LOG_DIR || errexit "Failed to make a log directory: $LOG_DIR"
>> +date > $LOG_FILE
>> +prlog() { # messages
>> +  /bin/echo "$@" | tee -a $LOG_FILE
>> +}
>> +prlog "=== Pstore unit tests (`basename $0`)==="
>> +
>> +# Starting tests
>> +rc=0
>> +
>> +prlog -n "Checking pstore backend is registered ... "
>> +be_msg=`dmesg | grep "pstore: Registered [a-zA-Z0-9]\+ as persistent store backend$"`
>> +if [ $? -eq 0 ]; then
>> +    backend=`echo ${be_msg} | sed -e 's/^.*Registered\ \([a-zA-z0-9-]\+\)\ as.*$/\1/g'`
>> +    prlog "ok"
>> +else
>> +    prlog "FAIL"
>> +    exit 1
>> +fi
>
> This seems unstable if the system hasn't booted recently or if stuff
> is spamming dmesg. What about examining /sys/module/pstore instead?
>
>> diff --git a/tools/testing/selftests/pstore/pstore_tests b/tools/testing/selftests/pstore/pstore_tests
>> new file mode 100755
>> index 0000000..cbf613c
>> --- /dev/null
>> +++ b/tools/testing/selftests/pstore/pstore_tests
>> @@ -0,0 +1,42 @@
>> +#!/bin/sh
>> +
>> +# pstore_tests - Check pstore's behavior before crash/reboot
>> +#
>> +# Copyright (C) Hitachi Ltd., 2015
>> +#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
>> +#
>> +# Released under the terms of the GPL v2.
>> +
>> +. ./common_tests
>> +
>> +prlog -n "Checking pstore console is registered ... "
>> +dmesg | grep -q "console \[pstore"
>> +if [ $? -eq 0 ]; then
>> +    prlog "ok"
>> +else
>> +    prlog "FAIL"
>> +fi
>> +
>> +prlog -n "Checking /dev/pmsg0 exists ... "
>> +if [ -e "/dev/pmsg0" ]; then
>> +    prlog "ok"
>> +else
>> +    prlog "FAIL"
>> +    rc=1
>> +fi
>> +
>> +prlog -n "Writing TEST_STRING to /dev/pmsg0 ... "
>> +if [ -e "/dev/pmsg0" ]; then
>> +    echo "${TEST_STRING}" > /dev/pmsg0
>> +    if [ $? -eq 0 ]; then
>> +       prlog "ok"
>> +    else
>> +       prlog "FAIL"
>> +       rc=1
>> +    fi
>> +else
>> +    prlog "FAIL"
>> +    rc=1
>> +fi
>> +
>> +exit $rc
>>
>
> -Kees
>

-- 
Hiraku Toyooka
Systems Productivity Research Dept. / Linux Technology Center
Center for Technology Innovation - Systems Engineering, Hitachi Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1226036 — RE: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

From阿口誠司 / AGUCHI，SEIJI <seiji.aguchi.tr@hitachi.com>
Date2015-09-16 14:10 +0200
SubjectRE: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Message-ID<q9jHb-3ZG-7@gated-at.bofh.it>
In reply to#1224603
SGksDQoNCj4gPj4gK3BybG9nIC1uICJDaGVja2luZyBwc3RvcmUgYmFja2VuZCBpcyByZWdpc3Rl
cmVkIC4uLiAiDQo+ID4+ICtiZV9tc2c9YGRtZXNnIHwgZ3JlcCAicHN0b3JlOiBSZWdpc3RlcmVk
IFthLXpBLVowLTldXCsgYXMgcGVyc2lzdGVudCBzdG9yZSBiYWNrZW5kJCJgDQo+ID4+ICtpZiBb
ICQ/IC1lcSAwIF07IHRoZW4NCj4gPj4gKyAgICBiYWNrZW5kPWBlY2hvICR7YmVfbXNnfSB8IHNl
ZCAtZSAncy9eLipSZWdpc3RlcmVkXCBcKFthLXpBLXowLTktXVwrXClcIGFzLiokL1wxL2cnYA0K
PiA+PiArICAgIHBybG9nICJvayINCj4gPj4gK2Vsc2UNCj4gPj4gKyAgICBwcmxvZyAiRkFJTCIN
Cj4gPj4gKyAgICBleGl0IDENCg0KSXQgbWF5IGJlIGdvb2QgaWYgeW91IGNhbiBsb2cgICIvc3lz
L21vZHVsZS9wc3RvcmUvcGFyYW1ldGVycy9iYWNrZW5kLyINCm9yIC9wcm9jL2NtZGxpbmUgaW4g
ZmFpbHVyZSBjYXNlLg0KDQpJdCBtYWtlcyBkZWJ1ZyBlYXN5Lg0KDQpTZWlqaQ0KDQo+ID4+ICtm
aSANCg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IOixiuWyoeaLkyAv
IFRveW9va2HvvIxIaXJha3UNCj4gU2VudDogVHVlc2RheSwgU2VwdGVtYmVyIDE1LCAyMDE1IDEx
OjMxIEFNDQo+IFRvOiBLZWVzIENvb2sNCj4gQ2M6IExLTUw7IFRvbnkgTHVjazsgTGludXggQVBJ
OyBBbnRvbiBWb3JvbnRzb3Y7IFNodWFoIEtoYW47IE1hcmsgU2FseXp5bjsgQ29saW4gQ3Jvc3M7
IOmYv+WPo+iqoOWPuCAvIEFHVUNISe+8jFNFSUpJDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8y
XSBzZWxmdGVzdHMvcHN0b3JlOiBhZGQgcHN0b3JlIHRlc3Qgc2NyaXB0IGZvciBwcmUtcmVib290
DQo+IA0KPiBIZWxsbywgS2VlcywNCj4gDQo+IFRoYW5rIHlvdSBmb3IgeW91ciBhZHZpc2UuDQo+
IA0KPiAgPj4gK2JlX21zZz1gZG1lc2cgfCBncmVwICJwc3RvcmU6IFJlZ2lzdGVyZWQgW2EtekEt
WjAtOV1cKyBhcw0KPiBwZXJzaXN0ZW50IHN0b3JlIGJhY2tlbmQkImANCj4gLi4uDQo+ICA+IFRo
aXMgc2VlbXMgdW5zdGFibGUgaWYgdGhlIHN5c3RlbSBoYXNuJ3QgYm9vdGVkIHJlY2VudGx5IG9y
IGlmIHN0dWZmDQo+ICA+IGlzIHNwYW1taW5nIGRtZXNnLiBXaGF0IGFib3V0IGV4YW1pbmluZyAv
c3lzL21vZHVsZS9wc3RvcmUgaW5zdGVhZD8NCj4gDQo+IE9LLCBJJ2xsIHVwZGF0ZSBpbiB0aGF0
IHdheS4NCj4gDQo+IEJlc3QgcmVnYXJkcywNCj4gSGlyYWt1IFRveW9va2ENCj4gDQo+IEtlZXMg
Q29vayB3cm90ZToNCj4gPiBPbiBUdWUsIFNlcCA4LCAyMDE1IGF0IDQ6MDYgQU0sIEhpcmFrdSBU
b3lvb2thDQo+ID4gPGhpcmFrdS50b3lvb2thLmd1QGhpdGFjaGkuY29tPiB3cm90ZToNCj4gPj4g
VGhlIHBzdG9yZV90ZXN0cyBzY3JpcHQgaW5jbHVkZXMgdGVzdCBjYXNlcyB3aGljaCBjaGVjayBw
c3RvcmUncw0KPiA+PiBiZWhhdmlvciBiZWZvcmUgY3Jhc2ggKGFuZCByZWJvb3QpLg0KPiA+Pg0K
PiA+PiBUaGUgdGVzdCBjYXNlcyBhcmUgY3VycmVudGx5IGZvbGxvd2luZy4NCj4gPj4NCj4gPj4g
LSBDaGVjayBwc3RvcmUgYmFja2VuZCBpcyByZWdpc3RlcmVkDQo+ID4+IC0gQ2hlY2sgcHN0b3Jl
IGNvbnNvbGUgaXMgcmVnaXN0ZXJlZA0KPiA+PiAtIENoZWNrIC9kZXYvcG1zZzAgZXhpc3RzDQo+
ID4+IC0gV3JpdGUgc3RyaW5nIHRvIC9kZXYvcG1zZzANCj4gPj4NCj4gPj4gRXhhbXBsZSB1c2Fn
ZSBpcyBmb2xsb3dpbmcuDQo+ID4+DQo+ID4+IG1ha2U6IEVudGVyaW5nIGRpcmVjdG9yeSAnL2hv
bWUvcm9vdC9zZWxmdGVzdHMvcHN0b3JlJw0KPiA+PiA9PT0gUHN0b3JlIHVuaXQgdGVzdHMgKHBz
dG9yZV90ZXN0cyk9PT0NCj4gPj4gQ2hlY2tpbmcgcHN0b3JlIGJhY2tlbmQgaXMgcmVnaXN0ZXJl
ZCAuLi4gb2sNCj4gPj4gQ2hlY2tpbmcgcHN0b3JlIGNvbnNvbGUgaXMgcmVnaXN0ZXJlZCAuLi4g
b2sNCj4gPj4gQ2hlY2tpbmcgL2Rldi9wbXNnMCBleGlzdHMgLi4uIG9rDQo+ID4+IFdyaXRpbmcg
VEVTVF9TVFJJTkcgdG8gL2Rldi9wbXNnMCAuLi4gb2sNCj4gPj4gc2VsZnRlc3RzOiBwc3RvcmVf
dGVzdHMgW1BBU1NdDQo+ID4+ID09PSBQc3RvcmUgdW5pdCB0ZXN0cyAocHN0b3JlX3Bvc3RfcmVi
b290X3Rlc3RzKT09PQ0KPiA+PiBDaGVja2luZyBwc3RvcmUgYmFja2VuZCBpcyByZWdpc3RlcmVk
IC4uLiBvaw0KPiA+PiBwc3RvcmVfY3Jhc2hfdGVzdCBoYXMgbm90IGJlZW4gZXhlY3V0ZWQgeWV0
LiB3ZSBza2lwIGZ1cnRoZXIgdGVzdHMuDQo+ID4+IHNlbGZ0ZXN0czogcHN0b3JlX3Bvc3RfcmVi
b290X3Rlc3RzIFtQQVNTXQ0KPiA+PiBtYWtlOiBMZWF2aW5nIGRpcmVjdG9yeSAnL2hvbWUvcm9v
dC9zZWxmdGVzdHMvcHN0b3JlJw0KPiA+Pg0KPiA+PiBXZSBjYW4gYWxzbyBzZWUgdGVzdCBsb2dz
IGxhdGVyLg0KPiA+Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBIaXJha3UgVG95b29rYSA8aGlyYWt1
LnRveW9va2EuZ3VAaGl0YWNoaS5jb20+DQo+ID4+IENjOiBTaHVhaCBLaGFuIDxzaHVhaGtoQG9z
Zy5zYW1zdW5nLmNvbT4NCj4gPj4gQ2M6IFRvbnkgTHVjayA8dG9ueS5sdWNrQGludGVsLmNvbT4N
Cj4gPj4gQ2M6IEFudG9uIFZvcm9udHNvdiA8YW50b25AZW5vbXNnLm9yZz4NCj4gPj4gQ2M6IENv
bGluIENyb3NzIDxjY3Jvc3NAYW5kcm9pZC5jb20+DQo+ID4+IENjOiBLZWVzIENvb2sgPGtlZXNj
b29rQGNocm9taXVtLm9yZz4NCj4gPj4gQ2M6IE1hcmsgU2FseXp5biA8c2FseXp5bkBhbmRyb2lk
LmNvbT4NCj4gPj4gQ2M6IFNlaWppIEFndWNoaSA8c2VpamkuYWd1Y2hpQGhkcy5jb20+DQo+ID4+
IENjOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnDQo+ID4+IENjOiBsaW51eC1hcGlAdmdl
ci5rZXJuZWwub3JnDQo+ID4+IC0tLQ0KPiA+PiAgIHRvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL01h
a2VmaWxlICAgICAgICAgICAgfCAgICAxICsNCj4gPj4gICB0b29scy90ZXN0aW5nL3NlbGZ0ZXN0
cy9wc3RvcmUvTWFrZWZpbGUgICAgIHwgICAxMiArKysrKysrDQo+ID4+ICAgdG9vbHMvdGVzdGlu
Zy9zZWxmdGVzdHMvcHN0b3JlL2NvbW1vbl90ZXN0cyB8ICAgNDUgKysrKysrKysrKysrKysrKysr
KysrKysrKysrDQo+ID4+ICAgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvcHN0b3JlL3BzdG9yZV90
ZXN0cyB8ICAgNDIgKysrKysrKysrKysrKysrKysrKysrKysrKw0KPiA+PiAgIDQgZmlsZXMgY2hh
bmdlZCwgMTAwIGluc2VydGlvbnMoKykNCj4gPj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgdG9vbHMv
dGVzdGluZy9zZWxmdGVzdHMvcHN0b3JlL01ha2VmaWxlDQo+ID4+ICAgY3JlYXRlIG1vZGUgMTAw
NzU1IHRvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL3BzdG9yZS9jb21tb25fdGVzdHMNCj4gPj4gICBj
cmVhdGUgbW9kZSAxMDA3NTUgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvcHN0b3JlL3BzdG9yZV90
ZXN0cw0KPiA+Pg0KPiA+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvTWFr
ZWZpbGUgYi90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9NYWtlZmlsZQ0KPiA+PiBpbmRleCAyNGFl
OWU4Li5iNThjNzJlIDEwMDY0NA0KPiA+PiAtLS0gYS90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9N
YWtlZmlsZQ0KPiA+PiArKysgYi90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9NYWtlZmlsZQ0KPiA+
PiBAQCAtMTIsNiArMTIsNyBAQCBUQVJHRVRTICs9IG1vdW50DQo+ID4+ICAgVEFSR0VUUyArPSBt
cXVldWUNCj4gPj4gICBUQVJHRVRTICs9IG5ldA0KPiA+PiAgIFRBUkdFVFMgKz0gcG93ZXJwYw0K
PiA+PiArVEFSR0VUUyArPSBwc3RvcmUNCj4gPj4gICBUQVJHRVRTICs9IHB0cmFjZQ0KPiA+PiAg
IFRBUkdFVFMgKz0gc2VjY29tcA0KPiA+PiAgIFRBUkdFVFMgKz0gc2l6ZQ0KPiA+PiBkaWZmIC0t
Z2l0IGEvdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvcHN0b3JlL01ha2VmaWxlIGIvdG9vbHMvdGVz
dGluZy9zZWxmdGVzdHMvcHN0b3JlL01ha2VmaWxlDQo+ID4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0
DQo+ID4+IGluZGV4IDAwMDAwMDAuLjQwYjg4N2QNCj4gPj4gLS0tIC9kZXYvbnVsbA0KPiA+PiAr
KysgYi90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9wc3RvcmUvTWFrZWZpbGUNCj4gPj4gQEAgLTAs
MCArMSwxMiBAQA0KPiA+PiArIyBNYWtlZmlsZSBmb3IgcHN0b3JlIHNlbGZ0ZXN0cy4NCj4gPj4g
KyMgRXhwZWN0cyBwc3RvcmUgYmFja2VuZCBpcyByZWdpc3RlcmVkLg0KPiA+PiArDQo+ID4+ICth
bGw6DQo+ID4+ICsNCj4gPj4gK1RFU1RfUFJPR1MgOj0gcHN0b3JlX3Rlc3RzDQo+ID4+ICtURVNU
X0ZJTEVTIDo9IGNvbW1vbl90ZXN0cw0KPiA+PiArDQo+ID4+ICtpbmNsdWRlIC4uL2xpYi5taw0K
PiA+PiArDQo+ID4+ICtjbGVhbjoNCj4gPj4gKyAgICAgICBybSAtcmYgbG9ncy8qDQo+ID4+IGRp
ZmYgLS1naXQgYS90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9wc3RvcmUvY29tbW9uX3Rlc3RzIGIv
dG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvcHN0b3JlL2NvbW1vbl90ZXN0cw0KPiA+PiBuZXcgZmls
ZSBtb2RlIDEwMDc1NQ0KPiA+PiBpbmRleCAwMDAwMDAwLi45ODYxMWM1DQo+ID4+IC0tLSAvZGV2
L251bGwNCj4gPj4gKysrIGIvdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvcHN0b3JlL2NvbW1vbl90
ZXN0cw0KPiA+PiBAQCAtMCwwICsxLDQ1IEBADQo+ID4+ICsjIS9iaW4vc2gNCj4gPj4gKw0KPiA+
PiArIyBjb21tb25fdGVzdHMgLSBTaGVsbCBzY3JpcHQgY29tbW9ubHkgdXNlZCBieSBwc3RvcmUg
dGVzdCBzY3JpcHRzDQo+ID4+ICsjDQo+ID4+ICsjIENvcHlyaWdodCAoQykgSGl0YWNoaSBMdGQu
LCAyMDE1DQo+ID4+ICsjICBXcml0dGVuIGJ5IEhpcmFrdSBUb3lvb2thIDxoaXJha3UudG95b29r
YS5ndUBoaXRhY2hpLmNvbT4NCj4gPj4gKyMNCj4gPj4gKyMgUmVsZWFzZWQgdW5kZXIgdGhlIHRl
cm1zIG9mIHRoZSBHUEwgdjIuDQo+ID4+ICsNCj4gPj4gKyMgVXRpbGl0aWVzDQo+ID4+ICtlcnJl
eGl0KCkgeyAjIG1lc3NhZ2UNCj4gPj4gKyAgZWNobyAiRXJyb3I6ICQxIiAxPiYyDQo+ID4+ICsg
IGV4aXQgMQ0KPiA+PiArfQ0KPiA+PiArDQo+ID4+ICthYnNkaXIoKSB7ICMgZmlsZV9wYXRoDQo+
ID4+ICsgIChjZCBgZGlybmFtZSAkMWA7IHB3ZCkNCj4gPj4gK30NCj4gPj4gKw0KPiA+PiArIyBQ
YXJhbWV0ZXJzDQo+ID4+ICtUT1BfRElSPWBhYnNkaXIgJDBgDQo+ID4+ICtMT0dfRElSPSRUT1Bf
RElSL2xvZ3MvYGRhdGUgKyVZJW0lZC0lSCVNJVNgLw0KPiA+PiArVEVTVF9TVFJJTkc9IlRlc3Rp
bmcgcHN0b3JlIg0KPiA+PiArDQo+ID4+ICsjIFByZXBhcmluZyBsb2dzDQo+ID4+ICtMT0dfRklM
RT0kTE9HX0RJUi9gYmFzZW5hbWUgJDBgLmxvZw0KPiA+PiArbWtkaXIgLXAgJExPR19ESVIgfHwg
ZXJyZXhpdCAiRmFpbGVkIHRvIG1ha2UgYSBsb2cgZGlyZWN0b3J5OiAkTE9HX0RJUiINCj4gPj4g
K2RhdGUgPiAkTE9HX0ZJTEUNCj4gPj4gK3BybG9nKCkgeyAjIG1lc3NhZ2VzDQo+ID4+ICsgIC9i
aW4vZWNobyAiJEAiIHwgdGVlIC1hICRMT0dfRklMRQ0KPiA+PiArfQ0KPiA+PiArcHJsb2cgIj09
PSBQc3RvcmUgdW5pdCB0ZXN0cyAoYGJhc2VuYW1lICQwYCk9PT0iDQo+ID4+ICsNCj4gPj4gKyMg
U3RhcnRpbmcgdGVzdHMNCj4gPj4gK3JjPTANCj4gPj4gKw0KPiA+PiArcHJsb2cgLW4gIkNoZWNr
aW5nIHBzdG9yZSBiYWNrZW5kIGlzIHJlZ2lzdGVyZWQgLi4uICINCj4gPj4gK2JlX21zZz1gZG1l
c2cgfCBncmVwICJwc3RvcmU6IFJlZ2lzdGVyZWQgW2EtekEtWjAtOV1cKyBhcyBwZXJzaXN0ZW50
IHN0b3JlIGJhY2tlbmQkImANCj4gPj4gK2lmIFsgJD8gLWVxIDAgXTsgdGhlbg0KPiA+PiArICAg
IGJhY2tlbmQ9YGVjaG8gJHtiZV9tc2d9IHwgc2VkIC1lICdzL14uKlJlZ2lzdGVyZWRcIFwoW2Et
ekEtejAtOS1dXCtcKVwgYXMuKiQvXDEvZydgDQo+ID4+ICsgICAgcHJsb2cgIm9rIg0KPiA+PiAr
ZWxzZQ0KPiA+PiArICAgIHBybG9nICJGQUlMIg0KPiA+PiArICAgIGV4aXQgMQ0KPiA+PiArZmkN
Cj4gPg0KPiA+IFRoaXMgc2VlbXMgdW5zdGFibGUgaWYgdGhlIHN5c3RlbSBoYXNuJ3QgYm9vdGVk
IHJlY2VudGx5IG9yIGlmIHN0dWZmDQo+ID4gaXMgc3BhbW1pbmcgZG1lc2cuIFdoYXQgYWJvdXQg
ZXhhbWluaW5nIC9zeXMvbW9kdWxlL3BzdG9yZSBpbnN0ZWFkPw0KPiA+DQo+ID4+IGRpZmYgLS1n
aXQgYS90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9wc3RvcmUvcHN0b3JlX3Rlc3RzIGIvdG9vbHMv
dGVzdGluZy9zZWxmdGVzdHMvcHN0b3JlL3BzdG9yZV90ZXN0cw0KPiA+PiBuZXcgZmlsZSBtb2Rl
IDEwMDc1NQ0KPiA+PiBpbmRleCAwMDAwMDAwLi5jYmY2MTNjDQo+ID4+IC0tLSAvZGV2L251bGwN
Cj4gPj4gKysrIGIvdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvcHN0b3JlL3BzdG9yZV90ZXN0cw0K
PiA+PiBAQCAtMCwwICsxLDQyIEBADQo+ID4+ICsjIS9iaW4vc2gNCj4gPj4gKw0KPiA+PiArIyBw
c3RvcmVfdGVzdHMgLSBDaGVjayBwc3RvcmUncyBiZWhhdmlvciBiZWZvcmUgY3Jhc2gvcmVib290
DQo+ID4+ICsjDQo+ID4+ICsjIENvcHlyaWdodCAoQykgSGl0YWNoaSBMdGQuLCAyMDE1DQo+ID4+
ICsjICBXcml0dGVuIGJ5IEhpcmFrdSBUb3lvb2thIDxoaXJha3UudG95b29rYS5ndUBoaXRhY2hp
LmNvbT4NCj4gPj4gKyMNCj4gPj4gKyMgUmVsZWFzZWQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBH
UEwgdjIuDQo+ID4+ICsNCj4gPj4gKy4gLi9jb21tb25fdGVzdHMNCj4gPj4gKw0KPiA+PiArcHJs
b2cgLW4gIkNoZWNraW5nIHBzdG9yZSBjb25zb2xlIGlzIHJlZ2lzdGVyZWQgLi4uICINCj4gPj4g
K2RtZXNnIHwgZ3JlcCAtcSAiY29uc29sZSBcW3BzdG9yZSINCj4gPj4gK2lmIFsgJD8gLWVxIDAg
XTsgdGhlbg0KPiA+PiArICAgIHBybG9nICJvayINCj4gPj4gK2Vsc2UNCj4gPj4gKyAgICBwcmxv
ZyAiRkFJTCINCj4gPj4gK2ZpDQo+ID4+ICsNCj4gPj4gK3BybG9nIC1uICJDaGVja2luZyAvZGV2
L3Btc2cwIGV4aXN0cyAuLi4gIg0KPiA+PiAraWYgWyAtZSAiL2Rldi9wbXNnMCIgXTsgdGhlbg0K
PiA+PiArICAgIHBybG9nICJvayINCj4gPj4gK2Vsc2UNCj4gPj4gKyAgICBwcmxvZyAiRkFJTCIN
Cj4gPj4gKyAgICByYz0xDQo+ID4+ICtmaQ0KPiA+PiArDQo+ID4+ICtwcmxvZyAtbiAiV3JpdGlu
ZyBURVNUX1NUUklORyB0byAvZGV2L3Btc2cwIC4uLiAiDQo+ID4+ICtpZiBbIC1lICIvZGV2L3Bt
c2cwIiBdOyB0aGVuDQo+ID4+ICsgICAgZWNobyAiJHtURVNUX1NUUklOR30iID4gL2Rldi9wbXNn
MA0KPiA+PiArICAgIGlmIFsgJD8gLWVxIDAgXTsgdGhlbg0KPiA+PiArICAgICAgIHBybG9nICJv
ayINCj4gPj4gKyAgICBlbHNlDQo+ID4+ICsgICAgICAgcHJsb2cgIkZBSUwiDQo+ID4+ICsgICAg
ICAgcmM9MQ0KPiA+PiArICAgIGZpDQo+ID4+ICtlbHNlDQo+ID4+ICsgICAgcHJsb2cgIkZBSUwi
DQo+ID4+ICsgICAgcmM9MQ0KPiA+PiArZmkNCj4gPj4gKw0KPiA+PiArZXhpdCAkcmMNCj4gPj4N
Cj4gPg0KPiA+IC1LZWVzDQo+ID4NCj4gDQo+IC0tDQo+IEhpcmFrdSBUb3lvb2thDQo+IFN5c3Rl
bXMgUHJvZHVjdGl2aXR5IFJlc2VhcmNoIERlcHQuIC8gTGludXggVGVjaG5vbG9neSBDZW50ZXIN
Cj4gQ2VudGVyIGZvciBUZWNobm9sb2d5IElubm92YXRpb24gLSBTeXN0ZW1zIEVuZ2luZWVyaW5n
LCBIaXRhY2hpIEx0ZC4NCg==
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1226684 — Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

FromHiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Date2015-09-17 08:00 +0200
SubjectRe: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
Message-ID<q9AoF-2JQ-7@gated-at.bofh.it>
In reply to#1226036
Hello,

 > It may be good if you can log  "/sys/module/pstore/parameters/backend/"
 > or /proc/cmdline in failure case.
 >
 > It makes debug easy.

OK, I'll have the script log the information in v2.

Best regards,
Hiraku Toyooka

阿口誠司 / AGUCHI，SEIJI wrote:
> Hi,
>
>>>> +prlog -n "Checking pstore backend is registered ... "
>>>> +be_msg=`dmesg | grep "pstore: Registered [a-zA-Z0-9]\+ as persistent store backend$"`
>>>> +if [ $? -eq 0 ]; then
>>>> +    backend=`echo ${be_msg} | sed -e 's/^.*Registered\ \([a-zA-z0-9-]\+\)\ as.*$/\1/g'`
>>>> +    prlog "ok"
>>>> +else
>>>> +    prlog "FAIL"
>>>> +    exit 1
>
> It may be good if you can log  "/sys/module/pstore/parameters/backend/"
> or /proc/cmdline in failure case.
>
> It makes debug easy.
>
> Seiji
>
>>>> +fi
>
>
>> -----Original Message-----
>> From: 豊岡拓 / Toyooka，Hiraku
>> Sent: Tuesday, September 15, 2015 11:31 AM
>> To: Kees Cook
>> Cc: LKML; Tony Luck; Linux API; Anton Vorontsov; Shuah Khan; Mark Salyzyn; Colin Cross; 阿口誠司 / AGUCHI，SEIJI
>> Subject: Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot
>>
>> Hello, Kees,
>>
>> Thank you for your advise.
>>
>>   >> +be_msg=`dmesg | grep "pstore: Registered [a-zA-Z0-9]\+ as
>> persistent store backend$"`
>> ...
>>   > This seems unstable if the system hasn't booted recently or if stuff
>>   > is spamming dmesg. What about examining /sys/module/pstore instead?
>>
>> OK, I'll update in that way.
>>
>> Best regards,
>> Hiraku Toyooka
>>
>> Kees Cook wrote:
>>> On Tue, Sep 8, 2015 at 4:06 AM, Hiraku Toyooka
>>> <hiraku.toyooka.gu@hitachi.com> wrote:
>>>> The pstore_tests script includes test cases which check pstore's
>>>> behavior before crash (and reboot).
>>>>
>>>> The test cases are currently following.
>>>>
>>>> - Check pstore backend is registered
>>>> - Check pstore console is registered
>>>> - Check /dev/pmsg0 exists
>>>> - Write string to /dev/pmsg0
>>>>
>>>> Example usage is following.
>>>>
>>>> make: Entering directory '/home/root/selftests/pstore'
>>>> === Pstore unit tests (pstore_tests)===
>>>> Checking pstore backend is registered ... ok
>>>> Checking pstore console is registered ... ok
>>>> Checking /dev/pmsg0 exists ... ok
>>>> Writing TEST_STRING to /dev/pmsg0 ... ok
>>>> selftests: pstore_tests [PASS]
>>>> === Pstore unit tests (pstore_post_reboot_tests)===
>>>> Checking pstore backend is registered ... ok
>>>> pstore_crash_test has not been executed yet. we skip further tests.
>>>> selftests: pstore_post_reboot_tests [PASS]
>>>> make: Leaving directory '/home/root/selftests/pstore'
>>>>
>>>> We can also see test logs later.
>>>>
>>>> Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
>>>> Cc: Shuah Khan <shuahkh@osg.samsung.com>
>>>> Cc: Tony Luck <tony.luck@intel.com>
>>>> Cc: Anton Vorontsov <anton@enomsg.org>
>>>> Cc: Colin Cross <ccross@android.com>
>>>> Cc: Kees Cook <keescook@chromium.org>
>>>> Cc: Mark Salyzyn <salyzyn@android.com>
>>>> Cc: Seiji Aguchi <seiji.aguchi@hds.com>
>>>> Cc: linux-kernel@vger.kernel.org
>>>> Cc: linux-api@vger.kernel.org
>>>> ---
>>>>    tools/testing/selftests/Makefile            |    1 +
>>>>    tools/testing/selftests/pstore/Makefile     |   12 +++++++
>>>>    tools/testing/selftests/pstore/common_tests |   45 +++++++++++++++++++++++++++
>>>>    tools/testing/selftests/pstore/pstore_tests |   42 +++++++++++++++++++++++++
>>>>    4 files changed, 100 insertions(+)
>>>>    create mode 100644 tools/testing/selftests/pstore/Makefile
>>>>    create mode 100755 tools/testing/selftests/pstore/common_tests
>>>>    create mode 100755 tools/testing/selftests/pstore/pstore_tests
>>>>
>>>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>>>> index 24ae9e8..b58c72e 100644
>>>> --- a/tools/testing/selftests/Makefile
>>>> +++ b/tools/testing/selftests/Makefile
>>>> @@ -12,6 +12,7 @@ TARGETS += mount
>>>>    TARGETS += mqueue
>>>>    TARGETS += net
>>>>    TARGETS += powerpc
>>>> +TARGETS += pstore
>>>>    TARGETS += ptrace
>>>>    TARGETS += seccomp
>>>>    TARGETS += size
>>>> diff --git a/tools/testing/selftests/pstore/Makefile b/tools/testing/selftests/pstore/Makefile
>>>> new file mode 100644
>>>> index 0000000..40b887d
>>>> --- /dev/null
>>>> +++ b/tools/testing/selftests/pstore/Makefile
>>>> @@ -0,0 +1,12 @@
>>>> +# Makefile for pstore selftests.
>>>> +# Expects pstore backend is registered.
>>>> +
>>>> +all:
>>>> +
>>>> +TEST_PROGS := pstore_tests
>>>> +TEST_FILES := common_tests
>>>> +
>>>> +include ../lib.mk
>>>> +
>>>> +clean:
>>>> +       rm -rf logs/*
>>>> diff --git a/tools/testing/selftests/pstore/common_tests b/tools/testing/selftests/pstore/common_tests
>>>> new file mode 100755
>>>> index 0000000..98611c5
>>>> --- /dev/null
>>>> +++ b/tools/testing/selftests/pstore/common_tests
>>>> @@ -0,0 +1,45 @@
>>>> +#!/bin/sh
>>>> +
>>>> +# common_tests - Shell script commonly used by pstore test scripts
>>>> +#
>>>> +# Copyright (C) Hitachi Ltd., 2015
>>>> +#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
>>>> +#
>>>> +# Released under the terms of the GPL v2.
>>>> +
>>>> +# Utilities
>>>> +errexit() { # message
>>>> +  echo "Error: $1" 1>&2
>>>> +  exit 1
>>>> +}
>>>> +
>>>> +absdir() { # file_path
>>>> +  (cd `dirname $1`; pwd)
>>>> +}
>>>> +
>>>> +# Parameters
>>>> +TOP_DIR=`absdir $0`
>>>> +LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`/
>>>> +TEST_STRING="Testing pstore"
>>>> +
>>>> +# Preparing logs
>>>> +LOG_FILE=$LOG_DIR/`basename $0`.log
>>>> +mkdir -p $LOG_DIR || errexit "Failed to make a log directory: $LOG_DIR"
>>>> +date > $LOG_FILE
>>>> +prlog() { # messages
>>>> +  /bin/echo "$@" | tee -a $LOG_FILE
>>>> +}
>>>> +prlog "=== Pstore unit tests (`basename $0`)==="
>>>> +
>>>> +# Starting tests
>>>> +rc=0
>>>> +
>>>> +prlog -n "Checking pstore backend is registered ... "
>>>> +be_msg=`dmesg | grep "pstore: Registered [a-zA-Z0-9]\+ as persistent store backend$"`
>>>> +if [ $? -eq 0 ]; then
>>>> +    backend=`echo ${be_msg} | sed -e 's/^.*Registered\ \([a-zA-z0-9-]\+\)\ as.*$/\1/g'`
>>>> +    prlog "ok"
>>>> +else
>>>> +    prlog "FAIL"
>>>> +    exit 1
>>>> +fi
>>>
>>> This seems unstable if the system hasn't booted recently or if stuff
>>> is spamming dmesg. What about examining /sys/module/pstore instead?
>>>
>>>> diff --git a/tools/testing/selftests/pstore/pstore_tests b/tools/testing/selftests/pstore/pstore_tests
>>>> new file mode 100755
>>>> index 0000000..cbf613c
>>>> --- /dev/null
>>>> +++ b/tools/testing/selftests/pstore/pstore_tests
>>>> @@ -0,0 +1,42 @@
>>>> +#!/bin/sh
>>>> +
>>>> +# pstore_tests - Check pstore's behavior before crash/reboot
>>>> +#
>>>> +# Copyright (C) Hitachi Ltd., 2015
>>>> +#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
>>>> +#
>>>> +# Released under the terms of the GPL v2.
>>>> +
>>>> +. ./common_tests
>>>> +
>>>> +prlog -n "Checking pstore console is registered ... "
>>>> +dmesg | grep -q "console \[pstore"
>>>> +if [ $? -eq 0 ]; then
>>>> +    prlog "ok"
>>>> +else
>>>> +    prlog "FAIL"
>>>> +fi
>>>> +
>>>> +prlog -n "Checking /dev/pmsg0 exists ... "
>>>> +if [ -e "/dev/pmsg0" ]; then
>>>> +    prlog "ok"
>>>> +else
>>>> +    prlog "FAIL"
>>>> +    rc=1
>>>> +fi
>>>> +
>>>> +prlog -n "Writing TEST_STRING to /dev/pmsg0 ... "
>>>> +if [ -e "/dev/pmsg0" ]; then
>>>> +    echo "${TEST_STRING}" > /dev/pmsg0
>>>> +    if [ $? -eq 0 ]; then
>>>> +       prlog "ok"
>>>> +    else
>>>> +       prlog "FAIL"
>>>> +       rc=1
>>>> +    fi
>>>> +else
>>>> +    prlog "FAIL"
>>>> +    rc=1
>>>> +fi
>>>> +
>>>> +exit $rc
>>>>
>>>
>>> -Kees
>>>
>>
>> --
>> Hiraku Toyooka
>> Systems Productivity Research Dept. / Linux Technology Center
>> Center for Technology Innovation - Systems Engineering, Hitachi Ltd.

-- 
Hiraku Toyooka
Systems Productivity Research Dept. / Linux Technology Center
Center for Technology Innovation - Systems Engineering, Hitachi Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1220715 — [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

FromHiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Date2015-09-08 13:40 +0200
Subject[PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot
Message-ID<q6ppM-2YE-19@gated-at.bofh.it>
In reply to#1220701
To test pstore in earnest, we have to cause kernel crash and check
pstore filesystem mouted after reboot.

We add two scripts:
 - pstore_crash_test
     This script to cause crash and reboot easily. It is executed by
     'make run_pstore_crash' in selftests.
 - pstore_post_reboot_tests
     This script includes test cases which check pstore's behavior after
     crash and reboot. It is executed together with pstore_tests by
     'make run_tests [-C pstore]' in selftests.

The test cases in pstore_post_reboot_tests are currently following.

- Check pstore backend is registered
- Mount pstore filesystem
- Check dmesg files exist in pstore filesystem
- Check console file exist in pstore filesystem
- Check pmsg file exist in pstore filesystem
- Check dmesg files contain oops end marker
- Check console file contain oops end marker
- Check pmsg file contain the string written before crash
- Remove all files in pstore filesystem

Example usage is following.

...
(kernel crash and reboot)
...
make: Entering directory '/home/root/selftests/pstore'
=== Pstore unit tests (pstore_tests)===
Checking pstore backend is registered ... ok
Checking pstore console is registered ... ok
Checking /dev/pmsg0 exists ... ok
Writing TEST_STRING to /dev/pmsg0 ... ok
selftests: pstore_tests [PASS]
=== Pstore unit tests (pstore_post_reboot_tests)===
Checking pstore backend is registered ... ok
Mounting pstore filesystem ... ok
Checking dmesg files exist in pstore filesystem ... ok
        dmesg-ramoops-0
        dmesg-ramoops-1
Checking console files exist in pstore filesystem ... ok
        console-ramoops-0
Checking pmsg files exist in pstore filesystem ... ok
        pmsg-ramoops-0
Checking dmesg files contains oops end marker
        dmesg-ramoops-0 ... ok
        dmesg-ramoops-1 ... ok
Checking console file contains oops end marker ... ok
Checking pmsg file contains TEST_STRING ... ok
Removing all files in pstore filesystem
        console-ramoops-0 ... ok
        dmesg-ramoops-0 ... ok
        dmesg-ramoops-1 ... ok
        pmsg-ramoops-0 ... ok
selftests: pstore_post_reboot_tests [PASS]
make: Leaving directory '/home/root/selftests/pstore'

Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Cc: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Anton Vorontsov <anton@enomsg.org>
Cc: Colin Cross <ccross@android.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Mark Salyzyn <salyzyn@android.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-api@vger.kernel.org
---
 tools/testing/selftests/pstore/Makefile            |    7 +
 tools/testing/selftests/pstore/common_tests        |    1 
 tools/testing/selftests/pstore/pstore_crash_test   |   27 ++++
 .../selftests/pstore/pstore_post_reboot_tests      |  126 ++++++++++++++++++++
 4 files changed, 159 insertions(+), 2 deletions(-)
 create mode 100755 tools/testing/selftests/pstore/pstore_crash_test
 create mode 100755 tools/testing/selftests/pstore/pstore_post_reboot_tests

diff --git a/tools/testing/selftests/pstore/Makefile b/tools/testing/selftests/pstore/Makefile
index 40b887d..32c408c 100644
--- a/tools/testing/selftests/pstore/Makefile
+++ b/tools/testing/selftests/pstore/Makefile
@@ -3,10 +3,13 @@
 
 all:
 
-TEST_PROGS := pstore_tests
-TEST_FILES := common_tests
+TEST_PROGS := pstore_tests pstore_post_reboot_tests
+TEST_FILES := common_tests pstore_crash_test
 
 include ../lib.mk
 
+run_crash:
+	@sh pstore_crash_test || echo "pstore_crash_test: [FAIL]"
+
 clean:
 	rm -rf logs/*
diff --git a/tools/testing/selftests/pstore/common_tests b/tools/testing/selftests/pstore/common_tests
index 98611c5..8003760 100755
--- a/tools/testing/selftests/pstore/common_tests
+++ b/tools/testing/selftests/pstore/common_tests
@@ -20,6 +20,7 @@ absdir() { # file_path
 # Parameters
 TOP_DIR=`absdir $0`
 LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`/
+REBOOT_FILE=$TOP_DIR/reboot_flag
 TEST_STRING="Testing pstore"
 
 # Preparing logs
diff --git a/tools/testing/selftests/pstore/pstore_crash_test b/tools/testing/selftests/pstore/pstore_crash_test
new file mode 100755
index 0000000..6d0c422
--- /dev/null
+++ b/tools/testing/selftests/pstore/pstore_crash_test
@@ -0,0 +1,27 @@
+#!/bin/sh
+
+# pstore_crash_test - Pstore test shell script which causes crash and reboot
+#
+# Copyright (C) Hitachi Ltd., 2015
+#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
+#
+# Released under the terms of the GPL v2.
+
+# exit if pstore backend is not registered
+. ./common_tests
+
+prlog "Causing kernel crash ..."
+
+# enable all functions triggered by sysrq
+echo 1 > /proc/sys/kernel/sysrq
+# setting to reboot in 3 seconds after panic
+echo 3 > /proc/sys/kernel/panic
+# setting to cause panic when oops occurs
+echo 1 > /proc/sys/kernel/panic_on_oops
+
+# create a file as reboot flag
+touch $REBOOT_FILE
+sync
+
+# cause crash
+echo c > /proc/sysrq-trigger
diff --git a/tools/testing/selftests/pstore/pstore_post_reboot_tests b/tools/testing/selftests/pstore/pstore_post_reboot_tests
new file mode 100755
index 0000000..0e33366
--- /dev/null
+++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests
@@ -0,0 +1,126 @@
+#!/bin/sh
+
+# pstore_post_reboot_tests - Check pstore's behavior after crash/reboot
+#
+# Copyright (C) Hitachi Ltd., 2015
+#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
+#
+# Released under the terms of the GPL v2.
+
+. ./common_tests
+
+if [ -e $REBOOT_FILE  ]; then
+    rm $REBOOT_FILE
+else
+    prlog "pstore_crash_test has not been executed yet. we skip further tests."
+    exit 0
+fi
+
+prlog -n "Mounting pstore filesystem ... "
+mount_info=`grep pstore /proc/mounts`
+if [ $? -eq 0 ]; then
+    mount_point=`echo ${mount_info} | cut -d' ' -f2 | head -n1`
+    prlog "ok"
+else
+    mount none /sys/fs/pstore -t pstore
+    if [ $? -eq 0 ]; then
+	mount_point=`grep pstore /proc/mounts | cut -d' ' -f2 | head -n1`
+	prlog "ok"
+    else
+	prlog "FAIL"
+	exit 1
+    fi
+fi
+
+cd ${mount_point}
+
+prlog -n "Checking dmesg files exist in pstore filesystem ... "
+if [ -e dmesg-${backend}-0 ]; then
+    prlog "ok"
+    for f in `ls dmesg-${backend}-*`; do
+	prlog -e "\t${f}"
+    done
+else
+    prlog "FAIL"
+    rc=1
+fi
+
+prlog -n "Checking console files exist in pstore filesystem ... "
+if [ -e console-${backend}-0 ]; then
+    prlog "ok"
+    for f in `ls console-${backend}-*`; do
+	prlog -e "\t${f}"
+    done
+else
+    prlog "FAIL"
+    rc=1
+fi
+
+prlog -n "Checking pmsg files exist in pstore filesystem ... "
+if [ -e pmsg-${backend}-0 ]; then
+    prlog "ok"
+    for f in `ls pmsg-${backend}-*`; do
+	prlog -e "\t${f}"
+    done
+else
+    prlog "FAIL"
+    rc=1
+fi
+
+prlog -n "Checking dmesg files contains oops end marker"
+files=`ls dmesg-${backend}-*`
+if [ $? -eq 0 ]; then
+    prlog
+    for f in $files; do
+	prlog -ne "\t${f} ... "
+	grep -q "\---\[ end trace" $f
+	if [ $? -eq 0 ]; then
+	    prlog "ok"
+	else
+	    prlog "FAIL"
+	    rc=1
+	fi
+    done
+else
+    prlog " ... FAIL"
+    rc=1
+fi
+
+prlog -n "Checking console file contains oops end marker ... "
+grep -q "\---\[ end trace" console-${backend}-0
+if [ $? -eq 0 ]; then
+    prlog "ok"
+else
+    prlog "FAIL"
+    rc=1
+fi
+
+prlog -n "Checking pmsg file contains TEST_STRING ... "
+grep -q "${TEST_STRING}" pmsg-${backend}-0
+if [ $? -eq 0 ]; then
+    prlog "ok"
+else
+    prlog "FAIL"
+    rc=1
+fi
+
+prlog -n "Removing all files in pstore filesystem "
+files=`ls *-${backend}-*`
+if [ $? -eq 0 ]; then
+    prlog
+    for f in ${files}; do
+	prlog -ne "\t${f} ... "
+	rm ${f}
+	if [ $? -eq 0 ]; then
+	    prlog "ok"
+	else
+	    prlog "FAIL"
+	    rc=1
+	fi
+    done
+else
+    prlog " ... FAIL"
+    rc=1
+fi
+
+exit $rc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1221149 — Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

FromKees Cook <keescook@chromium.org>
Date2015-09-09 01:50 +0200
SubjectRe: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot
Message-ID<q6AOe-2wV-11@gated-at.bofh.it>
In reply to#1220715
On Tue, Sep 8, 2015 at 4:06 AM, Hiraku Toyooka
<hiraku.toyooka.gu@hitachi.com> wrote:
> To test pstore in earnest, we have to cause kernel crash and check
> pstore filesystem mouted after reboot.
>
> We add two scripts:
>  - pstore_crash_test
>      This script to cause crash and reboot easily. It is executed by
>      'make run_pstore_crash' in selftests.
>  - pstore_post_reboot_tests
>      This script includes test cases which check pstore's behavior after
>      crash and reboot. It is executed together with pstore_tests by
>      'make run_tests [-C pstore]' in selftests.
>
> The test cases in pstore_post_reboot_tests are currently following.
>
> - Check pstore backend is registered
> - Mount pstore filesystem
> - Check dmesg files exist in pstore filesystem
> - Check console file exist in pstore filesystem
> - Check pmsg file exist in pstore filesystem
> - Check dmesg files contain oops end marker
> - Check console file contain oops end marker
> - Check pmsg file contain the string written before crash
> - Remove all files in pstore filesystem
>
> Example usage is following.
>
> ...
> (kernel crash and reboot)
> ...
> make: Entering directory '/home/root/selftests/pstore'
> === Pstore unit tests (pstore_tests)===
> Checking pstore backend is registered ... ok
> Checking pstore console is registered ... ok
> Checking /dev/pmsg0 exists ... ok
> Writing TEST_STRING to /dev/pmsg0 ... ok
> selftests: pstore_tests [PASS]
> === Pstore unit tests (pstore_post_reboot_tests)===
> Checking pstore backend is registered ... ok
> Mounting pstore filesystem ... ok
> Checking dmesg files exist in pstore filesystem ... ok
>         dmesg-ramoops-0
>         dmesg-ramoops-1
> Checking console files exist in pstore filesystem ... ok
>         console-ramoops-0
> Checking pmsg files exist in pstore filesystem ... ok
>         pmsg-ramoops-0
> Checking dmesg files contains oops end marker
>         dmesg-ramoops-0 ... ok
>         dmesg-ramoops-1 ... ok
> Checking console file contains oops end marker ... ok
> Checking pmsg file contains TEST_STRING ... ok
> Removing all files in pstore filesystem
>         console-ramoops-0 ... ok
>         dmesg-ramoops-0 ... ok
>         dmesg-ramoops-1 ... ok
>         pmsg-ramoops-0 ... ok
> selftests: pstore_post_reboot_tests [PASS]
> make: Leaving directory '/home/root/selftests/pstore'
>
> Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
> Cc: Shuah Khan <shuahkh@osg.samsung.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Anton Vorontsov <anton@enomsg.org>
> Cc: Colin Cross <ccross@android.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Mark Salyzyn <salyzyn@android.com>
> Cc: Seiji Aguchi <seiji.aguchi@hds.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-api@vger.kernel.org
> ---
>  tools/testing/selftests/pstore/Makefile            |    7 +
>  tools/testing/selftests/pstore/common_tests        |    1
>  tools/testing/selftests/pstore/pstore_crash_test   |   27 ++++
>  .../selftests/pstore/pstore_post_reboot_tests      |  126 ++++++++++++++++++++
>  4 files changed, 159 insertions(+), 2 deletions(-)
>  create mode 100755 tools/testing/selftests/pstore/pstore_crash_test
>  create mode 100755 tools/testing/selftests/pstore/pstore_post_reboot_tests
>
> diff --git a/tools/testing/selftests/pstore/Makefile b/tools/testing/selftests/pstore/Makefile
> index 40b887d..32c408c 100644
> --- a/tools/testing/selftests/pstore/Makefile
> +++ b/tools/testing/selftests/pstore/Makefile
> @@ -3,10 +3,13 @@
>
>  all:
>
> -TEST_PROGS := pstore_tests
> -TEST_FILES := common_tests
> +TEST_PROGS := pstore_tests pstore_post_reboot_tests
> +TEST_FILES := common_tests pstore_crash_test
>
>  include ../lib.mk
>
> +run_crash:
> +       @sh pstore_crash_test || echo "pstore_crash_test: [FAIL]"

This is probably better written to exit 1 on failure, otherwise it
just _says_ it fails. (Though lots of selftests in the tree already
have this problem, it's best to avoid the pattern for new stuff.)
Maybe something like:

    @sh pstore_crash_test || { echo "pstore_crash_test: [FAIL]"; exit 1; }

> +
>  clean:
>         rm -rf logs/*
> diff --git a/tools/testing/selftests/pstore/common_tests b/tools/testing/selftests/pstore/common_tests
> index 98611c5..8003760 100755
> --- a/tools/testing/selftests/pstore/common_tests
> +++ b/tools/testing/selftests/pstore/common_tests
> @@ -20,6 +20,7 @@ absdir() { # file_path
>  # Parameters
>  TOP_DIR=`absdir $0`
>  LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`/
> +REBOOT_FILE=$TOP_DIR/reboot_flag
>  TEST_STRING="Testing pstore"
>
>  # Preparing logs
> diff --git a/tools/testing/selftests/pstore/pstore_crash_test b/tools/testing/selftests/pstore/pstore_crash_test
> new file mode 100755
> index 0000000..6d0c422
> --- /dev/null
> +++ b/tools/testing/selftests/pstore/pstore_crash_test
> @@ -0,0 +1,27 @@
> +#!/bin/sh
> +
> +# pstore_crash_test - Pstore test shell script which causes crash and reboot
> +#
> +# Copyright (C) Hitachi Ltd., 2015
> +#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
> +#
> +# Released under the terms of the GPL v2.
> +
> +# exit if pstore backend is not registered
> +. ./common_tests
> +
> +prlog "Causing kernel crash ..."
> +
> +# enable all functions triggered by sysrq
> +echo 1 > /proc/sys/kernel/sysrq
> +# setting to reboot in 3 seconds after panic
> +echo 3 > /proc/sys/kernel/panic
> +# setting to cause panic when oops occurs
> +echo 1 > /proc/sys/kernel/panic_on_oops
> +
> +# create a file as reboot flag
> +touch $REBOOT_FILE
> +sync
> +
> +# cause crash
> +echo c > /proc/sysrq-trigger
> diff --git a/tools/testing/selftests/pstore/pstore_post_reboot_tests b/tools/testing/selftests/pstore/pstore_post_reboot_tests
> new file mode 100755
> index 0000000..0e33366
> --- /dev/null
> +++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests
> @@ -0,0 +1,126 @@
> +#!/bin/sh
> +
> +# pstore_post_reboot_tests - Check pstore's behavior after crash/reboot
> +#
> +# Copyright (C) Hitachi Ltd., 2015
> +#  Written by Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
> +#
> +# Released under the terms of the GPL v2.
> +
> +. ./common_tests
> +
> +if [ -e $REBOOT_FILE  ]; then
> +    rm $REBOOT_FILE
> +else
> +    prlog "pstore_crash_test has not been executed yet. we skip further tests."
> +    exit 0
> +fi
> +
> +prlog -n "Mounting pstore filesystem ... "
> +mount_info=`grep pstore /proc/mounts`
> +if [ $? -eq 0 ]; then
> +    mount_point=`echo ${mount_info} | cut -d' ' -f2 | head -n1`
> +    prlog "ok"
> +else
> +    mount none /sys/fs/pstore -t pstore
> +    if [ $? -eq 0 ]; then
> +       mount_point=`grep pstore /proc/mounts | cut -d' ' -f2 | head -n1`
> +       prlog "ok"
> +    else
> +       prlog "FAIL"
> +       exit 1
> +    fi
> +fi
> +
> +cd ${mount_point}
> +
> +prlog -n "Checking dmesg files exist in pstore filesystem ... "
> +if [ -e dmesg-${backend}-0 ]; then
> +    prlog "ok"
> +    for f in `ls dmesg-${backend}-*`; do
> +       prlog -e "\t${f}"
> +    done
> +else
> +    prlog "FAIL"
> +    rc=1
> +fi

This test pattern is repeated a lot. Maybe better to create a helper
function instead? It could make the tests much more readable.

> +
> +prlog -n "Checking console files exist in pstore filesystem ... "
> +if [ -e console-${backend}-0 ]; then
> +    prlog "ok"
> +    for f in `ls console-${backend}-*`; do
> +       prlog -e "\t${f}"
> +    done
> +else
> +    prlog "FAIL"
> +    rc=1
> +fi
> +
> +prlog -n "Checking pmsg files exist in pstore filesystem ... "
> +if [ -e pmsg-${backend}-0 ]; then
> +    prlog "ok"
> +    for f in `ls pmsg-${backend}-*`; do
> +       prlog -e "\t${f}"
> +    done
> +else
> +    prlog "FAIL"
> +    rc=1
> +fi
> +
> +prlog -n "Checking dmesg files contains oops end marker"
> +files=`ls dmesg-${backend}-*`
> +if [ $? -eq 0 ]; then
> +    prlog
> +    for f in $files; do
> +       prlog -ne "\t${f} ... "
> +       grep -q "\---\[ end trace" $f
> +       if [ $? -eq 0 ]; then
> +           prlog "ok"
> +       else
> +           prlog "FAIL"
> +           rc=1
> +       fi
> +    done
> +else
> +    prlog " ... FAIL"
> +    rc=1
> +fi
> +
> +prlog -n "Checking console file contains oops end marker ... "
> +grep -q "\---\[ end trace" console-${backend}-0
> +if [ $? -eq 0 ]; then
> +    prlog "ok"
> +else
> +    prlog "FAIL"
> +    rc=1
> +fi
> +
> +prlog -n "Checking pmsg file contains TEST_STRING ... "
> +grep -q "${TEST_STRING}" pmsg-${backend}-0
> +if [ $? -eq 0 ]; then
> +    prlog "ok"
> +else
> +    prlog "FAIL"
> +    rc=1
> +fi
> +
> +prlog -n "Removing all files in pstore filesystem "
> +files=`ls *-${backend}-*`
> +if [ $? -eq 0 ]; then
> +    prlog
> +    for f in ${files}; do
> +       prlog -ne "\t${f} ... "
> +       rm ${f}
> +       if [ $? -eq 0 ]; then
> +           prlog "ok"
> +       else
> +           prlog "FAIL"
> +           rc=1
> +       fi
> +    done
> +else
> +    prlog " ... FAIL"
> +    rc=1
> +fi
> +
> +exit $rc
>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1224607 — Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

FromHiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Date2015-09-15 04:50 +0200
SubjectRe: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot
Message-ID<q8OtH-4U-3@gated-at.bofh.it>
In reply to#1221149
Hello Kees,

 >> +run_crash:
 >> +       @sh pstore_crash_test || echo "pstore_crash_test: [FAIL]"
 >
 > This is probably better written to exit 1 on failure, otherwise it
 > just _says_ it fails. (Though lots of selftests in the tree already
 > have this problem, it's best to avoid the pattern for new stuff.)
 > Maybe something like:
 >
 >      @sh pstore_crash_test || { echo "pstore_crash_test: [FAIL]"; 
exit 1; }

OK. I'll add the "exit 1".

 >> +prlog -n "Checking dmesg files exist in pstore filesystem ... "
 >> +if [ -e dmesg-${backend}-0 ]; then
 >> +    prlog "ok"
 >> +    for f in `ls dmesg-${backend}-*`; do
 >> +       prlog -e "\t${f}"
 >> +    done
 >> +else
 >> +    prlog "FAIL"
 >> +    rc=1
 >> +fi
 >
 > This test pattern is repeated a lot. Maybe better to create a helper
 > function instead? It could make the tests much more readable.

Yes, I should make a helper function in v2.

Best regards,
Hiraku Toyooka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1226040 — RE: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

From阿口誠司 / AGUCHI，SEIJI <seiji.aguchi.tr@hitachi.com>
Date2015-09-16 14:20 +0200
SubjectRE: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot
Message-ID<q9jQR-4b3-5@gated-at.bofh.it>
In reply to#1224607
DQo+K3BybG9nICJDYXVzaW5nIGtlcm5lbCBjcmFzaCAuLi4iDQo+Kw0KPisjIGVuYWJsZSBhbGwg
ZnVuY3Rpb25zIHRyaWdnZXJlZCBieSBzeXNycQ0KPitlY2hvIDEgPiAvcHJvYy9zeXMva2VybmVs
L3N5c3JxDQo+KyMgc2V0dGluZyB0byByZWJvb3QgaW4gMyBzZWNvbmRzIGFmdGVyIHBhbmljDQo+
K2VjaG8gMyA+IC9wcm9jL3N5cy9rZXJuZWwvcGFuaWMNCj4rIyBzZXR0aW5nIHRvIGNhdXNlIHBh
bmljIHdoZW4gb29wcyBvY2N1cnMNCj4rZWNobyAxID4gL3Byb2Mvc3lzL2tlcm5lbC9wYW5pY19v
bl9vb3BzDQo+Kw0KPisjIGNyZWF0ZSBhIGZpbGUgYXMgcmVib290IGZsYWcNCj4rdG91Y2ggJFJF
Qk9PVF9GSUxFDQo+K3N5bmMNCj4rDQo+KyMgY2F1c2UgY3Jhc2gNCj4rZWNobyBjID4gL3Byb2Mv
c3lzcnEtdHJpZ2dlcg0KDQpEbyB5b3UgbmVlZCB0byBzdG9wIGtkdW1wIHNlcnZpY2UgYmVmb3Jl
IHRoZSBzeXNycT8NCk9yLCBkb2VzIGl0IGNvdmVyIG9vcHMgYW5kIGtkdW1wIGNhc2U/DQoNClNl
aWppDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTog6LGK5bKh5ouTIC8g
VG95b29rYe+8jEhpcmFrdQ0KPiBTZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIgMTUsIDIwMTUgMTE6
NDIgQU0NCj4gVG86IEtlZXMgQ29vaw0KPiBDYzogTEtNTDsgVG9ueSBMdWNrOyBMaW51eCBBUEk7
IEFudG9uIFZvcm9udHNvdjsgU2h1YWggS2hhbjsgTWFyayBTYWx5enluOyBDb2xpbiBDcm9zczsg
6Zi/5Y+j6Kqg5Y+4IC8gQUdVQ0hJ77yMU0VJSkkNCj4gU3ViamVjdDogUmU6IFtQQVRDSCAyLzJd
IHNlbGZ0ZXN0cy9wc3RvcmU6IGFkZCBwc3RvcmUgdGVzdCBzY3JpcHRzIGdvaW5nIHdpdGggcmVi
b290DQo+IA0KPiBIZWxsbyBLZWVzLA0KPiANCj4gID4+ICtydW5fY3Jhc2g6DQo+ICA+PiArICAg
ICAgIEBzaCBwc3RvcmVfY3Jhc2hfdGVzdCB8fCBlY2hvICJwc3RvcmVfY3Jhc2hfdGVzdDogW0ZB
SUxdIg0KPiAgPg0KPiAgPiBUaGlzIGlzIHByb2JhYmx5IGJldHRlciB3cml0dGVuIHRvIGV4aXQg
MSBvbiBmYWlsdXJlLCBvdGhlcndpc2UgaXQNCj4gID4ganVzdCBfc2F5c18gaXQgZmFpbHMuIChU
aG91Z2ggbG90cyBvZiBzZWxmdGVzdHMgaW4gdGhlIHRyZWUgYWxyZWFkeQ0KPiAgPiBoYXZlIHRo
aXMgcHJvYmxlbSwgaXQncyBiZXN0IHRvIGF2b2lkIHRoZSBwYXR0ZXJuIGZvciBuZXcgc3R1ZmYu
KQ0KPiAgPiBNYXliZSBzb21ldGhpbmcgbGlrZToNCj4gID4NCj4gID4gICAgICBAc2ggcHN0b3Jl
X2NyYXNoX3Rlc3QgfHwgeyBlY2hvICJwc3RvcmVfY3Jhc2hfdGVzdDogW0ZBSUxdIjsNCj4gZXhp
dCAxOyB9DQo+IA0KPiBPSy4gSSdsbCBhZGQgdGhlICJleGl0IDEiLg0KPiANCj4gID4+ICtwcmxv
ZyAtbiAiQ2hlY2tpbmcgZG1lc2cgZmlsZXMgZXhpc3QgaW4gcHN0b3JlIGZpbGVzeXN0ZW0gLi4u
ICINCj4gID4+ICtpZiBbIC1lIGRtZXNnLSR7YmFja2VuZH0tMCBdOyB0aGVuDQo+ICA+PiArICAg
IHBybG9nICJvayINCj4gID4+ICsgICAgZm9yIGYgaW4gYGxzIGRtZXNnLSR7YmFja2VuZH0tKmA7
IGRvDQo+ICA+PiArICAgICAgIHBybG9nIC1lICJcdCR7Zn0iDQo+ICA+PiArICAgIGRvbmUNCj4g
ID4+ICtlbHNlDQo+ICA+PiArICAgIHBybG9nICJGQUlMIg0KPiAgPj4gKyAgICByYz0xDQo+ICA+
PiArZmkNCj4gID4NCj4gID4gVGhpcyB0ZXN0IHBhdHRlcm4gaXMgcmVwZWF0ZWQgYSBsb3QuIE1h
eWJlIGJldHRlciB0byBjcmVhdGUgYSBoZWxwZXINCj4gID4gZnVuY3Rpb24gaW5zdGVhZD8gSXQg
Y291bGQgbWFrZSB0aGUgdGVzdHMgbXVjaCBtb3JlIHJlYWRhYmxlLg0KPiANCj4gWWVzLCBJIHNo
b3VsZCBtYWtlIGEgaGVscGVyIGZ1bmN0aW9uIGluIHYyLg0KPiANCj4gQmVzdCByZWdhcmRzLA0K
PiBIaXJha3UgVG95b29rYQ0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1226683 — Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

FromHiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Date2015-09-17 08:00 +0200
SubjectRe: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot
Message-ID<q9AoF-2JQ-5@gated-at.bofh.it>
In reply to#1226040
Hello,

 >> +prlog "Causing kernel crash ..."
 >> +
 >> +# enable all functions triggered by sysrq
 >> +echo 1 > /proc/sys/kernel/sysrq
 >> +# setting to reboot in 3 seconds after panic
 >> +echo 3 > /proc/sys/kernel/panic
 >> +# setting to cause panic when oops occurs
 >> +echo 1 > /proc/sys/kernel/panic_on_oops
 >> +
 >> +# create a file as reboot flag
 >> +touch $REBOOT_FILE
 >> +sync
 >> +
 >> +# cause crash
 >> +echo c > /proc/sysrq-trigger
 >
 > Do you need to stop kdump service before the sysrq?

Yes, I should check /sys/kernel/kexec_crash_loaded. If the value is
1, this script should try to unload kexec kernel.

 > Or, does it cover oops and kdump case?

No, not yet. I think we should support oops case at first.

Best regards,
Hiraku Toyooka

阿口誠司 / AGUCHI，SEIJI wrote:
>
>> +prlog "Causing kernel crash ..."
>> +
>> +# enable all functions triggered by sysrq
>> +echo 1 > /proc/sys/kernel/sysrq
>> +# setting to reboot in 3 seconds after panic
>> +echo 3 > /proc/sys/kernel/panic
>> +# setting to cause panic when oops occurs
>> +echo 1 > /proc/sys/kernel/panic_on_oops
>> +
>> +# create a file as reboot flag
>> +touch $REBOOT_FILE
>> +sync
>> +
>> +# cause crash
>> +echo c > /proc/sysrq-trigger
>
> Do you need to stop kdump service before the sysrq?
> Or, does it cover oops and kdump case?
>
> Seiji
>
>> -----Original Message-----
>> From: 豊岡拓 / Toyooka，Hiraku
>> Sent: Tuesday, September 15, 2015 11:42 AM
>> To: Kees Cook
>> Cc: LKML; Tony Luck; Linux API; Anton Vorontsov; Shuah Khan; Mark Salyzyn; Colin Cross; 阿口誠司 / AGUCHI，SEIJI
>> Subject: Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot
>>
>> Hello Kees,
>>
>>   >> +run_crash:
>>   >> +       @sh pstore_crash_test || echo "pstore_crash_test: [FAIL]"
>>   >
>>   > This is probably better written to exit 1 on failure, otherwise it
>>   > just _says_ it fails. (Though lots of selftests in the tree already
>>   > have this problem, it's best to avoid the pattern for new stuff.)
>>   > Maybe something like:
>>   >
>>   >      @sh pstore_crash_test || { echo "pstore_crash_test: [FAIL]";
>> exit 1; }
>>
>> OK. I'll add the "exit 1".
>>
>>   >> +prlog -n "Checking dmesg files exist in pstore filesystem ... "
>>   >> +if [ -e dmesg-${backend}-0 ]; then
>>   >> +    prlog "ok"
>>   >> +    for f in `ls dmesg-${backend}-*`; do
>>   >> +       prlog -e "\t${f}"
>>   >> +    done
>>   >> +else
>>   >> +    prlog "FAIL"
>>   >> +    rc=1
>>   >> +fi
>>   >
>>   > This test pattern is repeated a lot. Maybe better to create a helper
>>   > function instead? It could make the tests much more readable.
>>
>> Yes, I should make a helper function in v2.
>>
>> Best regards,
>> Hiraku Toyooka

-- 
Hiraku Toyooka
Systems Productivity Research Dept. / Linux Technology Center
Center for Technology Innovation - Systems Engineering, Hitachi Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1221148

FromKees Cook <keescook@chromium.org>
Date2015-09-09 01:50 +0200
Message-ID<q6AOd-2wV-5@gated-at.bofh.it>
In reply to#1220701
On Tue, Sep 8, 2015 at 4:06 AM, Hiraku Toyooka
<hiraku.toyooka.gu@hitachi.com> wrote:
> These scripts include test cases which check pstore behavior. This
> is useful to avoid regressions of pstore.
>
> Pstore is used across kernel crash, so these test cases are split
> into three parts.
>
>  - pstore_tests: check pstore behavior before crash
>  - pstore_post_reboot_tests: check pstore behavior after crash and reboot
>  - pstore_crash_test: cause kernel crash and reboot
>
> The pstore_test and the pstore_post_reboot_tests are the actual scripts
> for testing pstore and are executed in usual selftest's "run_test" target.
> On the other hand, the pstore_crash_test is to cause kernel panic and reboot,
> so it is executed in new "run_pstore_crash" target which is specified ad-hoc
> by users. In addition, there is a "common_tests" script which includes
> utilities and test cases used commonly in these scripts.
>
> When the pstore_crash_test is executed, it creates a file as a reboot flag.
> The pstore_post_reboot_tests detects whether the file exists or not. If the
> file doesn't exists, the test cases are skipped.
>
> These scripts expect that one pstore backend is registered before the
> scripts are executed.
> Assumed use case is following.
>
> # cd linux/tools/testing/selftests
> # make run_tests -C pstore
> make: Entering directory '/home/root/selftests/pstore'
> === Pstore unit tests (pstore_tests)===
> Checking pstore backend is registered ... ok
> Checking pstore console is registered ... ok
> Checking /dev/pmsg0 exists ... ok
> Writing TEST_STRING to /dev/pmsg0 ... ok
> selftests: pstore_tests [PASS]
> === Pstore unit tests (pstore_post_reboot_tests)===
> Checking pstore backend is registered ... ok
> pstore_crash_test has not been executed yet. we skip further tests.
> selftests: pstore_post_reboot_tests [PASS]
> make: Leaving directory '/home/root/selftests/pstore'
> # make run_pstore_crash
> ...
> (kernel crash and reboot)
> ...
> # make run_tests -C pstore
> make: Entering directory '/home/root/selftests/pstore'
> === Pstore unit tests (pstore_tests)===
> Checking pstore backend is registered ... ok
> Checking pstore console is registered ... ok
> Checking /dev/pmsg0 exists ... ok
> Writing TEST_STRING to /dev/pmsg0 ... ok
> selftests: pstore_tests [PASS]
> === Pstore unit tests (pstore_post_reboot_tests)===
> Checking pstore backend is registered ... ok
> Mounting pstore filesystem ... ok
> Checking dmesg files exist in pstore filesystem ... ok
>         dmesg-ramoops-0
>         dmesg-ramoops-1
> Checking console files exist in pstore filesystem ... ok
>         console-ramoops-0
> Checking pmsg files exist in pstore filesystem ... ok
>         pmsg-ramoops-0
> Checking dmesg files contains oops end marker
>         dmesg-ramoops-0 ... ok
>         dmesg-ramoops-1 ... ok
> Checking console file contains oops end marker ... ok
> Checking pmsg file contains TEST_STRING ... ok
> Removing all files in pstore filesystem
>         console-ramoops-0 ... ok
>         dmesg-ramoops-0 ... ok
>         dmesg-ramoops-1 ... ok
>         pmsg-ramoops-0 ... ok
> selftests: pstore_post_reboot_tests [PASS]
> make: Leaving directory '/home/root/selftests/pstore'
>
>
> We can also see test logs later.
>
> # cat pstore/logs/20150903-111158/pstore_tests.log
> ...

Thanks for working on this! Pstore does need some selftests, so this
is greatly appreciated. :) I sent some improvement ideas in separate
emails.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web