Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1224604

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

Show all headers | View raw

Hello Mark,

Thank you for your advise.

 >> +prlog -n "Checking pmsg file contains TEST_STRING ... "
 > Mark this as 'wish to have'

OK. I'll change it to "Checking pmsg file wishes to have TEST_STRING
... ". Should I change other messages in the same way?

 > Can TEST_STRING be given an unique value each run, so that on the the
 > reboot-comparison run it can be found to be an unique match?

Yes. I'll append /proc/sys/kernel/random/uuid content to TEST_STRING.
I'll also change log directory name from date to the uuid.

 > Also confirm that any previous content (which may be binary) is not
 > present after reboot, and that totally new content is present.

OK.
As for pmsg, they are possible by checking if the /sys/fs/pstore/pmsg
content perfectly matches the TEST_STRING which was written to /dev/pmsg
before reboot. (The TEST_STRING can be left to a regular file before
reboot as well as reboot_flag.) Is it OK?

Best regards,
Hiraku Toyooka


-- 
Hiraku Toyooka
Systems Productivity Research Dept. / Linux Technology Center
Center for Technology Innovation - Systems Engineering, Hitachi Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] selftests/pstore: add pstore test script Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-08 13:10 +0200
  [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-08 13:40 +0200
    Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Mark Salyzyn <salyzyn@android.com> - 2015-09-09 01:30 +0200
      Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-15 04:40 +0200
        Re: [PATCH 1/2] selftests/pstore: add pstore test script for  pre-reboot Mark Salyzyn <salyzyn@android.com> - 2015-09-21 23:10 +0200
    Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Kees Cook <keescook@chromium.org> - 2015-09-09 01:40 +0200
      Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-15 04:40 +0200
        RE: [PATCH 1/2] selftests/pstore: add pstore test script for  pre-reboot 阿口誠司 / AGUCHI，SEIJI   <seiji.aguchi.tr@hitachi.com> - 2015-09-16 14:10 +0200
          Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-17 08:00 +0200
  [PATCH 2/2] selftests/pstore: add pstore test scripts going with  reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-08 13:40 +0200
    Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot Kees Cook <keescook@chromium.org> - 2015-09-09 01:50 +0200
      Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with  reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-15 04:50 +0200
        RE: [PATCH 2/2] selftests/pstore: add pstore test scripts going  with reboot 阿口誠司 / AGUCHI，SEIJI   <seiji.aguchi.tr@hitachi.com> - 2015-09-16 14:20 +0200
          Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with  reboot Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> - 2015-09-17 08:00 +0200
  Re: [PATCH 0/2] selftests/pstore: add pstore test script Kees Cook <keescook@chromium.org> - 2015-09-09 01:50 +0200

csiph-web