Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1222736 > unrolled thread
| Started by | Mark Brown <broonie@kernel.org> |
|---|---|
| First post | 2015-09-11 14:00 +0200 |
| Last post | 2015-09-11 14:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 Mark Brown <broonie@kernel.org> - 2015-09-11 14:00 +0200
Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-11 14:40 +0200
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-09-11 14:00 +0200 |
| Subject | Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 |
| Message-ID | <q7v9M-Eq-5@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Sun, Sep 06, 2015 at 09:13:28AM +0800, Shawn Lin wrote:
> @@ -460,7 +463,6 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> i2s->playback_dma_data.addr = res->start + I2S_TXDR;
> i2s->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> i2s->playback_dma_data.maxburst = 4;
> -
> i2s->capture_dma_data.addr = res->start + I2S_RXDR;
> i2s->capture_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> i2s->capture_dma_data.maxburst = 4;
This random whitespace change shouldn't be in here.
> @@ -489,6 +491,18 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> goto err_pcm_register;
> }
>
> + dma_quirk = snd_dmaengine_pcm_get_quirks(&pdev->dev);
> + if (dma_quirk == ROCKCHIP_I2S_BROKEN_BURST_LEN) {
> + /*
I'd expect this to be a switch statement given the way this is written.
[toc] | [next] | [standalone]
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2015-09-11 14:40 +0200 |
| Message-ID | <q7vMu-1Di-9@gated-at.bofh.it> |
| In reply to | #1222736 |
在 2015/9/11 19:53, Mark Brown 写道:
> On Sun, Sep 06, 2015 at 09:13:28AM +0800, Shawn Lin wrote:
>
>> @@ -460,7 +463,6 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>> i2s->playback_dma_data.addr = res->start + I2S_TXDR;
>> i2s->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
>> i2s->playback_dma_data.maxburst = 4;
>> -
>> i2s->capture_dma_data.addr = res->start + I2S_RXDR;
>> i2s->capture_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
>> i2s->capture_dma_data.maxburst = 4;
>
> This random whitespace change shouldn't be in here.
yes, sorry for this bit.
>
>> @@ -489,6 +491,18 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>> goto err_pcm_register;
>> }
>>
>> + dma_quirk = snd_dmaengine_pcm_get_quirks(&pdev->dev);
>> + if (dma_quirk == ROCKCHIP_I2S_BROKEN_BURST_LEN) {
>> + /*
>
> I'd expect this to be a switch statement given the way this is written.
Ahh.. agreed, but we don't expect more quriks for this driver. ：）)))
Will be done for the next version.
Thanks.
>
--
Best Regards
Shawn Lin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web