Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1
Date	2015-09-11 14:00 +0200
Message-ID	<q7v9M-Eq-5@gated-at.bofh.it> (permalink)
References	<q5wMF-Cb-3@gated-at.bofh.it> <q5wMG-Cb-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, Sep 06, 2015 at 09:13:28AM +0800, Shawn Lin wrote:

> @@ -460,7 +463,6 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>  	i2s->playback_dma_data.addr = res->start + I2S_TXDR;
>  	i2s->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
>  	i2s->playback_dma_data.maxburst = 4;
> -
>  	i2s->capture_dma_data.addr = res->start + I2S_RXDR;
>  	i2s->capture_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
>  	i2s->capture_dma_data.maxburst = 4;

This random whitespace change shouldn't be in here.

> @@ -489,6 +491,18 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>  		goto err_pcm_register;
>  	}
>  
> +	dma_quirk = snd_dmaengine_pcm_get_quirks(&pdev->dev);
> +	if (dma_quirk == ROCKCHIP_I2S_BROKEN_BURST_LEN) {
> +		/*

I'd expect this to be a switch statement given the way this is written.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 Mark Brown <broonie@kernel.org> - 2015-09-11 14:00 +0200
  Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-11 14:40 +0200

csiph-web