Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221334 > unrolled thread

[PATCH 0/5] Add eeprom to the Olimex series of boards

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/5] Add eeprom to the Olimex series of boards Olliver Schinagl <o.schinagl@ultimaker.com> - 2015-09-09 11:30 +0200
    [PATCH 3/5] dts: sunxi: add eeprom to A20 OLinuXino Lime board Olliver Schinagl <o.schinagl@ultimaker.com> - 2015-09-09 11:30 +0200
    Re: [PATCH 0/5] Add eeprom to the Olimex series of boards Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-09 16:10 +0200
      Re: [PATCH 0/5] Add eeprom to the Olimex series of boards Olliver Schinagl <o.schinagl@ultimaker.com> - 2015-09-09 16:30 +0200

#1221334 — [PATCH 0/5] Add eeprom to the Olimex series of boards

Some of the olimex series of boards feature a permanently connected eeprom on
i2c-1. This patch series adds them on all the boards that have them according
to the spec-sheets.

I explicitly added my personal --Tested-by to boards I actually tested. There
are two boards, that according to the sheets have them as well and physically
inspecting the boards shows them clearly, I did not actually test them on
those the boards that are missing the --Tested-by. So while it generally
should be safe to merge those patches as well, if someone with those boards
could add a --Tested-by that'd be great.

Additionally, it brings the eeprom on the OLinuXino a10s in line with the rest
and now follows the binding documentation.

Olliver Schinagl (5):
  dts: sunxi: add eeprom to A10 OLinuXino Lime board
  dts: sunxi: correct vendor prefix on OLinuXino a10s micro
  dts: sunxi: add eeprom to A20 OLinuXino Lime board
  dts: sunxi: add eeprom to A20 OLinuXino Lime2 board
  dts: sunxi: add eeprom to A20 OLinuXino micro board

 arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts   | 12 ++++++++++++
 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts |  2 +-
 arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts   | 12 ++++++++++++
 arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts  |  6 ++++++
 arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts  |  6 ++++++
 5 files changed, 37 insertions(+), 1 deletion(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1221335 — [PATCH 3/5] dts: sunxi: add eeprom to A20 OLinuXino Lime board

From: Olliver Schinagl <oliver@schinagl.nl>

The Olimex A20 OLinuXino Lime features an eeprom that is always on the
board. This patch adds it to the dts.

--Tested-by: Olliver Schinagl <oliver@schinagl.nl>
--Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
---
 arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts
index 769726d..6710d25 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts
@@ -117,6 +117,18 @@
 	};
 };
 
+&i2c1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c1_pins_a>;
+	status = "okay";
+
+	eeprom: eeprom@50 {
+		compatible = "atmel,24c16";
+		reg = <0x50>;
+		pagesize = <16>;
+	};
+};
+
 &mmc0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1221486

[Multipart message — attachments visible in raw view] — view raw

On Wed, Sep 09, 2015 at 11:25:10AM +0200, Olliver Schinagl wrote:
> Some of the olimex series of boards feature a permanently connected eeprom on
> i2c-1. This patch series adds them on all the boards that have them according
> to the spec-sheets.
> 
> I explicitly added my personal --Tested-by to boards I actually tested.

Testing your changes is the strict minimum before testing your
patches. Just like running checkpatch on them, which you clearly
failed to do, otherwise you would have seen that this is not the right
syntax. Drop the tested-by, fix your SoB.

> There are two boards, that according to the sheets have them as well
> and physically inspecting the boards shows them clearly, I did not
> actually test them on those the boards that are missing the
> --Tested-by.

Then don't send those patches.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1221495

On 09-09-15 16:05, Maxime Ripard wrote:
> On Wed, Sep 09, 2015 at 11:25:10AM +0200, Olliver Schinagl wrote:
>> Some of the olimex series of boards feature a permanently connected eeprom on
>> i2c-1. This patch series adds them on all the boards that have them according
>> to the spec-sheets.
>>
>> I explicitly added my personal --Tested-by to boards I actually tested.
> Testing your changes is the strict minimum before testing your
> patches. Just like running checkpatch on them, which you clearly
> failed to do, otherwise you would have seen that this is not the right
> syntax. Drop the tested-by, fix your SoB.
Actually, I did run check-patch and it complained about the format, but 
it was the same as when outputted with a git -s. I obviously missed 
something there! So I double check that. I will resubmit without a 
tested-by for the boards I did test it on.
>
>> There are two boards, that according to the sheets have them as well
>> and physically inspecting the boards shows them clearly, I did not
>> actually test them on those the boards that are missing the
>> --Tested-by.
> Then don't send those patches.
I put them out there so someone could pick up on that with the least 
amount of effort. I will drop them
>
> Maxime
>

-- 
Met vriendelijke groeten, Kind regards, 与亲切的问候

Olliver Schinagl
Research & Development
Ultimaker B.V.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web