Re: [PATCH 0/5] Add eeprom to the Olimex series of boards

From	Olliver Schinagl <o.schinagl@ultimaker.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/5] Add eeprom to the Olimex series of boards
Date	2015-09-09 16:30 +0200
Message-ID	<q6OxP-5FK-11@gated-at.bofh.it> (permalink)
References	<q6JRv-7mz-5@gated-at.bofh.it> <q6Oeu-5iY-25@gated-at.bofh.it>
Organization	Ultimaker B.V.

Show all headers | View raw


On 09-09-15 16:05, Maxime Ripard wrote:
> On Wed, Sep 09, 2015 at 11:25:10AM +0200, Olliver Schinagl wrote:
>> Some of the olimex series of boards feature a permanently connected eeprom on
>> i2c-1. This patch series adds them on all the boards that have them according
>> to the spec-sheets.
>>
>> I explicitly added my personal --Tested-by to boards I actually tested.
> Testing your changes is the strict minimum before testing your
> patches. Just like running checkpatch on them, which you clearly
> failed to do, otherwise you would have seen that this is not the right
> syntax. Drop the tested-by, fix your SoB.
Actually, I did run check-patch and it complained about the format, but 
it was the same as when outputted with a git -s. I obviously missed 
something there! So I double check that. I will resubmit without a 
tested-by for the boards I did test it on.
>
>> There are two boards, that according to the sheets have them as well
>> and physically inspecting the boards shows them clearly, I did not
>> actually test them on those the boards that are missing the
>> --Tested-by.
> Then don't send those patches.
I put them out there so someone could pick up on that with the least 
amount of effort. I will drop them
>
> Maxime
>

-- 
Met vriendelijke groeten, Kind regards, 与亲切的问候

Olliver Schinagl
Research & Development
Ultimaker B.V.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Add eeprom to the Olimex series of boards Olliver Schinagl <o.schinagl@ultimaker.com> - 2015-09-09 11:30 +0200
  [PATCH 3/5] dts: sunxi: add eeprom to A20 OLinuXino Lime board Olliver Schinagl <o.schinagl@ultimaker.com> - 2015-09-09 11:30 +0200
  Re: [PATCH 0/5] Add eeprom to the Olimex series of boards Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-09 16:10 +0200
    Re: [PATCH 0/5] Add eeprom to the Olimex series of boards Olliver Schinagl <o.schinagl@ultimaker.com> - 2015-09-09 16:30 +0200

csiph-web