Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219695 > unrolled thread

Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a  static_branch Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-06 06:10 +0200
    Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a  static_branch Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2015-09-07 06:20 +0200
      Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a  static_branch Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-07 07:30 +0200

#1219695 — Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch

Hi Srikar,
On 8/12/15 12:24 AM, Srikar Dronamraju wrote:
> Variable sched_numa_balancing toggles numa_balancing feature. Hence
> moving from a simple read mostly variable to a more apt static_branch.
>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
This commit breaks Peter's queue:

kernel/sched/fair.c: In function ‘task_numa_fault’:
kernel/sched/fair.c:2072: error: implicit declaration of function 
‘static_branch_likely’
kernel/sched/fair.c: In function ‘task_tick_fair’:
kernel/sched/fair.c:7867: error: implicit declaration of function 
‘static_branch_unlikely’
make[1]: *** [kernel/sched/fair.o] Error 1
make[1]: *** Waiting for unfinished jobs....
kernel/sched/core.c:2116: warning: data definition has no type or 
storage class
kernel/sched/core.c:2116: error: type defaults to ‘int’ in declaration 
of ‘DEFINE_STATIC_KEY_FALSE’
kernel/sched/core.c:2116: warning: parameter names (without types) in 
function declaration
kernel/sched/core.c: In function ‘set_numabalancing_state’:
kernel/sched/core.c:2123: error: implicit declaration of function 
‘static_branch_enable’
kernel/sched/core.c:2125: error: implicit declaration of function 
‘static_branch_disable’
kernel/sched/core.c: In function ‘sysctl_numa_balancing’:
kernel/sched/core.c:2134: error: implicit declaration of function 
‘static_branch_likely’
make[1]: *** [kernel/sched/core.o] Error 1
make: *** [kernel/sched/] Error 2

Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1219919

* Wanpeng Li <wanpeng.li@hotmail.com> [2015-09-06 12:01:10]:


Hi Wanpeng Li, 


> Hi Srikar,
> On 8/12/15 12:24 AM, Srikar Dronamraju wrote:
> >Variable sched_numa_balancing toggles numa_balancing feature. Hence
> >moving from a simple read mostly variable to a more apt static_branch.
> >
> >Suggested-by: Peter Zijlstra <peterz@infradead.org>
> >Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> >
> This commit breaks Peter's queue:
> 
> kernel/sched/fair.c: In function ?task_numa_fault?:
> kernel/sched/fair.c:2072: error: implicit declaration of function
> ?static_branch_likely?
> kernel/sched/fair.c: In function ?task_tick_fair?:
> kernel/sched/fair.c:7867: error: implicit declaration of function
> ?static_branch_unlikely?
> make[1]: *** [kernel/sched/fair.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> kernel/sched/core.c:2116: warning: data definition has no type or storage
> class

Thanks for reporting.  Can you please confirm if you have the commit
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=11276d5306b8e5b438a36bbff855fe792d7eaa61

From 11276d5306b8e5b438a36bbff855fe792d7eaa61 Mon Sep 17 00:00:00 2001
From: Peter Zijlstra <peterz@infradead.org>
Date: Fri, 24 Jul 2015 15:09:55 +0200
Subject: [PATCH] locking/static_keys: Add a new static_key interface


-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1219930

On 9/7/15 12:10 PM, Srikar Dronamraju wrote:
> * Wanpeng Li <wanpeng.li@hotmail.com> [2015-09-06 12:01:10]:
>
>
> Hi Wanpeng Li,
>
>
>> Hi Srikar,
>> On 8/12/15 12:24 AM, Srikar Dronamraju wrote:
>>> Variable sched_numa_balancing toggles numa_balancing feature. Hence
>>> moving from a simple read mostly variable to a more apt static_branch.
>>>
>>> Suggested-by: Peter Zijlstra <peterz@infradead.org>
>>> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>>>
>> This commit breaks Peter's queue:
>>
>> kernel/sched/fair.c: In function ?task_numa_fault?:
>> kernel/sched/fair.c:2072: error: implicit declaration of function
>> ?static_branch_likely?
>> kernel/sched/fair.c: In function ?task_tick_fair?:
>> kernel/sched/fair.c:7867: error: implicit declaration of function
>> ?static_branch_unlikely?
>> make[1]: *** [kernel/sched/fair.o] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> kernel/sched/core.c:2116: warning: data definition has no type or storage
>> class
> Thanks for reporting.  Can you please confirm if you have the commit
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=11276d5306b8e5b438a36bbff855fe792d7eaa61

It seems that the sched/core branch of Peterz's queue doesn't include 
this commit. So your patch should be good.

Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web