Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1219930
| From | Wanpeng Li <wanpeng.li@hotmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch |
| Date | 2015-09-07 07:30 +0200 |
| Message-ID | <q5Xaa-4yA-1@gated-at.bofh.it> (permalink) |
| References | <pWfBo-3hD-15@gated-at.bofh.it> <pWkB4-21W-21@gated-at.bofh.it> <q5zrb-4sO-5@gated-at.bofh.it> <q5W4p-304-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 9/7/15 12:10 PM, Srikar Dronamraju wrote: > * Wanpeng Li <wanpeng.li@hotmail.com> [2015-09-06 12:01:10]: > > > Hi Wanpeng Li, > > >> Hi Srikar, >> On 8/12/15 12:24 AM, Srikar Dronamraju wrote: >>> Variable sched_numa_balancing toggles numa_balancing feature. Hence >>> moving from a simple read mostly variable to a more apt static_branch. >>> >>> Suggested-by: Peter Zijlstra <peterz@infradead.org> >>> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> >>> >> This commit breaks Peter's queue: >> >> kernel/sched/fair.c: In function ?task_numa_fault?: >> kernel/sched/fair.c:2072: error: implicit declaration of function >> ?static_branch_likely? >> kernel/sched/fair.c: In function ?task_tick_fair?: >> kernel/sched/fair.c:7867: error: implicit declaration of function >> ?static_branch_unlikely? >> make[1]: *** [kernel/sched/fair.o] Error 1 >> make[1]: *** Waiting for unfinished jobs.... >> kernel/sched/core.c:2116: warning: data definition has no type or storage >> class > Thanks for reporting. Can you please confirm if you have the commit > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=11276d5306b8e5b438a36bbff855fe792d7eaa61 It seems that the sched/core branch of Peterz's queue doesn't include this commit. So your patch should be good. Regards, Wanpeng Li -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-06 06:10 +0200
Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2015-09-07 06:20 +0200
Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-07 07:30 +0200
csiph-web