Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1218663 > unrolled thread
| Started by | Alexey Klimov <alexey.klimov@linaro.org> |
|---|---|
| First post | 2015-09-04 05:30 +0200 |
| Last post | 2015-09-04 10:50 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[RFC PATCH 1/3] clocksource: mtk_timer: add pr_fmt define Alexey Klimov <alexey.klimov@linaro.org> - 2015-09-04 05:30 +0200
[RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init Alexey Klimov <alexey.klimov@linaro.org> - 2015-09-04 05:30 +0200
Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init Joe Perches <joe@perches.com> - 2015-09-04 05:50 +0200
Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init Matthias Brugger <matthias.bgg@gmail.com> - 2015-09-04 11:00 +0200
[RFC PATCH 3/3] clocksource: mtk_timer: fix memleak in mtk_timer_init() Alexey Klimov <alexey.klimov@linaro.org> - 2015-09-04 05:30 +0200
Re: [RFC PATCH 3/3] clocksource: mtk_timer: fix memleak in mtk_timer_init() Matthias Brugger <matthias.bgg@gmail.com> - 2015-09-04 10:50 +0200
| From | Alexey Klimov <alexey.klimov@linaro.org> |
|---|---|
| Date | 2015-09-04 05:30 +0200 |
| Subject | [RFC PATCH 1/3] clocksource: mtk_timer: add pr_fmt define |
| Message-ID | <q4PRn-6Jw-1@gated-at.bofh.it> |
It's a bit uncler what subsystem/driver emits some messages to dmesg in function mtk_init_timer(). Use pr_fmt to auto-prefix the messages appropriately. Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> --- drivers/clocksource/mtk_timer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c index 50f0641..ca5ea9e 100644 --- a/drivers/clocksource/mtk_timer.c +++ b/drivers/clocksource/mtk_timer.c @@ -16,6 +16,8 @@ * GNU General Public License for more details. */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include <linux/clk.h> #include <linux/clockchips.h> #include <linux/interrupt.h> -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alexey Klimov <alexey.klimov@linaro.org> |
|---|---|
| Date | 2015-09-04 05:30 +0200 |
| Subject | [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init |
| Message-ID | <q4PRn-6Jw-3@gated-at.bofh.it> |
| In reply to | #1218663 |
These messages are actually errors and not warnings.
Use pr_err() macro for them and add missing \n.
Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
---
drivers/clocksource/mtk_timer.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
index ca5ea9e..fbaacbf 100644
--- a/drivers/clocksource/mtk_timer.c
+++ b/drivers/clocksource/mtk_timer.c
@@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node)
evt = kzalloc(sizeof(*evt), GFP_KERNEL);
if (!evt) {
- pr_warn("Can't allocate mtk clock event driver struct");
+ pr_err("Can't allocate mtk clock event driver struct\n");
return;
}
@@ -200,24 +200,24 @@ static void __init mtk_timer_init(struct device_node *node)
evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer");
if (IS_ERR(evt->gpt_base)) {
- pr_warn("Can't get resource\n");
+ pr_err("Can't get resource\n");
return;
}
evt->dev.irq = irq_of_parse_and_map(node, 0);
if (evt->dev.irq <= 0) {
- pr_warn("Can't parse IRQ");
+ pr_err("Can't parse IRQ\n");
goto err_mem;
}
clk = of_clk_get(node, 0);
if (IS_ERR(clk)) {
- pr_warn("Can't get timer clock");
+ pr_err("Can't get timer clock\n");
goto err_irq;
}
if (clk_prepare_enable(clk)) {
- pr_warn("Can't prepare clock");
+ pr_err("Can't prepare clock\n");
goto err_clk_put;
}
rate = clk_get_rate(clk);
@@ -226,7 +226,7 @@ static void __init mtk_timer_init(struct device_node *node)
if (request_irq(evt->dev.irq, mtk_timer_interrupt,
IRQF_TIMER | IRQF_IRQPOLL, "mtk_timer", evt)) {
- pr_warn("failed to setup irq %d\n", evt->dev.irq);
+ pr_err("failed to setup irq %d\n", evt->dev.irq);
goto err_clk_disable;
}
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2015-09-04 05:50 +0200 |
| Subject | Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init |
| Message-ID | <q4QaJ-75R-1@gated-at.bofh.it> |
| In reply to | #1218664 |
On Fri, 2015-09-04 at 06:21 +0300, Alexey Klimov wrote:
> These messages are actually errors and not warnings.
> Use pr_err() macro for them and add missing \n.
[]
> diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
[]
> @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node)
>
> evt = kzalloc(sizeof(*evt), GFP_KERNEL);
> if (!evt) {
> - pr_warn("Can't allocate mtk clock event driver struct");
> + pr_err("Can't allocate mtk clock event driver struct\n");
> return;
> }
Might as well remove this one as there's
a generic stack_dump() on alloc failures.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Date | 2015-09-04 11:00 +0200 |
| Subject | Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init |
| Message-ID | <q4V0K-5zg-7@gated-at.bofh.it> |
| In reply to | #1218664 |
On 04/09/15 05:21, Alexey Klimov wrote:
> These messages are actually errors and not warnings.
> Use pr_err() macro for them and add missing \n.
>
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/clocksource/mtk_timer.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
> index ca5ea9e..fbaacbf 100644
> --- a/drivers/clocksource/mtk_timer.c
> +++ b/drivers/clocksource/mtk_timer.c
> @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node)
>
> evt = kzalloc(sizeof(*evt), GFP_KERNEL);
> if (!evt) {
> - pr_warn("Can't allocate mtk clock event driver struct");
> + pr_err("Can't allocate mtk clock event driver struct\n");
> return;
> }
>
> @@ -200,24 +200,24 @@ static void __init mtk_timer_init(struct device_node *node)
>
> evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer");
> if (IS_ERR(evt->gpt_base)) {
> - pr_warn("Can't get resource\n");
> + pr_err("Can't get resource\n");
> return;
> }
>
> evt->dev.irq = irq_of_parse_and_map(node, 0);
> if (evt->dev.irq <= 0) {
> - pr_warn("Can't parse IRQ");
> + pr_err("Can't parse IRQ\n");
> goto err_mem;
> }
>
> clk = of_clk_get(node, 0);
> if (IS_ERR(clk)) {
> - pr_warn("Can't get timer clock");
> + pr_err("Can't get timer clock\n");
> goto err_irq;
> }
>
> if (clk_prepare_enable(clk)) {
> - pr_warn("Can't prepare clock");
> + pr_err("Can't prepare clock\n");
> goto err_clk_put;
> }
> rate = clk_get_rate(clk);
> @@ -226,7 +226,7 @@ static void __init mtk_timer_init(struct device_node *node)
>
> if (request_irq(evt->dev.irq, mtk_timer_interrupt,
> IRQF_TIMER | IRQF_IRQPOLL, "mtk_timer", evt)) {
> - pr_warn("failed to setup irq %d\n", evt->dev.irq);
> + pr_err("failed to setup irq %d\n", evt->dev.irq);
> goto err_clk_disable;
> }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Alexey Klimov <alexey.klimov@linaro.org> |
|---|---|
| Date | 2015-09-04 05:30 +0200 |
| Subject | [RFC PATCH 3/3] clocksource: mtk_timer: fix memleak in mtk_timer_init() |
| Message-ID | <q4PRo-6Jw-5@gated-at.bofh.it> |
| In reply to | #1218663 |
Add error path to clear evt struct allocated by kzalloc()
in the beginning of function mtk_timer_init().
Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
---
drivers/clocksource/mtk_timer.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
index fbaacbf..9c5a2cc 100644
--- a/drivers/clocksource/mtk_timer.c
+++ b/drivers/clocksource/mtk_timer.c
@@ -201,7 +201,7 @@ static void __init mtk_timer_init(struct device_node *node)
evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer");
if (IS_ERR(evt->gpt_base)) {
pr_err("Can't get resource\n");
- return;
+ goto err_kzalloc;
}
evt->dev.irq = irq_of_parse_and_map(node, 0);
@@ -256,5 +256,7 @@ err_mem:
iounmap(evt->gpt_base);
of_address_to_resource(node, 0, &res);
release_mem_region(res.start, resource_size(&res));
+err_kzalloc:
+ kfree(evt);
}
CLOCKSOURCE_OF_DECLARE(mtk_mt6577, "mediatek,mt6577-timer", mtk_timer_init);
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Date | 2015-09-04 10:50 +0200 |
| Subject | Re: [RFC PATCH 3/3] clocksource: mtk_timer: fix memleak in mtk_timer_init() |
| Message-ID | <q4UR3-5nR-3@gated-at.bofh.it> |
| In reply to | #1218665 |
On 04/09/15 05:21, Alexey Klimov wrote:
> Add error path to clear evt struct allocated by kzalloc()
> in the beginning of function mtk_timer_init().
>
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> ---
> drivers/clocksource/mtk_timer.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
> index fbaacbf..9c5a2cc 100644
> --- a/drivers/clocksource/mtk_timer.c
> +++ b/drivers/clocksource/mtk_timer.c
> @@ -201,7 +201,7 @@ static void __init mtk_timer_init(struct device_node *node)
> evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer");
> if (IS_ERR(evt->gpt_base)) {
> pr_err("Can't get resource\n");
> - return;
> + goto err_kzalloc;
> }
>
> evt->dev.irq = irq_of_parse_and_map(node, 0);
> @@ -256,5 +256,7 @@ err_mem:
> iounmap(evt->gpt_base);
> of_address_to_resource(node, 0, &res);
> release_mem_region(res.start, resource_size(&res));
> +err_kzalloc:
> + kfree(evt);
> }
> CLOCKSOURCE_OF_DECLARE(mtk_mt6577, "mediatek,mt6577-timer", mtk_timer_init);
>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web