Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1218667

Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init

Show all headers | View raw

On Fri, 2015-09-04 at 06:21 +0300, Alexey Klimov wrote:
> These messages are actually errors and not warnings.
> Use pr_err() macro for them and add missing \n.
[]
> diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
[]
> @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node)
>  
>  	evt = kzalloc(sizeof(*evt), GFP_KERNEL);
>  	if (!evt) {
> -		pr_warn("Can't allocate mtk clock event driver struct");
> +		pr_err("Can't allocate mtk clock event driver struct\n");
>  		return;
>  	}

Might as well remove this one as there's
a generic stack_dump() on alloc failures.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/3] clocksource: mtk_timer: add pr_fmt define Alexey Klimov <alexey.klimov@linaro.org> - 2015-09-04 05:30 +0200
  [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init Alexey Klimov <alexey.klimov@linaro.org> - 2015-09-04 05:30 +0200
    Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to  pr_err()s in mtk_timer_init Joe Perches <joe@perches.com> - 2015-09-04 05:50 +0200
    Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to  pr_err()s in mtk_timer_init Matthias Brugger <matthias.bgg@gmail.com> - 2015-09-04 11:00 +0200
  [RFC PATCH 3/3] clocksource: mtk_timer: fix memleak in mtk_timer_init() Alexey Klimov <alexey.klimov@linaro.org> - 2015-09-04 05:30 +0200
    Re: [RFC PATCH 3/3] clocksource: mtk_timer: fix memleak in  mtk_timer_init() Matthias Brugger <matthias.bgg@gmail.com> - 2015-09-04 10:50 +0200

csiph-web