Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1217086 > unrolled thread
| Started by | Kan Liang <kan.liang@intel.com> |
|---|---|
| First post | 2015-09-01 23:20 +0200 |
| Last post | 2015-09-02 08:10 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH V4 3/3] perf,test: test cpu topology Kan Liang <kan.liang@intel.com> - 2015-09-01 23:20 +0200
Re: [PATCH V4 3/3] perf,test: test cpu topology Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-02 00:40 +0200
RE: [PATCH V4 3/3] perf,test: test cpu topology "Liang, Kan" <kan.liang@intel.com> - 2015-09-02 01:30 +0200
Re: [PATCH V4 3/3] perf,test: test cpu topology Jiri Olsa <jolsa@redhat.com> - 2015-09-02 08:10 +0200
| From | Kan Liang <kan.liang@intel.com> |
|---|---|
| Date | 2015-09-01 23:20 +0200 |
| Subject | [PATCH V4 3/3] perf,test: test cpu topology |
| Message-ID | <q418d-1tL-3@gated-at.bofh.it> |
From: Jiri Olsa <jolsa@kernel.org>
This patch test cpu core_id and socket_id which are stored in perf_env.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
Changes since jirka's original version
- Use pr_debug to replace fprintf
- Add date_size to avoid warning
- Introduce cpu_map, and compare core_id and socket_id
between cpu_map and perf_env
Changes since V2:
- unlink(path)
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 4 ++++
tools/perf/tests/tests.h | 1 +
3 files changed, 6 insertions(+)
diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
index c1518bd..208bbdf 100644
--- a/tools/perf/tests/Build
+++ b/tools/perf/tests/Build
@@ -33,6 +33,7 @@ perf-y += parse-no-sample-id-all.o
perf-y += kmod-path.o
perf-y += thread-map.o
perf-y += llvm.o
+perf-y += topology.o
perf-$(CONFIG_X86) += perf-time-to-tsc.o
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 136cd93..6650f26 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -179,6 +179,10 @@ static struct test {
.func = test__llvm,
},
{
+ .desc = "Test topology in session",
+ .func = test_session_topology,
+ },
+ {
.func = NULL,
},
};
diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
index bf113a2..95654d7 100644
--- a/tools/perf/tests/tests.h
+++ b/tools/perf/tests/tests.h
@@ -63,6 +63,7 @@ int test__fdarray__add(void);
int test__kmod_path__parse(void);
int test__thread_map(void);
int test__llvm(void);
+int test_session_topology(void);
#if defined(__x86_64__) || defined(__i386__) || defined(__arm__) || defined(__aarch64__)
#ifdef HAVE_DWARF_UNWIND_SUPPORT
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2015-09-02 00:40 +0200 |
| Message-ID | <q42nE-3aL-19@gated-at.bofh.it> |
| In reply to | #1217086 |
Em Tue, Sep 01, 2015 at 09:58:13AM -0400, Kan Liang escreveu:
> From: Jiri Olsa <jolsa@kernel.org>
>
> This patch test cpu core_id and socket_id which are stored in perf_env.
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Signed-off-by: Kan Liang <kan.liang@intel.com>
> ---
>
> Changes since jirka's original version
> - Use pr_debug to replace fprintf
> - Add date_size to avoid warning
> - Introduce cpu_map, and compare core_id and socket_id
> between cpu_map and perf_env
Humm, two questions:
Since you changed it that much, wouldn't be better to give you the
authorship while still giving credit to Jiri for the original version?
Something like:
Based-on-a-patch-by: Jiri Olsa
[acme@zoo linux]$ git log | grep Based-on-patch-by: | wc -l
61
[acme@zoo linux]$ git log | grep Based-on-a-patch-by: | wc -l
4
[acme@zoo linux]$
But then you need to resubmit this anyway, as you forgot to do the:
git add tools/perf/tests/topology.c
:-)
- Arnaldo
> Changes since V2:
> - unlink(path)
>
> tools/perf/tests/Build | 1 +
> tools/perf/tests/builtin-test.c | 4 ++++
> tools/perf/tests/tests.h | 1 +
> 3 files changed, 6 insertions(+)
>
> diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
> index c1518bd..208bbdf 100644
> --- a/tools/perf/tests/Build
> +++ b/tools/perf/tests/Build
> @@ -33,6 +33,7 @@ perf-y += parse-no-sample-id-all.o
> perf-y += kmod-path.o
> perf-y += thread-map.o
> perf-y += llvm.o
> +perf-y += topology.o
>
> perf-$(CONFIG_X86) += perf-time-to-tsc.o
>
> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 136cd93..6650f26 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -179,6 +179,10 @@ static struct test {
> .func = test__llvm,
> },
> {
> + .desc = "Test topology in session",
> + .func = test_session_topology,
> + },
> + {
> .func = NULL,
> },
> };
> diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
> index bf113a2..95654d7 100644
> --- a/tools/perf/tests/tests.h
> +++ b/tools/perf/tests/tests.h
> @@ -63,6 +63,7 @@ int test__fdarray__add(void);
> int test__kmod_path__parse(void);
> int test__thread_map(void);
> int test__llvm(void);
> +int test_session_topology(void);
>
> #if defined(__x86_64__) || defined(__i386__) || defined(__arm__) || defined(__aarch64__)
> #ifdef HAVE_DWARF_UNWIND_SUPPORT
> --
> 1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Liang, Kan" <kan.liang@intel.com> |
|---|---|
| Date | 2015-09-02 01:30 +0200 |
| Message-ID | <q43a2-4kL-23@gated-at.bofh.it> |
| In reply to | #1217126 |
>
> Em Tue, Sep 01, 2015 at 09:58:13AM -0400, Kan Liang escreveu:
> > From: Jiri Olsa <jolsa@kernel.org>
> >
> > This patch test cpu core_id and socket_id which are stored in perf_env.
> >
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Signed-off-by: Kan Liang <kan.liang@intel.com>
> > ---
> >
> > Changes since jirka's original version
> > - Use pr_debug to replace fprintf
> > - Add date_size to avoid warning
> > - Introduce cpu_map, and compare core_id and socket_id
> > between cpu_map and perf_env
>
> Humm, two questions:
>
> Since you changed it that much, wouldn't be better to give you the
> authorship while still giving credit to Jiri for the original version?
> Something like:
>
> Based-on-a-patch-by: Jiri Olsa
Jiri, are you OK with that?
>
> [acme@zoo linux]$ git log | grep Based-on-patch-by: | wc -l
> 61
> [acme@zoo linux]$ git log | grep Based-on-a-patch-by: | wc -l
> 4
> [acme@zoo linux]$
>
> But then you need to resubmit this anyway, as you forgot to do the:
>
> git add tools/perf/tests/topology.c
Ah... My bad. :(
I will resubmit the patch then.
Thanks,
Kan
>
> :-)
>
> - Arnaldo
>
> > Changes since V2:
> > - unlink(path)
> >
> > tools/perf/tests/Build | 1 +
> > tools/perf/tests/builtin-test.c | 4 ++++
> > tools/perf/tests/tests.h | 1 +
> > 3 files changed, 6 insertions(+)
> >
> > diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build index
> > c1518bd..208bbdf 100644
> > --- a/tools/perf/tests/Build
> > +++ b/tools/perf/tests/Build
> > @@ -33,6 +33,7 @@ perf-y += parse-no-sample-id-all.o perf-y +=
> > kmod-path.o perf-y += thread-map.o perf-y += llvm.o
> > +perf-y += topology.o
> >
> > perf-$(CONFIG_X86) += perf-time-to-tsc.o
> >
> > diff --git a/tools/perf/tests/builtin-test.c
> > b/tools/perf/tests/builtin-test.c index 136cd93..6650f26 100644
> > --- a/tools/perf/tests/builtin-test.c
> > +++ b/tools/perf/tests/builtin-test.c
> > @@ -179,6 +179,10 @@ static struct test {
> > .func = test__llvm,
> > },
> > {
> > + .desc = "Test topology in session",
> > + .func = test_session_topology,
> > + },
> > + {
> > .func = NULL,
> > },
> > };
> > diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h index
> > bf113a2..95654d7 100644
> > --- a/tools/perf/tests/tests.h
> > +++ b/tools/perf/tests/tests.h
> > @@ -63,6 +63,7 @@ int test__fdarray__add(void); int
> > test__kmod_path__parse(void); int test__thread_map(void); int
> > test__llvm(void);
> > +int test_session_topology(void);
> >
> > #if defined(__x86_64__) || defined(__i386__) || defined(__arm__) ||
> > defined(__aarch64__) #ifdef HAVE_DWARF_UNWIND_SUPPORT
> > --
> > 1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2015-09-02 08:10 +0200 |
| Message-ID | <q49p8-501-7@gated-at.bofh.it> |
| In reply to | #1217170 |
On Tue, Sep 01, 2015 at 11:25:10PM +0000, Liang, Kan wrote: > > > > > > Em Tue, Sep 01, 2015 at 09:58:13AM -0400, Kan Liang escreveu: > > > From: Jiri Olsa <jolsa@kernel.org> > > > > > > This patch test cpu core_id and socket_id which are stored in perf_env. > > > > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > > Signed-off-by: Kan Liang <kan.liang@intel.com> > > > --- > > > > > > Changes since jirka's original version > > > - Use pr_debug to replace fprintf > > > - Add date_size to avoid warning > > > - Introduce cpu_map, and compare core_id and socket_id > > > between cpu_map and perf_env > > > > Humm, two questions: > > > > Since you changed it that much, wouldn't be better to give you the > > authorship while still giving credit to Jiri for the original version? > > Something like: > > > > Based-on-a-patch-by: Jiri Olsa > > Jiri, are you OK with that? yep > > > > > [acme@zoo linux]$ git log | grep Based-on-patch-by: | wc -l > > 61 > > [acme@zoo linux]$ git log | grep Based-on-a-patch-by: | wc -l > > 4 > > [acme@zoo linux]$ > > > > But then you need to resubmit this anyway, as you forgot to do the: > > > > git add tools/perf/tests/topology.c > > Ah... My bad. :( > > I will resubmit the patch then. I'll review new version jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web