Re: [PATCH V4 3/3] perf,test: test cpu topology

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 3/3] perf,test: test cpu topology
Date	2015-09-02 08:10 +0200
Message-ID	<q49p8-501-7@gated-at.bofh.it> (permalink)
References	<q418d-1tL-5@gated-at.bofh.it> <q418d-1tL-3@gated-at.bofh.it> <q42nE-3aL-19@gated-at.bofh.it> <q43a2-4kL-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 01, 2015 at 11:25:10PM +0000, Liang, Kan wrote:
> 
> 
> > 
> > Em Tue, Sep 01, 2015 at 09:58:13AM -0400, Kan Liang escreveu:
> > > From: Jiri Olsa <jolsa@kernel.org>
> > >
> > > This patch test cpu core_id and socket_id which are stored in perf_env.
> > >
> > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > Signed-off-by: Kan Liang <kan.liang@intel.com>
> > > ---
> > >
> > > Changes since jirka's original version
> > >  - Use pr_debug to replace fprintf
> > >  - Add date_size to avoid warning
> > >  - Introduce cpu_map, and compare core_id and socket_id
> > >    between cpu_map and perf_env
> > 
> > Humm, two questions:
> > 
> > Since you changed it that much, wouldn't be better to give you the
> > authorship while still giving credit to Jiri for the original version?
> > Something like:
> > 
> > Based-on-a-patch-by: Jiri Olsa
> 
> Jiri, are you OK with that?

yep

> 
> > 
> > [acme@zoo linux]$ git log | grep Based-on-patch-by: | wc -l
> > 61
> > [acme@zoo linux]$ git log | grep Based-on-a-patch-by: | wc -l
> > 4
> > [acme@zoo linux]$
> > 
> > But then you need to resubmit this anyway, as you forgot to do the:
> > 
> >  git add tools/perf/tests/topology.c
> 
> Ah... My bad. :(
> 
> I will resubmit the patch then.

I'll review new version

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V4 3/3] perf,test: test cpu topology Kan Liang <kan.liang@intel.com> - 2015-09-01 23:20 +0200
  Re: [PATCH V4 3/3] perf,test: test cpu topology Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-02 00:40 +0200
    RE: [PATCH V4 3/3] perf,test: test cpu topology "Liang, Kan" <kan.liang@intel.com> - 2015-09-02 01:30 +0200
      Re: [PATCH V4 3/3] perf,test: test cpu topology Jiri Olsa <jolsa@redhat.com> - 2015-09-02 08:10 +0200

csiph-web