Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1217035 > unrolled thread
| Started by | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| First post | 2015-09-01 21:30 +0200 |
| Last post | 2015-09-02 17:20 +0200 |
| Articles | 6 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-01 21:30 +0200
Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn Joe Perches <joe@perches.com> - 2015-09-01 22:40 +0200
Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-02 08:40 +0200
Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-02 15:10 +0200
Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn Joe Perches <joe@perches.com> - 2015-09-02 17:10 +0200
Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-02 17:20 +0200
| From | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| Date | 2015-09-01 21:30 +0200 |
| Subject | [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn |
| Message-ID | <q3ZpM-7px-3@gated-at.bofh.it> |
Return value would give clear information about the actual root-cause
of the failure.
Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
---
drivers/mmc/host/sdhci-pxav3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index d02bc37..5d26fe0 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
ret = sdhci_add_host(host);
if (ret) {
- dev_err(&pdev->dev, "failed to add host\n");
+ dev_err(&pdev->dev, "failed to add host ret - %d\n", ret);
goto err_add_host;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2015-09-01 22:40 +0200 |
| Subject | Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn |
| Message-ID | <q40vv-uu-7@gated-at.bofh.it> |
| In reply to | #1217035 |
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
> Return value would give clear information about the actual root-cause
> of the failure.
I'm not sure why that is as nearly every error path in
sdhci_add_host emits a message.
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
[]
> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
>
> ret = sdhci_add_host(host);
> if (ret) {
> - dev_err(&pdev->dev, "failed to add host\n");
> + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret);
> goto err_add_host;
> }
>
If this is really desirable, there are many other callers of
sdhci_add_host with error messages just like this one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| Date | 2015-09-02 08:40 +0200 |
| Subject | Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn |
| Message-ID | <q49Sa-5xC-1@gated-at.bofh.it> |
| In reply to | #1217069 |
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
> On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
>> Return value would give clear information about the actual root-cause
>> of the failure.
>
> I'm not sure why that is as nearly every error path in
> sdhci_add_host emits a message.
>
Not for everything.
No error message for -EPROBE_DEFER.
>> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> []
>> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
>>
>> ret = sdhci_add_host(host);
>> if (ret) {
>> - dev_err(&pdev->dev, "failed to add host\n");
>> + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret);
>> goto err_add_host;
>> }
>>
>
> If this is really desirable, there are many other callers of
> sdhci_add_host with error messages just like this one.
>
Yes, true.
Ho about, adding pr_err into sdhci_add_host for -EPROBE_DEFER.
Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| Date | 2015-09-02 15:10 +0200 |
| Subject | Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn |
| Message-ID | <q4fXz-5Wu-1@gated-at.bofh.it> |
| In reply to | #1217069 |
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
> On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
>> Return value would give clear information about the actual root-cause
>> of the failure.
>> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
>> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
>>
>> ret = sdhci_add_host(host);
>> if (ret) {
>> - dev_err(&pdev->dev, "failed to add host\n");
>> + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret);
>> goto err_add_host;
>> }
>>
>
> If this is really desirable, there are many other callers of
> sdhci_add_host with error messages just like this one.
>
How about this? If you are ok, I can change it and submit the patch
again.
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index d2caa60..3a4902c 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -3176,8 +3176,11 @@ int sdhci_add_host(struct sdhci_host *host)
mmc->caps |= MMC_CAP_NEEDS_POLL;
/* If there are external regulators, get them */
- if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER)
+ if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER) {
+ pr_err("%s: regulator supply unavailable, deferring
probe. \n",
+ mmc_hostname(mmc));
return -EPROBE_DEFER;
+ }
/* If vqmmc regulator and no 1.8V signalling, then there's no
UHS */
if (!IS_ERR(mmc->supply.vqmmc)) {
Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2015-09-02 17:10 +0200 |
| Subject | Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn |
| Message-ID | <q4hPI-bE-11@gated-at.bofh.it> |
| In reply to | #1217587 |
On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote:
> On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
> > On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
> >> Return value would give clear information about the actual root-cause
> >> of the failure.
> >> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> >> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
> >>
> >> ret = sdhci_add_host(host);
> >> if (ret) {
> >> - dev_err(&pdev->dev, "failed to add host\n");
> >> + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret);
> >> goto err_add_host;
> >> }
> >
> > If this is really desirable, there are many other callers of
> > sdhci_add_host with error messages just like this one.
> >
> How about this? If you are ok, I can change it and submit the patch
> again.
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
[]
> @@ -3176,8 +3176,11 @@ int sdhci_add_host(struct sdhci_host *host)
> mmc->caps |= MMC_CAP_NEEDS_POLL;
>
> /* If there are external regulators, get them */
> - if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER)
> + if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER) {
> + pr_err("%s: regulator supply unavailable, deferring
> probe. \n",
> + mmc_hostname(mmc));
> return -EPROBE_DEFER;
> + }
(your email client has inappropriate line wrapping)
The KERN_<LEVEL> here probably isn't right.
Deferring isn't an error, at best it's a notification
and perhaps should be at pr_notice/KERN_NOTICE
I don't know how often or how many times this deferral
can occur. Do you?
If it's moderately common, that message should likely
be ratelimited if it exists at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| Date | 2015-09-02 17:20 +0200 |
| Subject | Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn |
| Message-ID | <q4hZn-n0-7@gated-at.bofh.it> |
| In reply to | #1217687 |
On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote:
> On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote:
>> On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
>>> On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
>>>> Return value would give clear information about the actual root-cause
>>>> of the failure.
>>>> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
>>>> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
>>>>
>>>> ret = sdhci_add_host(host);
>>>> if (ret) {
>>>> - dev_err(&pdev->dev, "failed to add host\n");
>>>> + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret);
>>>> goto err_add_host;
>>>> }
>>>
>>> If this is really desirable, there are many other callers of
>>> sdhci_add_host with error messages just like this one.
>>>
>> How about this? If you are ok, I can change it and submit the patch
>> again.
>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> []
>> @@ -3176,8 +3176,11 @@ int sdhci_add_host(struct sdhci_host *host)
>> mmc->caps |= MMC_CAP_NEEDS_POLL;
>>
>> /* If there are external regulators, get them */
>> - if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER)
>> + if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER) {
>> + pr_err("%s: regulator supply unavailable, deferring
>> probe. \n",
>> + mmc_hostname(mmc));
>> return -EPROBE_DEFER;
>> + }
>
> (your email client has inappropriate line wrapping)
>
> The KERN_<LEVEL> here probably isn't right.
>
> Deferring isn't an error, at best it's a notification
I would consider it as an ERROR if it gets deferred
continuously/multiple times due to same reason.
> and perhaps should be at pr_notice/KERN_NOTICE
>
Yeah, KERN_NOTICE looks right here.
> I don't know how often or how many times this deferral
> can occur. Do you?
>
-EDEFER_PROBE usually means that driver has some dependency,
for which it has to wait.
In my case, during every boot, I pxav3_sdhci_probe gets deferred once
due to regulator unavailability.
Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web