Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn
Date	2015-09-01 22:40 +0200
Message-ID	<q40vv-uu-7@gated-at.bofh.it> (permalink)
References	<q3ZpM-7px-5@gated-at.bofh.it> <q3ZpM-7px-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
> Return value would give clear information about the actual root-cause
> of the failure.

I'm not sure why that is as nearly every error path in
sdhci_add_host emits a message.

> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
[]
> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
>  
>  	ret = sdhci_add_host(host);
>  	if (ret) {
> -		dev_err(&pdev->dev, "failed to add host\n");
> +		dev_err(&pdev->dev, "failed to add host ret - %d\n", ret);
>  		goto err_add_host;
>  	}
>  

If this is really desirable, there are many other callers of
sdhci_add_host with error messages just like this one.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-01 21:30 +0200
  Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from  sdhci_add_host() fn Joe Perches <joe@perches.com> - 2015-09-01 22:40 +0200
    Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from  sdhci_add_host() fn Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-02 08:40 +0200
    Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from  sdhci_add_host() fn Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-02 15:10 +0200
      Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from  sdhci_add_host() fn Joe Perches <joe@perches.com> - 2015-09-02 17:10 +0200
        Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from  sdhci_add_host() fn Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-02 17:20 +0200

csiph-web