Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216153 > unrolled thread

[PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks

Started byKirill Tkhai <ktkhai@odin.com>
First post2015-08-31 14:00 +0200
Last post2015-08-31 15:40 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit()  callbacks Kirill Tkhai <ktkhai@odin.com> - 2015-08-31 14:00 +0200
    Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from  cgroup_exit() callbacks Peter Zijlstra <peterz@infradead.org> - 2015-08-31 14:00 +0200
      Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit()  callbacks Kirill Tkhai <ktkhai@odin.com> - 2015-08-31 14:20 +0200
        Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from  cgroup_exit() callbacks Peter Zijlstra <peterz@infradead.org> - 2015-08-31 15:40 +0200

#1216153 — [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks

FromKirill Tkhai <ktkhai@odin.com>
Date2015-08-31 14:00 +0200
Subject[PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks
Message-ID<q3vUJ-6NQ-7@gated-at.bofh.it>
Remove useless checks and outdates commentaries.

Signed-off-by: Kirill Tkhai <ktkhai@odin.com>
---
 kernel/events/core.c |    8 --------
 kernel/sched/core.c  |    8 --------
 2 files changed, 16 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index ae16867..94bd500 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9219,14 +9219,6 @@ static void perf_cgroup_exit(struct cgroup_subsys_state *css,
 			     struct cgroup_subsys_state *old_css,
 			     struct task_struct *task)
 {
-	/*
-	 * cgroup_exit() is called in the copy_process() failure path.
-	 * Ignore this case since the task hasn't ran yet, this avoids
-	 * trying to poke a half freed task state from generic code.
-	 */
-	if (!(task->flags & PF_EXITING))
-		return;
-
 	task_function_call(task, __perf_cgroup_move, task);
 }
 
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index b3386c6..f8509be 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8167,14 +8167,6 @@ static void cpu_cgroup_exit(struct cgroup_subsys_state *css,
 			    struct cgroup_subsys_state *old_css,
 			    struct task_struct *task)
 {
-	/*
-	 * cgroup_exit() is called in the copy_process() failure path.
-	 * Ignore this case since the task hasn't ran yet, this avoids
-	 * trying to poke a half freed task state from generic code.
-	 */
-	if (!(task->flags & PF_EXITING))
-		return;
-
 	sched_move_task(task);
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1216154 — Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks

FromPeter Zijlstra <peterz@infradead.org>
Date2015-08-31 14:00 +0200
SubjectRe: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks
Message-ID<q3vUK-6NQ-17@gated-at.bofh.it>
In reply to#1216153
On Mon, Aug 31, 2015 at 02:49:59PM +0300, Kirill Tkhai wrote:
> Remove useless checks and outdates commentaries.

A slightly bigger Changelog could do, maybe also referring to the commit
that made these checks obsolete.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1216161

FromKirill Tkhai <ktkhai@odin.com>
Date2015-08-31 14:20 +0200
Message-ID<q3we6-7pO-17@gated-at.bofh.it>
In reply to#1216154
On 31.08.2015 14:53, Peter Zijlstra wrote:
> On Mon, Aug 31, 2015 at 02:49:59PM +0300, Kirill Tkhai wrote:
>> Remove useless checks and outdates commentaries.
> 
> A slightly bigger Changelog could do, maybe also referring to the commit
> that made these checks obsolete.
> 

[PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks

cgroup_exit() is not called from copy_process() after commit e8604cb43690b781:

	"cgroup: fix spurious lockdep warning in cgroup_exit()", it's only called

from do_exit(). So these checks are useless and commentaries are obsolete. Remove them.

Signed-off-by: Kirill Tkhai <ktkhai@odin.com>
---
 kernel/events/core.c |    8 --------
 kernel/sched/core.c  |    8 --------
 2 files changed, 16 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index ae16867..94bd500 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9219,14 +9219,6 @@ static void perf_cgroup_exit(struct cgroup_subsys_state *css,
 			     struct cgroup_subsys_state *old_css,
 			     struct task_struct *task)
 {
-	/*
-	 * cgroup_exit() is called in the copy_process() failure path.
-	 * Ignore this case since the task hasn't ran yet, this avoids
-	 * trying to poke a half freed task state from generic code.
-	 */
-	if (!(task->flags & PF_EXITING))
-		return;
-
 	task_function_call(task, __perf_cgroup_move, task);
 }
 
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index b3386c6..f8509be 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8167,14 +8167,6 @@ static void cpu_cgroup_exit(struct cgroup_subsys_state *css,
 			    struct cgroup_subsys_state *old_css,
 			    struct task_struct *task)
 {
-	/*
-	 * cgroup_exit() is called in the copy_process() failure path.
-	 * Ignore this case since the task hasn't ran yet, this avoids
-	 * trying to poke a half freed task state from generic code.
-	 */
-	if (!(task->flags & PF_EXITING))
-		return;
-
 	sched_move_task(task);
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1216184 — Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks

FromPeter Zijlstra <peterz@infradead.org>
Date2015-08-31 15:40 +0200
SubjectRe: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks
Message-ID<q3xtw-Gh-13@gated-at.bofh.it>
In reply to#1216161
I made that two patches, like:

---
Subject: perf: Delete PF_EXITING checks from perf_cgroup_exit() callback
From: Kirill Tkhai <ktkhai@odin.com>
Date: Mon, 31 Aug 2015 15:12:56 +0300

cgroup_exit() is not called from copy_process() after commit:

  e8604cb43690 ("cgroup: fix spurious lockdep warning in cgroup_exit()")

from do_exit(). So this check is useless and the comment is obsolete.

Signed-off-by: Kirill Tkhai <ktkhai@odin.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: http://lkml.kernel.org/r/55E444C8.3020402@odin.com
---
 kernel/events/core.c |    8 --------
 1 file changed, 8 deletions(-)

--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9219,14 +9219,6 @@ static void perf_cgroup_exit(struct cgro
 			     struct cgroup_subsys_state *old_css,
 			     struct task_struct *task)
 {
-	/*
-	 * cgroup_exit() is called in the copy_process() failure path.
-	 * Ignore this case since the task hasn't ran yet, this avoids
-	 * trying to poke a half freed task state from generic code.
-	 */
-	if (!(task->flags & PF_EXITING))
-		return;
-
 	task_function_call(task, __perf_cgroup_move, task);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web