Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216184

Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks

Show all headers | View raw

I made that two patches, like:

---
Subject: perf: Delete PF_EXITING checks from perf_cgroup_exit() callback
From: Kirill Tkhai <ktkhai@odin.com>
Date: Mon, 31 Aug 2015 15:12:56 +0300

cgroup_exit() is not called from copy_process() after commit:

  e8604cb43690 ("cgroup: fix spurious lockdep warning in cgroup_exit()")

from do_exit(). So this check is useless and the comment is obsolete.

Signed-off-by: Kirill Tkhai <ktkhai@odin.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: http://lkml.kernel.org/r/55E444C8.3020402@odin.com
---
 kernel/events/core.c |    8 --------
 1 file changed, 8 deletions(-)

--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9219,14 +9219,6 @@ static void perf_cgroup_exit(struct cgro
 			     struct cgroup_subsys_state *old_css,
 			     struct task_struct *task)
 {
-	/*
-	 * cgroup_exit() is called in the copy_process() failure path.
-	 * Ignore this case since the task hasn't ran yet, this avoids
-	 * trying to poke a half freed task state from generic code.
-	 */
-	if (!(task->flags & PF_EXITING))
-		return;
-
 	task_function_call(task, __perf_cgroup_move, task);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit()  callbacks Kirill Tkhai <ktkhai@odin.com> - 2015-08-31 14:00 +0200
  Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from  cgroup_exit() callbacks Peter Zijlstra <peterz@infradead.org> - 2015-08-31 14:00 +0200
    Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit()  callbacks Kirill Tkhai <ktkhai@odin.com> - 2015-08-31 14:20 +0200
      Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from  cgroup_exit() callbacks Peter Zijlstra <peterz@infradead.org> - 2015-08-31 15:40 +0200

csiph-web