Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1211500 > unrolled thread
| Started by | Paul Gortmaker <paul.gortmaker@windriver.com> |
|---|---|
| First post | 2015-08-22 21:40 +0200 |
| Last post | 2015-09-01 21:20 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-22 21:40 +0200
Re: [PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-01 19:40 +0200
Re: [PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-01 19:50 +0200
Re: [PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-01 21:20 +0200
| From | Paul Gortmaker <paul.gortmaker@windriver.com> |
|---|---|
| Date | 2015-08-22 21:40 +0200 |
| Subject | [PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void |
| Message-ID | <q0mNY-37B-7@gated-at.bofh.it> |
In commit f368ed6088ae9c1fbe1c897bb5f215ce5e63fa1e ("char: make
misc_deregister a void function") this ret variable became unused
which now generates a compile warning. Get rid of it.
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: rtc-linux@googlegroups.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/rtc/rtc-ds1374.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
index 7067232ba507..742ac67eb702 100644
--- a/drivers/rtc/rtc-ds1374.c
+++ b/drivers/rtc/rtc-ds1374.c
@@ -663,9 +663,8 @@ static int ds1374_probe(struct i2c_client *client,
static int ds1374_remove(struct i2c_client *client)
{
struct ds1374 *ds1374 = i2c_get_clientdata(client);
-#ifdef CONFIG_RTC_DRV_DS1374_WDT
- int res;
+#ifdef CONFIG_RTC_DRV_DS1374_WDT
misc_deregister(&ds1374_miscdev);
ds1374_miscdev.parent = NULL;
unregister_reboot_notifier(&ds1374_wdt_notifier);
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2015-09-01 19:40 +0200 |
| Subject | Re: [PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void |
| Message-ID | <q3XHk-4Ux-27@gated-at.bofh.it> |
| In reply to | #1211500 |
On Sat, Aug 22, 2015 at 9:26 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> In commit f368ed6088ae9c1fbe1c897bb5f215ce5e63fa1e ("char: make
> misc_deregister a void function") this ret variable became unused
> which now generates a compile warning. Get rid of it.
>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: rtc-linux@googlegroups.com
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
It's funny how these things end up in mainline, despite at least two
people providing a patch.
> ---
> drivers/rtc/rtc-ds1374.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
> index 7067232ba507..742ac67eb702 100644
> --- a/drivers/rtc/rtc-ds1374.c
> +++ b/drivers/rtc/rtc-ds1374.c
> @@ -663,9 +663,8 @@ static int ds1374_probe(struct i2c_client *client,
> static int ds1374_remove(struct i2c_client *client)
> {
> struct ds1374 *ds1374 = i2c_get_clientdata(client);
> -#ifdef CONFIG_RTC_DRV_DS1374_WDT
> - int res;
>
> +#ifdef CONFIG_RTC_DRV_DS1374_WDT
> misc_deregister(&ds1374_miscdev);
> ds1374_miscdev.parent = NULL;
> unregister_reboot_notifier(&ds1374_wdt_notifier);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2015-09-01 19:50 +0200 |
| Subject | Re: [PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void |
| Message-ID | <q3XR0-55Q-19@gated-at.bofh.it> |
| In reply to | #1216991 |
On Tue, Sep 1, 2015 at 7:37 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Sat, Aug 22, 2015 at 9:26 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>> In commit f368ed6088ae9c1fbe1c897bb5f215ce5e63fa1e ("char: make
>> misc_deregister a void function") this ret variable became unused
>> which now generates a compile warning. Get rid of it.
>>
>> Cc: Alessandro Zummo <a.zummo@towertech.it>
>> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> Cc: rtc-linux@googlegroups.com
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> It's funny how these things end up in mainline, despite at least two
> people providing a patch.
Ah, Greg sent a very early pull request. That explains it...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2015-09-01 21:20 +0200 |
| Subject | Re: [PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void |
| Message-ID | <q3Zg6-7e7-15@gated-at.bofh.it> |
| In reply to | #1216991 |
Hi,
On 01/09/2015 at 19:37:07 +0200, Geert Uytterhoeven wrote :
> On Sat, Aug 22, 2015 at 9:26 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > In commit f368ed6088ae9c1fbe1c897bb5f215ce5e63fa1e ("char: make
> > misc_deregister a void function") this ret variable became unused
> > which now generates a compile warning. Get rid of it.
> >
> > Cc: Alessandro Zummo <a.zummo@towertech.it>
> > Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > Cc: rtc-linux@googlegroups.com
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> It's funny how these things end up in mainline, despite at least two
> people providing a patch.
>
The fact is that I've asked Greg to take the first fix as he is the one
carrying the offending patch. He didn't do it so I'll ensure that the
fix reaches Linus before -rc1.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web