Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216991

Re: [PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void

Show all headers | View raw

On Sat, Aug 22, 2015 at 9:26 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> In commit f368ed6088ae9c1fbe1c897bb5f215ce5e63fa1e ("char: make
> misc_deregister a void function") this ret variable became unused
> which now generates a compile warning.  Get rid of it.
>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: rtc-linux@googlegroups.com
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

It's funny how these things end up in mainline, despite at least two
people providing a patch.

> ---
>  drivers/rtc/rtc-ds1374.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
> index 7067232ba507..742ac67eb702 100644
> --- a/drivers/rtc/rtc-ds1374.c
> +++ b/drivers/rtc/rtc-ds1374.c
> @@ -663,9 +663,8 @@ static int ds1374_probe(struct i2c_client *client,
>  static int ds1374_remove(struct i2c_client *client)
>  {
>         struct ds1374 *ds1374 = i2c_get_clientdata(client);
> -#ifdef CONFIG_RTC_DRV_DS1374_WDT
> -       int res;
>
> +#ifdef CONFIG_RTC_DRV_DS1374_WDT
>         misc_deregister(&ds1374_miscdev);
>         ds1374_miscdev.parent = NULL;
>         unregister_reboot_notifier(&ds1374_wdt_notifier);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] rtc: drop unused ret variable orphaned by misc_deregister becoming void Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-22 21:40 +0200
  Re: [PATCH -next] rtc: drop unused ret variable orphaned by  misc_deregister becoming void Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-01 19:40 +0200
    Re: [PATCH -next] rtc: drop unused ret variable orphaned by  misc_deregister becoming void Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-01 19:50 +0200
    Re: [PATCH -next] rtc: drop unused ret variable orphaned by  misc_deregister becoming void Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-01 21:20 +0200

csiph-web