Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213290 > unrolled thread

[PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9

Started byMaxime Coquelin <mcoquelin.stm32@gmail.com>
First post2015-08-25 22:10 +0200
Last post2015-08-25 23:10 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9 Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-08-25 22:10 +0200
    Re: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9 Arnd Bergmann <arnd@arndb.de> - 2015-08-25 22:40 +0200
      Re: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9 Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-08-25 23:10 +0200

#1213290 — [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9

FromMaxime Coquelin <mcoquelin.stm32@gmail.com>
Date2015-08-25 22:10 +0200
Subject[PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9
Message-ID<q1sHD-7Q-9@gated-at.bofh.it>
STM32 boards having small amount of RAM, we can optimize by reducing max order
page blocks size.

Suggested-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
---
 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index a750c14..57d53af 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1734,7 +1734,7 @@ config FORCE_MAX_ZONEORDER
 	int "Maximum zone order" if ARCH_SHMOBILE_LEGACY
 	range 11 64 if ARCH_SHMOBILE_LEGACY
 	default "12" if SOC_AM33XX
-	default "9" if SA1111 || ARCH_EFM32
+	default "9" if SA1111 || ARCH_EFM32 || ARCH_STM32
 	default "11"
 	help
 	  The kernel memory allocator divides physically contiguous memory
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1213320

FromArnd Bergmann <arnd@arndb.de>
Date2015-08-25 22:40 +0200
Message-ID<q1taF-He-1@gated-at.bofh.it>
In reply to#1213290
On Tuesday 25 August 2015 22:07:17 Maxime Coquelin wrote:
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a750c14..57d53af 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1734,7 +1734,7 @@ config FORCE_MAX_ZONEORDER
>         int "Maximum zone order" if ARCH_SHMOBILE_LEGACY
>         range 11 64 if ARCH_SHMOBILE_LEGACY
>         default "12" if SOC_AM33XX
> -       default "9" if SA1111 || ARCH_EFM32
> +       default "9" if SA1111 || ARCH_EFM32 || ARCH_STM32
>         default "11"
> 

This looks wrong now that we can enable multiple ARMV7M platforms
together. In practice it doesn't matter much, because you wouldn't
do that for a real-life system, but out of principle this seems
like something you'd better put into the defconfig file for
both ARCH_EFM32 and ARCH_STM32. We could also think about changing
the default to "9" for any ARM_SINGLE_ARMV7M config and increasing
it again in defconfig for any platform that actually has a lot of
RAM (if any).

The SOC_AM33XX is slightly different because it increases the default
rather than reducing it, presumably because the larger allocation is
actually required (for what?).

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1213345

FromMaxime Coquelin <mcoquelin.stm32@gmail.com>
Date2015-08-25 23:10 +0200
Message-ID<q1tDH-1uW-5@gated-at.bofh.it>
In reply to#1213320

On 08/25/2015 10:36 PM, Arnd Bergmann wrote:
> On Tuesday 25 August 2015 22:07:17 Maxime Coquelin wrote:
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index a750c14..57d53af 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1734,7 +1734,7 @@ config FORCE_MAX_ZONEORDER
>>          int "Maximum zone order" if ARCH_SHMOBILE_LEGACY
>>          range 11 64 if ARCH_SHMOBILE_LEGACY
>>          default "12" if SOC_AM33XX
>> -       default "9" if SA1111 || ARCH_EFM32
>> +       default "9" if SA1111 || ARCH_EFM32 || ARCH_STM32
>>          default "11"
>>
> This looks wrong now that we can enable multiple ARMV7M platforms
> together. In practice it doesn't matter much, because you wouldn't
> do that for a real-life system, but out of principle this seems
> like something you'd better put into the defconfig file for
> both ARCH_EFM32 and ARCH_STM32. We could also think about changing
> the default to "9" for any ARM_SINGLE_ARMV7M config and increasing
> it again in defconfig for any platform that actually has a lot of
> RAM (if any).
>

Both proposals seem reasonable.
I propose to make this entry configurable in defconfig if ARM_SINGLE_ARMV7M,
keeping the default to 11. Then, in efm32 and stm32 defconfig files, 
select value 9.

Uwe, is it ok for you?

Regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web