Re: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9

From	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9
Date	2015-08-25 23:10 +0200
Message-ID	<q1tDH-1uW-5@gated-at.bofh.it> (permalink)
References	<q1sHD-7Q-9@gated-at.bofh.it> <q1taF-He-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 08/25/2015 10:36 PM, Arnd Bergmann wrote:
> On Tuesday 25 August 2015 22:07:17 Maxime Coquelin wrote:
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index a750c14..57d53af 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1734,7 +1734,7 @@ config FORCE_MAX_ZONEORDER
>>          int "Maximum zone order" if ARCH_SHMOBILE_LEGACY
>>          range 11 64 if ARCH_SHMOBILE_LEGACY
>>          default "12" if SOC_AM33XX
>> -       default "9" if SA1111 || ARCH_EFM32
>> +       default "9" if SA1111 || ARCH_EFM32 || ARCH_STM32
>>          default "11"
>>
> This looks wrong now that we can enable multiple ARMV7M platforms
> together. In practice it doesn't matter much, because you wouldn't
> do that for a real-life system, but out of principle this seems
> like something you'd better put into the defconfig file for
> both ARCH_EFM32 and ARCH_STM32. We could also think about changing
> the default to "9" for any ARM_SINGLE_ARMV7M config and increasing
> it again in defconfig for any platform that actually has a lot of
> RAM (if any).
>

Both proposals seem reasonable.
I propose to make this entry configurable in defconfig if ARM_SINGLE_ARMV7M,
keeping the default to 11. Then, in efm32 and stm32 defconfig files, 
select value 9.

Uwe, is it ok for you?

Regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9 Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-08-25 22:10 +0200
  Re: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9 Arnd Bergmann <arnd@arndb.de> - 2015-08-25 22:40 +0200
    Re: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9 Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-08-25 23:10 +0200

csiph-web