Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213248 > unrolled thread

Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical  clocks Michael Turquette <mturquette@baylibre.com> - 2015-08-25 21:10 +0200
    Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks Heiko Stuebner <heiko@sntech.de> - 2015-08-25 22:20 +0200
    [PATCH v3] clk: rockchip: add pclk_cpu to the list of rk3188 critical  clocks Michael Niewoehner <linux@mniewoehner.de> - 2015-08-25 22:30 +0200

#1213248 — Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

Quoting Michael Niewoehner (2015-08-17 12:50:53)
> pclk_cpu needs to keep running because it is needed for devices like
> the act8865 regulator but with the recent gpio clock handling this is
> not always the case anymore. So add it to the list of critical clocks.
> 
> Signed-off-by: Michael Niewoehner <linux@mniewoehner.de>

Patch fails to apply due to a problem with line 15. git format-patch
problem?

Regards,
Mike

> ---
> Changes in v2:
> - adapt commit message
> - add Linus Walleij to recipients, as the patch is related to the gpio clock
>   change in the rockchip pinctrl driver it should go through his tree as well
> 
> drivers/clk/rockchip/clk-rk3188.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/rockchip/clk-rk3188.c b/drivers/clk/rockchip/clk-rk3188.c
> index e4f9d47..1c93229 100644
> --- a/drivers/clk/rockchip/clk-rk3188.c
> +++ b/drivers/clk/rockchip/clk-rk3188.c
> @@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {
>         "aclk_cpu",
>         "aclk_peri",
>         "hclk_peri",
> +       "pclk_cpu",
> };
> 
> static void __init rk3188_common_clk_init(struct device_node *np)
> -- 
> 2.5.0
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1213298 — Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

Am Dienstag, 25. August 2015, 11:59:31 schrieb Michael Turquette:
> Quoting Michael Niewoehner (2015-08-17 12:50:53)
> 
> > pclk_cpu needs to keep running because it is needed for devices like
> > the act8865 regulator but with the recent gpio clock handling this is
> > not always the case anymore. So add it to the list of critical clocks.
> > 
> > Signed-off-by: Michael Niewoehner <linux@mniewoehner.de>
> 
> Patch fails to apply due to a problem with line 15. git format-patch
> problem?

see comment below. We triggered this problem with a change to the pinctrl 
driver and another clock-entry to the critical clocks already went into Linus' 
pinctrl tree. So I guess this patch should probably also go through his tree - 
or just go in through any tree after 4.3-rc1.


> 
> Regards,
> Mike
> 
> > ---
> > Changes in v2:
> > - adapt commit message
> > - add Linus Walleij to recipients, as the patch is related to the gpio
> > clock> 
> >   change in the rockchip pinctrl driver it should go through his tree as
> >   well
> > 
> > drivers/clk/rockchip/clk-rk3188.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/rockchip/clk-rk3188.c
> > b/drivers/clk/rockchip/clk-rk3188.c index e4f9d47..1c93229 100644
> > --- a/drivers/clk/rockchip/clk-rk3188.c
> > +++ b/drivers/clk/rockchip/clk-rk3188.c
> > @@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]
> > __initconst = {> 
> >         "aclk_cpu",
> >         "aclk_peri",
> >         "hclk_peri",
> > 
> > +       "pclk_cpu",
> > };
> > 
> > static void __init rk3188_common_clk_init(struct device_node *np)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1213313 — [PATCH v3] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

pclk_cpu needs to keep running because it is needed for devices like
the act8865 regulator but with the recent gpio clock handling this is
not always the case anymore. So add it to the list of critical clocks.

Signed-off-by: Michael Niewoehner <linux@mniewoehner.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---
Changes in v3:
- fix git format-patch problem

Changes in v2:
- adapt commit message
- add Linus Walleij to recipients, as the patch is related to the gpio clock
 change in the rockchip pinctrl driver it should go through his tree as well

 drivers/clk/rockchip/clk-rk3188.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/rockchip/clk-rk3188.c b/drivers/clk/rockchip/clk-rk3188.c
index ed02bbc..f63a642 100644
--- a/drivers/clk/rockchip/clk-rk3188.c
+++ b/drivers/clk/rockchip/clk-rk3188.c
@@ -716,6 +716,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {
 	"aclk_cpu",
 	"aclk_peri",
 	"hclk_peri",
+	"pclk_cpu",
 };
 
 static void __init rk3188_common_clk_init(struct device_node *np)
-- 
2.5.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web