Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1213298

Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks

From Heiko Stuebner <heiko@sntech.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks
Date 2015-08-25 22:20 +0200
Message-ID <q1sRk-ky-21@gated-at.bofh.it> (permalink)
References <pYwRt-654-17@gated-at.bofh.it> <pYyJz-lu-11@gated-at.bofh.it> <q1rLz-77n-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Am Dienstag, 25. August 2015, 11:59:31 schrieb Michael Turquette:
> Quoting Michael Niewoehner (2015-08-17 12:50:53)
> 
> > pclk_cpu needs to keep running because it is needed for devices like
> > the act8865 regulator but with the recent gpio clock handling this is
> > not always the case anymore. So add it to the list of critical clocks.
> > 
> > Signed-off-by: Michael Niewoehner <linux@mniewoehner.de>
> 
> Patch fails to apply due to a problem with line 15. git format-patch
> problem?

see comment below. We triggered this problem with a change to the pinctrl 
driver and another clock-entry to the critical clocks already went into Linus' 
pinctrl tree. So I guess this patch should probably also go through his tree - 
or just go in through any tree after 4.3-rc1.


> 
> Regards,
> Mike
> 
> > ---
> > Changes in v2:
> > - adapt commit message
> > - add Linus Walleij to recipients, as the patch is related to the gpio
> > clock> 
> >   change in the rockchip pinctrl driver it should go through his tree as
> >   well
> > 
> > drivers/clk/rockchip/clk-rk3188.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/rockchip/clk-rk3188.c
> > b/drivers/clk/rockchip/clk-rk3188.c index e4f9d47..1c93229 100644
> > --- a/drivers/clk/rockchip/clk-rk3188.c
> > +++ b/drivers/clk/rockchip/clk-rk3188.c
> > @@ -708,6 +708,7 @@ static const char *const rk3188_critical_clocks[]
> > __initconst = {> 
> >         "aclk_cpu",
> >         "aclk_peri",
> >         "hclk_peri",
> > 
> > +       "pclk_cpu",
> > };
> > 
> > static void __init rk3188_common_clk_init(struct device_node *np)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical  clocks Michael Turquette <mturquette@baylibre.com> - 2015-08-25 21:10 +0200
  Re: [PATCH v2] clk: rockchip: add pclk_cpu to the list of rk3188 critical clocks Heiko Stuebner <heiko@sntech.de> - 2015-08-25 22:20 +0200
  [PATCH v3] clk: rockchip: add pclk_cpu to the list of rk3188 critical  clocks Michael Niewoehner <linux@mniewoehner.de> - 2015-08-25 22:30 +0200

csiph-web