Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1212521 > unrolled thread

Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

Started byStephen Boyd <sboyd@codeaurora.org>
First post2015-08-24 23:30 +0200
Last post2015-08-25 20:00 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] clk: Add missing header for 'bool' definition to  clk-conf.h Stephen Boyd <sboyd@codeaurora.org> - 2015-08-24 23:30 +0200
    Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h Chen-Yu Tsai <wens@csie.org> - 2015-08-25 05:00 +0200
      Re: [PATCH] clk: Add missing header for 'bool' definition to  clk-conf.h Michal Kubecek <mkubecek@suse.cz> - 2015-08-25 09:00 +0200
        Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h Chen-Yu Tsai <wens@csie.org> - 2015-08-25 09:50 +0200
          Re: [PATCH] clk: Add missing header for 'bool' definition to  clk-conf.h Stephen Boyd <sboyd@codeaurora.org> - 2015-08-25 20:00 +0200

#1212521 — Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-08-24 23:30 +0200
SubjectRe: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h
Message-ID<q17tw-31O-21@gated-at.bofh.it>
On 08/18, Chen-Yu Tsai wrote:
> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
> include its definition.
> 
> This results in a compile error when only clk-conf.h is used.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Cc: stable@vger.kernel.org

Why is stable Cc-ed? Is there some sort of compilation failure on
stable kernels?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1212673 — Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

FromChen-Yu Tsai <wens@csie.org>
Date2015-08-25 05:00 +0200
SubjectRe: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h
Message-ID<q1cCR-21v-3@gated-at.bofh.it>
In reply to#1212521
On Tue, Aug 25, 2015 at 5:28 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 08/18, Chen-Yu Tsai wrote:
>> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
>> include its definition.
>>
>> This results in a compile error when only clk-conf.h is used.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> Cc: stable@vger.kernel.org
>
> Why is stable Cc-ed? Is there some sort of compilation failure on
> stable kernels?

There isn't for now. Though I don't see why we shouldn't fix this for
stable kernels as well. It's possible other people or third-party
vendors working with stable/LTS kernels (Android?) may run into it.

I'm perfectly fine with not Cc-ing stable. It just seemed like the
right thing to do.


Regards
ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1212738

FromMichal Kubecek <mkubecek@suse.cz>
Date2015-08-25 09:00 +0200
Message-ID<q1gn8-7jI-21@gated-at.bofh.it>
In reply to#1212673
On Tue, Aug 25, 2015 at 10:55:28AM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 25, 2015 at 5:28 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 08/18, Chen-Yu Tsai wrote:
> >> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
> >> include its definition.
> >>
> >> This results in a compile error when only clk-conf.h is used.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> Cc: stable@vger.kernel.org
> >
> > Why is stable Cc-ed? Is there some sort of compilation failure on
> > stable kernels?
> 
> There isn't for now. Though I don't see why we shouldn't fix this for
> stable kernels as well. It's possible other people or third-party
> vendors working with stable/LTS kernels (Android?) may run into it.

How about 

   - It must fix a real bug that bothers people (not a, "This could be a
   problem..." type thing).

in Documentation/stable_kernel_rules.txt?

Michal Kubecek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1212772 — Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

FromChen-Yu Tsai <wens@csie.org>
Date2015-08-25 09:50 +0200
SubjectRe: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h
Message-ID<q1h9w-8th-21@gated-at.bofh.it>
In reply to#1212738
On Tue, Aug 25, 2015 at 2:59 PM, Michal Kubecek <mkubecek@suse.cz> wrote:
> On Tue, Aug 25, 2015 at 10:55:28AM +0800, Chen-Yu Tsai wrote:
>> On Tue, Aug 25, 2015 at 5:28 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> > On 08/18, Chen-Yu Tsai wrote:
>> >> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
>> >> include its definition.
>> >>
>> >> This results in a compile error when only clk-conf.h is used.
>> >>
>> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> >> Cc: stable@vger.kernel.org
>> >
>> > Why is stable Cc-ed? Is there some sort of compilation failure on
>> > stable kernels?
>>
>> There isn't for now. Though I don't see why we shouldn't fix this for
>> stable kernels as well. It's possible other people or third-party
>> vendors working with stable/LTS kernels (Android?) may run into it.
>
> How about
>
>    - It must fix a real bug that bothers people (not a, "This could be a
>    problem..." type thing).
>
> in Documentation/stable_kernel_rules.txt?

My bad. I'll send a new version without the CC.

ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1213211

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-08-25 20:00 +0200
Message-ID<q1qFQ-5kX-29@gated-at.bofh.it>
In reply to#1212772
On 08/25, Chen-Yu Tsai wrote:
> On Tue, Aug 25, 2015 at 2:59 PM, Michal Kubecek <mkubecek@suse.cz> wrote:
> >
> > How about
> >
> >    - It must fix a real bug that bothers people (not a, "This could be a
> >    problem..." type thing).
> >
> > in Documentation/stable_kernel_rules.txt?
> 
> My bad. I'll send a new version without the CC.

No need. I'll strip off the cc when applying.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web