Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212918 > unrolled thread

[PATCH] irqdomain: remove the confused log

Back to article view | Back to linux.kernel

Contents

  [PATCH] irqdomain: remove the confused log Huang Shijie <shijie.huang@arm.com> - 2015-08-25 11:50 +0200
    Re: [PATCH] irqdomain: remove the confused log Thomas Gleixner <tglx@linutronix.de> - 2015-08-25 21:40 +0200
      Re: [PATCH] irqdomain: remove the confused log Huang Shijie <shijie.huang@arm.com> - 2015-08-26 03:40 +0200
        Re: [PATCH] irqdomain: remove the confused log Thomas Gleixner <tglx@linutronix.de> - 2015-08-26 10:00 +0200

#1212918 — [PATCH] irqdomain: remove the confused log

When the dynamic debug is enabled for irq domain, the kernel will print out:
  ------------------------------------------------------
    irqdomain:__irq_domain_add: irq: Added domain (null)
  ------------------------------------------------------

It does not print out the irq domain's name, since the @domain->name is NULL.
Keep the log here just makes people nervous.

Signed-off-by: Huang Shijie <shijie.huang@arm.com>
---
 kernel/irq/irqdomain.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 79baaf8..8c582de 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -66,7 +66,6 @@ struct irq_domain *__irq_domain_add(struct device_node *of_node, int size,
 	list_add(&domain->link, &irq_domain_list);
 	mutex_unlock(&irq_domain_mutex);
 
-	pr_debug("Added domain %s\n", domain->name);
 	return domain;
 }
 EXPORT_SYMBOL_GPL(__irq_domain_add);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1213272

On Tue, 25 Aug 2015, Huang Shijie wrote:

> When the dynamic debug is enabled for irq domain, the kernel will print out:
>   ------------------------------------------------------
>     irqdomain:__irq_domain_add: irq: Added domain (null)
>   ------------------------------------------------------
> 
> It does not print out the irq domain's name, since the @domain->name is NULL.
> Keep the log here just makes people nervous.

Well, it might be NULL in your case, but there are enough cases where
its not NULL and the output valuable. 


Aside of that I don't understand what's making one nervous
here. People who enable that debug stuff should know that this can be
NULL and just deal with it. If they get nervous about it they probably
should not try to debug that code in the first place.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1213479

On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote:
> On Tue, 25 Aug 2015, Huang Shijie wrote:
> 
> > When the dynamic debug is enabled for irq domain, the kernel will print out:
> >   ------------------------------------------------------
> >     irqdomain:__irq_domain_add: irq: Added domain (null)
> >   ------------------------------------------------------
> > 
> > It does not print out the irq domain's name, since the @domain->name is NULL.
> > Keep the log here just makes people nervous.
> 
> Well, it might be NULL in your case, but there are enough cases where
> its not NULL and the output valuable. 
In which case ?

The domain is allocated by kzalloc_node(), so @domain->name is NULL in the function.
The @domain->name is set in other function, such as irq_domain_associate().

> 
> 
> Aside of that I don't understand what's making one nervous
> here. People who enable that debug stuff should know that this can be
> NULL and just deal with it. If they get nervous about it they probably
> should not try to debug that code in the first place.
okay.

thanks
Huang Shijie

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1213635

On Wed, 26 Aug 2015, Huang Shijie wrote:
> On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote:
> > On Tue, 25 Aug 2015, Huang Shijie wrote:
> > 
> > > When the dynamic debug is enabled for irq domain, the kernel will print out:
> > >   ------------------------------------------------------
> > >     irqdomain:__irq_domain_add: irq: Added domain (null)
> > >   ------------------------------------------------------
> > > 
> > > It does not print out the irq domain's name, since the @domain->name is NULL.
> > > Keep the log here just makes people nervous.
> > 
> > Well, it might be NULL in your case, but there are enough cases where
> > its not NULL and the output valuable. 
> In which case ?
> 
> The domain is allocated by kzalloc_node(), so @domain->name is NULL in the function.
> The @domain->name is set in other function, such as irq_domain_associate().

Indeed. I misread the patch, sorry. Yes that thing can go.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web