Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213635

Re: [PATCH] irqdomain: remove the confused log

Show all headers | View raw

On Wed, 26 Aug 2015, Huang Shijie wrote:
> On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote:
> > On Tue, 25 Aug 2015, Huang Shijie wrote:
> > 
> > > When the dynamic debug is enabled for irq domain, the kernel will print out:
> > >   ------------------------------------------------------
> > >     irqdomain:__irq_domain_add: irq: Added domain (null)
> > >   ------------------------------------------------------
> > > 
> > > It does not print out the irq domain's name, since the @domain->name is NULL.
> > > Keep the log here just makes people nervous.
> > 
> > Well, it might be NULL in your case, but there are enough cases where
> > its not NULL and the output valuable. 
> In which case ?
> 
> The domain is allocated by kzalloc_node(), so @domain->name is NULL in the function.
> The @domain->name is set in other function, such as irq_domain_associate().

Indeed. I misread the patch, sorry. Yes that thing can go.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] irqdomain: remove the confused log Huang Shijie <shijie.huang@arm.com> - 2015-08-25 11:50 +0200
  Re: [PATCH] irqdomain: remove the confused log Thomas Gleixner <tglx@linutronix.de> - 2015-08-25 21:40 +0200
    Re: [PATCH] irqdomain: remove the confused log Huang Shijie <shijie.huang@arm.com> - 2015-08-26 03:40 +0200
      Re: [PATCH] irqdomain: remove the confused log Thomas Gleixner <tglx@linutronix.de> - 2015-08-26 10:00 +0200

csiph-web