Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213521 > unrolled thread

[PATCH 0/8] fix drivers/staging/android several coding style issues

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/8] fix drivers/staging/android several coding style issues Peng Sun <sironhide0null@gmail.com> - 2015-08-26 06:00 +0200
    [PATCH 1/8] fix staging:android style issue:spaces preferred around that '-' Peng Sun <sironhide0null@gmail.com> - 2015-08-26 06:00 +0200
    Re: [PATCH 0/8] fix drivers/staging/android several coding style  issues Greg KH <gregkh@linuxfoundation.org> - 2015-09-03 03:10 +0200

#1213521 — [PATCH 0/8] fix drivers/staging/android several coding style issues

patches based on linux-next next-20150825
Corrections based on checkpatch.pl with --strict

Peng Sun (8):
  fix staging:android style issue:spaces preferred around that '-'
  fix staging:android style issue:No space is necessary after a cast
  fix staging:android style issue:Alignment should match open
    parenthesis
  fix staging:android style issue:Prefer kernel type 'u32' over
    'uint32_t'
  fix staging:android style issue:Please use a blank line after
    function/struct/union/enum declarations
  fix staging:android style issue:Comparison to NULL could be written
  fix staging:android style issue:definition without comment
  fix staging:android style issue:Please don't use multiple blank lines

 drivers/staging/android/ashmem.c          | 15 ++++++++-------
 drivers/staging/android/lowmemorykiller.c |  9 +++++----
 drivers/staging/android/sw_sync.c         |  6 +++---
 drivers/staging/android/sync.c            | 22 +++++++++++-----------
 drivers/staging/android/sync.h            |  4 ++--
 drivers/staging/android/timed_gpio.c      | 15 ++++++++-------
 6 files changed, 37 insertions(+), 34 deletions(-)

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1213524 — [PATCH 1/8] fix staging:android style issue:spaces preferred around that '-'

Signed-off-by: Peng Sun <sironhide0null@gmail.com>
---
 drivers/staging/android/ashmem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 60200a3..b340ddc 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -618,7 +618,8 @@ static int ashmem_pin(struct ashmem_area *asma, size_t pgstart, size_t pgend)
 
 			/* Case #3: We overlap from the rear, so adjust it */
 			if (range->pgend <= pgend) {
-				range_shrink(range, range->pgstart, pgstart-1);
+				range_shrink(range, range->pgstart,
+					     pgstart - 1);
 				continue;
 			}
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1217983 — Re: [PATCH 0/8] fix drivers/staging/android several coding style issues

On Wed, Aug 26, 2015 at 11:52:09AM +0800, Peng Sun wrote:
> patches based on linux-next next-20150825
> Corrections based on checkpatch.pl with --strict
> 
> Peng Sun (8):
>   fix staging:android style issue:spaces preferred around that '-'
>   fix staging:android style issue:No space is necessary after a cast
>   fix staging:android style issue:Alignment should match open
>     parenthesis
>   fix staging:android style issue:Prefer kernel type 'u32' over
>     'uint32_t'
>   fix staging:android style issue:Please use a blank line after
>     function/struct/union/enum declarations
>   fix staging:android style issue:Comparison to NULL could be written
>   fix staging:android style issue:definition without comment
>   fix staging:android style issue:Please don't use multiple blank lines

You sent out 3 different series, and I don't know which should be
applied.  So please fix up and resend just the one you want applied.

Note, the "style issue:" shouldn't be in the subject, look at how other
commits are titled.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web