Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1217983

Re: [PATCH 0/8] fix drivers/staging/android several coding style issues

Show all headers | View raw

On Wed, Aug 26, 2015 at 11:52:09AM +0800, Peng Sun wrote:
> patches based on linux-next next-20150825
> Corrections based on checkpatch.pl with --strict
> 
> Peng Sun (8):
>   fix staging:android style issue:spaces preferred around that '-'
>   fix staging:android style issue:No space is necessary after a cast
>   fix staging:android style issue:Alignment should match open
>     parenthesis
>   fix staging:android style issue:Prefer kernel type 'u32' over
>     'uint32_t'
>   fix staging:android style issue:Please use a blank line after
>     function/struct/union/enum declarations
>   fix staging:android style issue:Comparison to NULL could be written
>   fix staging:android style issue:definition without comment
>   fix staging:android style issue:Please don't use multiple blank lines

You sent out 3 different series, and I don't know which should be
applied.  So please fix up and resend just the one you want applied.

Note, the "style issue:" shouldn't be in the subject, look at how other
commits are titled.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] fix drivers/staging/android several coding style issues Peng Sun <sironhide0null@gmail.com> - 2015-08-26 06:00 +0200
  [PATCH 1/8] fix staging:android style issue:spaces preferred around that '-' Peng Sun <sironhide0null@gmail.com> - 2015-08-26 06:00 +0200
  Re: [PATCH 0/8] fix drivers/staging/android several coding style  issues Greg KH <gregkh@linuxfoundation.org> - 2015-09-03 03:10 +0200

csiph-web