Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212103 > unrolled thread

Re: [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency Wolfram Sang <wsa@the-dreams.de> - 2015-08-24 14:20 +0200

#1212103 — Re: [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency

[Multipart message — attachments visible in raw view] — view raw

On Wed, Aug 19, 2015 at 01:19:57PM +0200, Javier Martinez Canillas wrote:
> The ChromeOS EC tunnel I2C bus driver depend on CROS_EC_PROTO but
> MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends
> on is bad practice as it may lead to circular Kconfig dependencies.
> 
> Since the platform device that is matched with the I2C bus driver
> is registered by the ChromeOS EC mfd driver, I2C_CROS_EC_TUNNEL
> really depends on MFD_CROS_EC. And because this config option
> selects CROS_EC_PROTO, that dependency is met as well. So make the
> driver to depend on MFD_CROS_EC instead of CROS_EC_PROTO.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

Applied to for-next, thanks!

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web