Re: [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency
Date	2015-08-24 14:20 +0200
Message-ID	<q0YTf-7q8-5@gated-at.bofh.it> (permalink)
References	<pZ9J7-4sk-3@gated-at.bofh.it> <pZ9J8-4sk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 19, 2015 at 01:19:57PM +0200, Javier Martinez Canillas wrote:
> The ChromeOS EC tunnel I2C bus driver depend on CROS_EC_PROTO but
> MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends
> on is bad practice as it may lead to circular Kconfig dependencies.
> 
> Since the platform device that is matched with the I2C bus driver
> is registered by the ChromeOS EC mfd driver, I2C_CROS_EC_TUNNEL
> really depends on MFD_CROS_EC. And because this config option
> selects CROS_EC_PROTO, that dependency is met as well. So make the
> driver to depend on MFD_CROS_EC instead of CROS_EC_PROTO.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

Applied to for-next, thanks!

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency Wolfram Sang <wsa@the-dreams.de> - 2015-08-24 14:20 +0200

csiph-web